From 7c3c51b8ff3d41a2714e6d3a1379f2357b5bebc7 Mon Sep 17 00:00:00 2001 From: Trevor Norris Date: Tue, 23 Sep 2014 13:19:31 -0700 Subject: buffer: fix map and set parent to undefined In 4c9b30d removal of the prototype attributes meant NativeBuffer() no longer had the same object map as Buffer(). By now setting the same properties in the same order both constructors will produce the same map. The same commit changed "parent" from undefined to null. This caused a failure in Buffer#slice() where it was checked if parent === undefined. Causing the incorrect parent to be set. Signed-off-by: Trevor Norris --- lib/buffer.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib/buffer.js') diff --git a/lib/buffer.js b/lib/buffer.js index adb551a9e..ed1591584 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -66,7 +66,7 @@ function Buffer(subject, encoding) { 'size: 0x' + kMaxLength.toString(16) + ' bytes'); } - this.parent = null; + this.parent = undefined; if (this.length <= (Buffer.poolSize >>> 1) && this.length > 0) { if (this.length > poolSize - poolOffset) createPool(); @@ -118,7 +118,9 @@ function SlowBuffer(length) { // Objects created in C++. Significantly faster than calling the Buffer // function. function NativeBuffer(length) { - this.length = length; + this.length = length >>> 0; + // Set this to keep the object map the same. + this.parent = undefined; } NativeBuffer.prototype = Buffer.prototype; -- cgit v1.2.3