From 7a272d92e3e4ba1cc98e4f1b977552da89ec55bf Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Fri, 4 Mar 2011 10:37:34 -0600 Subject: cmake: explicitly disable fdatasync when building for OSX. This ensures that the check_function_exists() for fdatasync in the libeio CMakeLists.txt is not run, since that fails on some versions of OSX (http://public.kitware.com/Bug/view.php?id=10044). --- cmake/configure.cmake | 2 ++ 1 file changed, 2 insertions(+) (limited to 'cmake') diff --git a/cmake/configure.cmake b/cmake/configure.cmake index 81f721e2c..c05575300 100644 --- a/cmake/configure.cmake +++ b/cmake/configure.cmake @@ -61,6 +61,8 @@ endif() if(${node_platform} MATCHES darwin) set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -framework Carbon") + # explicitly set this so that we don't check again when building libeio + set(HAVE_FDATASYNC 0) else() # OSX fdatasync() check wrong: http://public.kitware.com/Bug/view.php?id=10044 check_function_exists(fdatasync HAVE_FDATASYNC) -- cgit v1.2.3 From 74954ce7d8b4b734302d295d0c816f04a694254e Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 8 Mar 2011 00:00:51 -0600 Subject: Add string class that uses ExternalAsciiStringResource. Change the natives to use this class instead of creating completely new strings. Reduces memory usage by about 1 MB. --- cmake/node_build.cmake | 1 + 1 file changed, 1 insertion(+) (limited to 'cmake') diff --git a/cmake/node_build.cmake b/cmake/node_build.cmake index 295bb3e63..9d89432f0 100644 --- a/cmake/node_build.cmake +++ b/cmake/node_build.cmake @@ -62,6 +62,7 @@ set(node_sources src/node_script.cc src/node_os.cc src/node_dtrace.cc + src/node_string.cc src/node_natives.h ${node_extra_src}) -- cgit v1.2.3