summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-06-30net: wrap connect in nextTickEvan Lucas1-1/+3
Fixes an edge case regression introduced in 1bef71747678c19c7214048de5b9e3848889248d. With the lookup being skipped, an error could be emitted before an error listener has been added. An example of this was presented by changing the server’s IP address and then immediately making a request to the old address. Related: https://github.com/nodejs/io.js/pull/1823 PR-URL: https://github.com/nodejs/io.js/pull/2054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
2015-06-30_stream_wrap: prevent use after free in TLSFedor Indutny7-33/+239
Queued write requests should be invoked on handle close, otherwise the "consumer" might be already destroyed when the write callbacks of the "consumed" handle will be invoked. Same applies to the shutdown requests. Make sure to "move" away socket from server to not break the `connections` counter in `net.js`. Otherwise it might not call `close` callback, or call it too early. Fix: https://github.com/iojs/io.js/issues/1696 PR-URL: https://github.com/nodejs/io.js/pull/1910 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-30url: fix typo in commentRich Trott1-1/+1
PR-URL: https://github.com/nodejs/io.js/pull/2071 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2015-06-30tools: fix gyp to work on MacOSX without XCodeShigeki Ohtsu1-0/+2
This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-30tools: update gyp to 25ed9acBen Noordhuis16-1887/+399
Includes improved support for VS 2015[0] and makes it possible to build with ninja again[1]. [0] https://codereview.chromium.org/1112753003 [1] https://codereview.chromium.org/1209553002 Fixes: https://github.com/nodejs/io.js/pull/2065 PR-URL: https://github.com/nodejs/io.js/pull/2074 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
2015-06-29benchmark: make concurrent requests configurableRich Trott1-10/+23
In http_bench.js, allow the concurrent requests per client to be configurable. This also changes the launch of clients to wait until all forked servers are online. This eliminates spurious error messages at the start of the run. PR-URL: https://github.com/nodejs/io.js/pull/2068 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-29benchmark: fix typo in READMERich Trott1-1/+1
PR-URL: https://github.com/nodejs/io.js/pull/2067 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2015-06-29tools: re-enable comma-spacing linter ruleRoman Reiss11-18/+17
The rule was disabled because of an eslint bug which is now resolved. All code in lib was already conforming and only test code needed a few changes to make the linter happy with this rule enabled. Ref: https://github.com/eslint/eslint/issues/2408 PR-URL: https://github.com/nodejs/io.js/pull/2072 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alex Kocharin <alex@kocharin.ru>
2015-06-29tools: update eslint to 0.24.0Roman Reiss1046-4656/+101443
PR-URL: https://github.com/nodejs/io.js/pull/2072 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alex Kocharin <alex@kocharin.ru>
2015-06-29v8: cherry-pick JitCodeEvent patch from upstreamBen Noordhuis1-1/+1
Original commit log follows: Meaningful name for builtins in JitCodeEvent API. Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline") instead of labeling everything "Builtin:A builtin from the snapshot" Review URL: https://codereview.chromium.org/1216833002 PR-URL: https://github.com/nodejs/io.js/pull/2075 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-27crypto: fix VerifyCallback in case of verify errorShigeki Ohtsu2-25/+66
3beb880716654dbb2bbb9e333758825172951775 has a bug in VerifyCallback when preverify is 1 and the cert chain has an verify error. If the error is UNABLE_TO_GET_ISSUER_CERT_LOCALLY, it leads an assertion error in finding rootCA. The whitelist check should be made only when the cert chain has no verify error with X509_V_OK. Fixes: https://github.com/nodejs/io.js/issues/2061 PR-URL: https://github.com/nodejs/io.js/pull/2064 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-26src: nix stdin _readableState.reading manipulationChris Dickinson1-2/+2
this opts for stream.push('') which has the same effect but uses a public API. PR-URL: https://github.com/nodejs/io.js/pull/454 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
2015-06-26net: fix debug for dnsoptsEvan Lucas1-1/+1
Prevent debug call from showing [object Object] for dnsopts in lookupAndConnect PR-URL: https://github.com/nodejs/io.js/pull/2059 Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
2015-06-25buffer: prevent abort on bad protoTrevor Norris3-6/+88
If an object's prototype is munged it's possible to bypass the instanceof check and cause the application to abort. Instead now use HasInstance() to verify that the object is a Buffer, and throw if not. This check will not work for JS only methods. So while the application won't abort, it also won't throw. In order to properly throw in all cases with toString() the JS optimization of checking that length is zero has been removed. In its place the native methods will now return early if a zero length string is detected. Ref: https://github.com/nodejs/io.js/pull/1486 Ref: https://github.com/nodejs/io.js/pull/1922 Fixes: https://github.com/nodejs/io.js/issues/1485 PR-URL: https://github.com/nodejs/io.js/pull/2012 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-25test: purge stale disabled testsRich Trott25-1431/+0
Tests in the disabled directory are not used by Makefile nor by the CI. Other than a single 2015 commit that puts 'use strict' in each test, many of them haven't been touched in years. This removes all the disabled tests that have been unmodified since 2011 (with the exception of the 'use strict' modification mentioned above). PR-URL: https://github.com/nodejs/io.js/pull/2045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
2015-06-25test: do not swallow OpenSSL support errorRich Trott1-14/+1
PR-URL: https://github.com/nodejs/io.js/pull/2042 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
2015-06-25buffer: optimize Buffer#toString()Ben Noordhuis2-2/+37
Break up Buffer#toString() into a fast and slow path. The fast path optimizes for zero-length buffers and no-arg method invocation. The speedup for zero-length buffers is a satisfying 700%. The no-arg toString() operation gets faster by about 13% for a one-byte buffer. This change exploits the fact that most Buffer#toString() calls are plain no-arg method calls. Rewriting the method to take no arguments means a call doesn't go through an ArgumentsAdaptorTrampoline stack frame in the common case. PR-URL: https://github.com/nodejs/io.js/pull/2027 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Christian Tellnes <christian@tellnes.no> Reviewed-By: Daniel Cousens <email@dcousens.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-25test: fix test-repl-tab-complete.jscjihrig1-23/+49
test-repl-tab-complete.js contains numerous assertions that are never run. Anything that results in a ReferenceError bails out, and never calls the functions containing the assertions. This commit adds checking for successful tab completions, as well as ReferenceErrors. PR-URL: https://github.com/nodejs/io.js/pull/2052 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-25repl: make 'Unexpected token' errors recoverableJulien Gilli2-1/+34
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: https://github.com/joyent/node/issues/8874 PR-URL: https://github.com/joyent/node/pull/8875 PR-URL: https://github.com/nodejs/io.js/pull/2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-25repl: fix tab completion for a non-global contextSangmin Yoon2-3/+11
Use vm.isContext() to properly identify contexts. PR-URL: https://github.com/joyent/node/pull/25382 PR-URL: https://github.com/nodejs/io.js/pull/2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-25doc: make the abbreviation 1MM clearIvan Yan1-1/+1
Refs: https://github.com/nodejs/io.js/pull/2050 PR-URL: https://github.com/nodejs/io.js/pull/2053 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2015-06-25build: add tar-headers target for headers-only tarRod Vagg2-3/+34
to replace the full src download by node-gyp, using the proper format instead of the full source format PR-URL: https://github.com/nodejs/io.js/pull/1975 Reviewed-By: William Blankenship <william.jblankenship@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
2015-06-25deps: copy all openssl header files to include dirShigeki Ohtsu76-80/+38359
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: https://github.com/nodejs/io.js/pull/1975 PR-URL: https://github.com/nodejs/io.js/pull/2016 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
2015-06-25build: update build targets for io.jsRod Vagg12-89/+281
PR-URL: https://github.com/nodejs/io.js/pull/1938 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
2015-06-24test: check for error on WindowsRich Trott1-5/+10
Instead of not running the dgram-bind-shared-ports on Windows, check that it gets ENOTSUP. PR-URL: https://github.com/nodejs/io.js/pull/2035 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2015-06-25build: fix cherry-pick ooops, fix comment wordingRod Vagg1-2/+2
PR-URL: https://github.com/nodejs/io.js/pull/2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
2015-06-25build: add MSVS 2015 supportRod Vagg1-0/+12
PR-URL: https://github.com/nodejs/io.js/pull/2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
2015-06-25build,win: set env before generating projectsAlexis Campailla1-18/+18
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: https://github.com/joyent/node/pull/20109
2015-06-24doc: Added sample command to test iojs buildJimmy Hsu1-0/+12
PR-URL: https://github.com/nodejs/io.js/pull/850 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2015-06-25doc: add TSC meeting minutes 2015-06-17Rod Vagg1-0/+133
PR-URL: https://github.com/nodejs/io.js/pull/2048 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2015-06-24doc: clarify prerequisites in benchmark/README.mdJeremiah Senkpiel1-2/+6
PR-URL: https://github.com/nodejs/io.js/pull/2034 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-24doc: add TSC meeting minutes 2015-05-27Rod Vagg1-0/+142
closes: https://github.com/nodejs/node/issues/41 PR-URL: https://github.com/nodejs/io.js/pull/2037 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-24doc: archive io.js TC minutesRod Vagg20-0/+0
2015-06-24doc: rename tc-meetings to tsc-meetingsRod Vagg21-0/+0
2015-06-23test: remove obsolete TODO commentsRich Trott3-3/+0
The readfile/pipe tests rely on pre-existing pipes in the system. This arguably tests the OS functionality and not really io.js functionality. Removing TODOs. PR-URL: https://github.com/nodejs/io.js/pull/2033 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-23test: remove obsolete TODO commentsRich Trott2-8/+0
Not using test_ca.pem in these files anymore. Using elipses.txt which has multibyte chars. Not clear what constitutes "large" but that can be a different ticket if elipses.txt etc. are insufficiently large. PR-URL: https://github.com/nodejs/io.js/pull/2032 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
2015-06-23build: DTrace is enabled by default on darwinEvan Lucas1-1/+1
In configure, the --with-dtrace option only showed that it was true by default on sunos. It is also true by default on darwin. PR-URL: https://github.com/nodejs/io.js/pull/2019 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
2015-06-23doc: add TC meeting 2015-05-13 minutesRod Vagg1-0/+137
PR-URL: https://github.com/nodejs/io.js/pull/1700 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-23doc: add @shigeki and @mscdex to TCRod Vagg1-2/+2
voted in to Node.js Foundation TSC in meeting on 2015-06-17 Closes: https://github.com/nodejs/io.js/issues/1500 Closes: https://github.com/nodejs/io.js/issues/1501 PR-URL: https://github.com/nodejs/io.js/pull/2008 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-23Working on v2.3.2Rod Vagg1-2/+2
2015-06-232015-06-23 io.js v2.3.1 Releasev2.3.1Rod Vagg2-1/+69
PR-URL: https://github.com/nodejs/io.js/pull/1996 Notable changes * module: The number of syscalls made during a require() have been significantly reduced again (see #1801 from v2.2.0 for previous work), which should lead to a performance improvement (Pierre Inglebert) #1920. * npm: - Upgrade to v2.11.2 (Rebecca Turner) #1956. - Upgrade to v2.11.3 (Forrest L Norvell) #2018. * zlib: A bug was discovered where the process would abort if the final part of a zlib decompression results in a buffer that would exceed the maximum length of 0x3fffffff bytes (~1GiB). This was likely to only occur during buffered decompression (rather than streaming). This is now fixed and will instead result in a thrown RangeError (Michaël Zasso) #1811.
2015-06-22test: assert tmp and fixture dirs differentRich Trott1-2/+1
PR-URL: https://github.com/nodejs/io.js/pull/2015 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
2015-06-22module: fix stat with long paths on WindowsMichaël Zasso2-11/+17
PR-URL: https://github.com/nodejs/io.js/pull/2013 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-20test: confirm symlinkRich Trott1-4/+19
PR-URL: https://github.com/nodejs/io.js/pull/2014 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-19test: check result as early as possibleRich Trott1-4/+2
PR-URL: https://github.com/nodejs/io.js/pull/2007 Reviewed-By: Rod Vagg <rod@vagg.org>
2015-06-19doc: add security section to README.mdRod Vagg1-0/+9
PR-URL: https://github.com/nodejs/io.js/pull/1948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2015-06-19win,node-gyp: enable delay-load hook by defaultBert Belder1-1/+1
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. PR-URL: https://github.com/iojs/io.js/pull/1433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-19deps: make node-gyp work with io.jscjihrig3-25/+25
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d199276e21c1fa08d8df14eeb654c90cc5aa20, 5de334c23096492014a097ff487f07ad8eaee6d2, and da730c76e98fb9fd18dac445dafbbec74d79f802. This commit squashes them into a single commit. PR-URL: https://github.com/iojs/io.js/pull/990 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2015-06-19deps: upgrade to npm 2.11.3Forrest L Norvell162-489/+962
PR-URL: https://github.com/nodejs/io.js/pull/2018 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2015-06-19build: remove lint from test-ci on windowsJohan Bergström1-1/+1
PR-URL: https://github.com/nodejs/io.js/pull/2004 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <alexis@janeasystems.com>