summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-03-30test: improve test-npm-installSantiago Gimeno1-1/+8
Make npm install a dependency that is defined as a relative path, so it avoids any network interaction. PR-URL: https://github.com/nodejs/node/pull/5613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
2016-03-30test: add test-npm-install to parallel tests suiteMyles Borins1-0/+40
Currently we are not testing that `npm install` works. This is a very naive / basic test that shells out to `npm install` in an empty `tempDir`. While this test will not be able to check that `npm install` is 100% working, it should catch certain edge cases that break it. PR-URL: https://github.com/nodejs/node/pull/5166 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
2016-03-30test: repl tab completion testSantiago Gimeno1-0/+23
It checks that `eval` is called with `.scope` as an input string. PR-URL: https://github.com/nodejs/node/pull/5534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-30doc: update crypto docs to use good defaultsBill Automata1-4/+4
[Diffie-Hellman](https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation) keys are composed of a `generator` a `prime` a `secret_key` and the `public_key` resulting from the math operation: ``` (generator ^ secret_key) mod prime = public_key ``` Diffie-Hellman keypairs will compute a matching shared secret if and only if the generator and prime match for both recipients. The generator is usually **2** and the prime is what is called a [Safe Prime](https://en.wikipedia.org/wiki/Safe_prime). Usually this matching is accomplished by using [standard published groups](http://tools.ietf.org/html/rfc3526). We expose access those groups with the `crypto.getDiffieHellman` function. `createDiffieHellman` is trickier to use. The original example had the user creating 11 bit keys, and creating random groups of generators and primes. 11 bit keys are very very small, can be cracked by a single person on a single sheet of paper. A byproduct of using such small keys were that it was a high likelihood that two calls of `createDiffieHellman(11)` would result in using the same 11 bit safe prime. The original example code would fail when the safe primes generated at 11 bit lengths did not match for alice and bob. If you want to use your own generated safe `prime` then the proper use of `createDiffieHellman` is to pass the `prime` and `generator` to the recipient's constructor, so that when they compute the shared secret their `prime` and `generator` match, which is fundamental to the algorithm. PR-URL: https://github.com/nodejs/node/pull/5505 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-30doc: fix crypto update() signaturesBrian White1-9/+24
PR-URL: https://github.com/nodejs/node/pull/5500 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
2016-03-30net: make `isIPv4` and `isIPv6` more efficientVladimir Kurchatkin3-2/+54
`isIPv4` and `isIPv6` are implemented on top of `isIP`, which in turn checks the sting for being both IPv4 and IPv6, which can be inefficient in some scenarios. This commit makes them use `uv_inet_pton` directly instead. PR-URL: https://github.com/nodejs/node/pull/5478 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-30repl: fix stack trace column number in strict modePrince J Wesley2-4/+25
On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace. PR-URL: https://github.com/nodejs/node/pull/5416 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-30lib: simplify code with String.prototype.repeat()Jackson Tian14-70/+19
use String.prototype.repeat() to simplify code, less code, more semantically. PR-URL: https://github.com/nodejs/node/pull/5359 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-30lib: reduce usage of `self = this`Jackson Tian6-42/+33
Remove unnecessary `self = this`. PR-URL: https://github.com/nodejs/node/pull/5231 Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-30net: remove unused `var self = this` from old codeBenjamin Gruenbaum1-2/+1
Removed an unused `var self = this` that is no longer required. PR-URL: https://github.com/nodejs/node/pull/5224 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2016-03-30test: remove timer from test-http-1.0Santiago Gimeno1-11/+2
It's possible that the `end` event is emitted after the timeout fires causing the test to fail. Just remove the timer. If for some reason the `end` would never fire, the test will fail with a timeout. PR-URL: https://github.com/nodejs/node/pull/5129 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2016-03-30lib: copy arguments object instead of leaking itNathan Woltman5-14/+43
Instead of leaking the arguments object by passing it as an argument to a function, copy it's contents to a new array, then pass the array. This allows V8 to optimize the function that contains this code, improving performance. PR-URL: https://github.com/nodejs/node/pull/4361 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-03-30doc: reformat & improve node.1 manual pageJeremiah Senkpiel2-739/+105
Uses better troff formatting. Removes v8 options from the man page. Also edits `node -h` in node.cc slightly. PR-URL: #5497 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2016-03-30doc: updated fs #5862 removed irrelevant data in fs.markdowntopal1-15/+3
fs.readFile, fs.writeFile and fs.appendFile doc changes pulled back from master included details not relevant to v4. PR-URL: https://github.com/nodejs/node/pull/5877 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-22Working on v4.4.2Myles Borins1-2/+2
PR-URL: https://github.com/nodejs/node/pull/5835
2016-03-222016-03-22, Version v4.4.1 'Argon' (LTS)v4.4.1Myles Borins2-1/+136
This LTS release comes with 113 commits, 56 of which are doc related, 18 of which are build / tooling related, 16 of which are test related and 7 which are benchmark related. Notable Changes: * build: - Updated Logos for the OSX + Windows installers - (Rod Vagg) https://github.com/nodejs/node/pull/5401 - (Robert Jefe Lindstaedt) https://github.com/nodejs/node/pull/5531 - New option to select your VS Version in the Windows installer - (julien.waechter) https://github.com/nodejs/node/pull/4645 - Support Visual C++ Build Tools 2015 - (João Reis) https://github.com/nodejs/node/pull/5627 * tools: - Gyp now works on OSX without XCode - (Shigeki Ohtsu) https://github.com/nodejs/node/pull/1325
2016-03-21doc: fix typo in synchronous randomBytes exampleAndrea Giammarchi1-1/+1
The string template was closed after `${buf.length}` causing a syntax error within the example. PR-URL: https://github.com/nodejs/node/pull/5781 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21deps: update openssl configShigeki Ohtsu18-4/+204
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
2016-03-21build: don't install github templatesJohan Bergström1-0/+1
Avoid putting github templates in the source tarballs. PR-URL: https://github.com/nodejs/node/pull/5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
2016-03-21doc: topic blocking vs non-blockingJarrett Widman1-0/+143
The need for an overview of blocking vs non-blocking was identified in the docs WG Q1 roadmap. As there are several topics also pending creation, this one tries to hit the correct level of detail based on completion of the others. One which is referenced is https://github.com/nodejs/node/pull/4936/files and URLs within this PR need to change based on where that will land on the node website. PR-URL: https://github.com/nodejs/node/pull/5326 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2016-03-21test: eval a strict functionKári Tristan Helgason1-0/+28
PR-URL: https://github.com/nodejs/node/pull/5250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2016-03-21tools: fix gyp to work on MacOSX without XCodeShigeki Ohtsu1-0/+2
This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2016-03-21tools: update gyp to b3cef02Imran Iqbal13-44/+103
Includes two patches for AIX. Adds support for both 32-bit and 64-bit files[0] and uses -RPf for cp instead of -af (which is unsupported)[1] [0] https://codereview.chromium.org/1319663007 [1] https://codereview.chromium.org/1368133002 PR-URL: https://github.com/nodejs/node/pull/3487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
2016-03-21test: bug repro for vm function redefinitioncjihrig1-0/+11
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: https://github.com/nodejs/node/issues/548 Backport-URL: https://github.com/nodejs/node/pull/5785 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2016-03-21tools: support testing known issuescjihrig4-2/+17
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: https://github.com/nodejs/testing/issues/18 Backport-URL: https://github.com/nodejs/node/pull/5785 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: tools/test.py
2016-03-21tools: enable linting for benchmarksRich Trott2-3/+3
PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21benchmark: fix linting issuesRich Trott5-5/+7
PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21benchmark: use strict modeRich Trott78-12/+86
Apply strict mode to benchmark code. PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21benchmark: refactor to eliminate redeclared varsRich Trott10-42/+59
In order to comply with linting rules used in the rest of the code base, eliminate redeclared variables. A conservative approach is used so as to avoid unintentional performance issues (for example, as might be seen in some situations when using `let` instead of `var`). PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21tools,benchmark: increase lint complianceRich Trott45-153/+118
In the hopes of soon having the benchmark code linted, this change groups all the likely non-controversial lint-compliance changes such as indentation, semi-colon usage, and single-vs.-double quotation marks. Other lint rules may have subtle performance implications in the V8 currently shipped with Node.js. Those changes will require more careful review and will be in a separate change. PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21benchmark: fix lint errorsRich Trott14-24/+58
PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-03-21doc: fix invalid path doc commentsRich Trott1-53/+44
The format of certain code comments in the `path` documentation results in the code blocks being invalid. I also find it confusing at least as formatted on the website. This change is intended to improve those comments. PR-URL: https://github.com/nodejs/node/pull/5797 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21doc: update release tweet templateJeremiah Senkpiel1-1/+1
PR-URL: https://github.com/nodejs/node/pull/5628 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21doc: fix typo in child_process docsBenjamin Gruenbaum1-1/+1
Fixes a typo in the child process docs. Fixes: https://github.com/nodejs/nodejs.org/issues/573 PR-URL: https://github.com/nodejs/node/pull/5681 Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
2016-03-21collaborator_guide: clarify commit message rulesWyatt Preul1-2/+5
Italicize the full URL being required in metadata. PR-URL: https://github.com/nodejs/node/pull/5661 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
2016-03-21doc: update fansworld-claudio username on READMEClaudio Rodriguez1-1/+1
Updating collaborator username: fansworld-claudio changed to claudiorodriguez PR-URL: https://github.com/nodejs/node/pull/5680 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2016-03-21build: update Node.js logo on OSX installerRod Vagg1-0/+0
PR-URL: https://github.com/nodejs/node/pull/5401 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: kahwee Reviewed-By: fhemberger Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2016-03-21doc: fix return value of write methodsFelix Böhm1-10/+10
Fixes: https:github.com/nodejs/node/issues/5682 PR-URL: https://github.com/nodejs/node/pull/5736 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2016-03-21doc: Add note about use of JSON.stringify()Mithun Patel2-0/+6
process.send and child.send use JSON.stringify to serialize the message. Fixes: https://github.com/nodejs/node/issues/5453 PR-URL: https://github.com/nodejs/node/pull/5723 Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21docs: fix man pages link if tok type is codeMithun Patel1-1/+1
Do not call the linkManPages if the tok type is code Fixes: https://github.com/nodejs/node/issues/5686 PR-URL: https://github.com/nodejs/node/pull/5721 Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21tls: fix assert in context._external accessorBen Noordhuis2-21/+48
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: https://github.com/nodejs/node/issues/3682 PR-URL: https://github.com/nodejs/node/pull/5521 Reviewed-By: Fedor Indutny <fedor@indutny.com>
2016-03-21doc: explain path.format() algorithmRich Trott1-1/+16
PR-URL: https://github.com/nodejs/node/pull/5688 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/2305
2016-03-21doc: clarify type of first argument in zlibKirill Fomichev1-16/+11
The current documentation for Convenience Methods specifies that the first argument can be either `string or buffer`, `string` or `raw Buffer`. This commit replaces all these instances with `Buffer or string`. PR-URL: https://github.com/nodejs/node/pull/5685 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21doc: fix typo in api/addonsDaijiro Wachi1-2/+2
PR-URL: https://github.com/nodejs/node/pull/5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-03-21doc: remove non-standard use of hyphensStefano Vozza1-10/+10
Identifies the non-idiomatic usages of the '-' character and either removes them or replaces them with colons. Fixes: https://github.com/nodejs/node/issues/5672 R-URL: https://github.com/nodejs/node/pull/5677 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
2016-03-21doc: add fansworld-claudio to collaboratorsClaudio Rodriguez1-0/+1
PR-URL: https://github.com/nodejs/node/pull/5668 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
2016-03-21doc: add thekemkid to collaboratorsGlen Keane1-0/+1
PR-URL: https://github.com/nodejs/node/pull/5667 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2016-03-21doc: add AndreasMadsen to collaboratorsAndreas Madsen1-0/+1
PR-URL: https://github.com/nodejs/node/pull/5666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
2016-03-21doc: add whitlockjc to collaboratorsJeremy Whitlock1-0/+1
PR-URL: https://github.com/nodejs/node/pull/5665 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
2016-03-21doc: add benjamingr to collaborator listBenjamin Gruenbaum1-0/+1
Add benjamingr to collaborator list. Related https://github.com/nodejs/node/issues/5064 PR-URL: https://github.com/nodejs/node/pull/5664 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-28 18:20:39 +0000