diff options
| author | Chris911 <christophe.naud.dulude@gmail.com> | 2016-01-24 15:13:18 -0500 |
|---|---|---|
| committer | Myles Borins <mborins@us.ibm.com> | 2016-03-02 14:01:11 -0800 |
| commit | 1878cd5905178b9e1eda95aecfccabab000a0471 (patch) | |
| tree | 84bb1a78ed1e6571c0fa4f3257ddfa5a18bd907a /src | |
| parent | d4f0f3fa0dfe853b1b90efad114c9448913e235b (diff) | |
| download | nodejs-1878cd5905178b9e1eda95aecfccabab000a0471.tar.gz nodejs-1878cd5905178b9e1eda95aecfccabab000a0471.tar.bz2 nodejs-1878cd5905178b9e1eda95aecfccabab000a0471.zip | |
src: remove no longer relevant comments
PR-URL: https://github.com/nodejs/node/pull/4843
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/debug-agent.cc | 1 | ||||
| -rw-r--r-- | src/debug-agent.h | 1 | ||||
| -rw-r--r-- | src/node_crypto.cc | 4 |
3 files changed, 2 insertions, 4 deletions
diff --git a/src/debug-agent.cc b/src/debug-agent.cc index 06ede7fde..93d2ce71f 100644 --- a/src/debug-agent.cc +++ b/src/debug-agent.cc @@ -285,7 +285,6 @@ void Agent::ChildSignalCb(uv_async_t* signal) { } // Waiting for client, do not send anything just yet - // TODO(indutny): move this to js-land if (a->wait_) { a->messages_.PushFront(msg); // Push message back into the ready queue. break; diff --git a/src/debug-agent.h b/src/debug-agent.h index f18683a82..0c465b8e1 100644 --- a/src/debug-agent.h +++ b/src/debug-agent.h @@ -109,7 +109,6 @@ class Agent { kRunning }; - // TODO(indutny): Verify that there are no races State state_; int port_; diff --git a/src/node_crypto.cc b/src/node_crypto.cc index f0d353f3f..c6f8fad4e 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -4975,7 +4975,7 @@ void PBKDF2(const FunctionCallbackInfo<Value>& args) { if (args[5]->IsFunction()) { obj->Set(env->ondone_string(), args[5]); - // XXX(trevnorris): This will need to go with the rest of domains. + if (env->in_domain()) obj->Set(env->domain_string(), env->domain_array()->Get(0)); uv_queue_work(env->event_loop(), @@ -5136,7 +5136,7 @@ void RandomBytes(const FunctionCallbackInfo<Value>& args) { if (args[1]->IsFunction()) { obj->Set(FIXED_ONE_BYTE_STRING(args.GetIsolate(), "ondone"), args[1]); - // XXX(trevnorris): This will need to go with the rest of domains. + if (env->in_domain()) obj->Set(env->domain_string(), env->domain_array()->Get(0)); uv_queue_work(env->event_loop(), |