diff options
author | Bert Belder <bertbelder@gmail.com> | 2012-06-12 22:37:36 +0200 |
---|---|---|
committer | Bert Belder <bertbelder@gmail.com> | 2012-06-12 23:30:56 +0200 |
commit | 10f85fadfea0fade0642861116f7df79ee281e9a (patch) | |
tree | c11fef1bb76d1367d105f2917a816c40fddd34ff /src/node.js | |
parent | b53b8b8ae7d7e1328319b04b9030a7afb97a7924 (diff) | |
download | nodejs-10f85fadfea0fade0642861116f7df79ee281e9a.tar.gz nodejs-10f85fadfea0fade0642861116f7df79ee281e9a.tar.bz2 nodejs-10f85fadfea0fade0642861116f7df79ee281e9a.zip |
Fix child_process.kill oddities
* When the process is already dead, but the `exit` signal wasn't raised
yet, the ESRCH error should be ignored.
* When an invalid signal is specified, kill() should throw.
* Like process.kill(), child_process.kill() now preserves a `0` signal
which can be used to check the liveliness of the child process.
* process.kill() and child_process.kill() will now return true if the
signal was actually delivered, and false otherwise.
* When an `exec`-ed process is automatically killed because a time or
buffer limit is exceeded, and the kill() fails, this error should be
reported through the `exec` callback.
Fixes: #3409
Diffstat (limited to 'src/node.js')
-rw-r--r-- | src/node.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/node.js b/src/node.js index ba0786d6e..4571c7757 100644 --- a/src/node.js +++ b/src/node.js @@ -430,6 +430,8 @@ if (r) { throw errnoException(errno, 'kill'); } + + return true; }; }; |