readline: fix close event of readline.Interface()

Not removing 'end' listeners for input and output on the 'close' event
resulted in an EventEmitter related memory leak.

This issue also might be reproduced at:
https://github.com/npm/npm/issues/5203

Signed-off-by: Trevor Norris <trev.norris@gmail.com>

1 files changed, 9 insertions, 5 deletions

diff --git a/lib/readline.js b/lib/readline.js
index 1fa217ccd..19ef759fb 100644
--- a/lib/readline.js
+++ b/lib/readline.js
@@ -97,6 +97,13 @@ function Interface(input, output, completer, terminal) {
     self.close();
   }
 
+  function ontermend() {
+    if (util.isString(self.line) && self.line.length > 0) {
+      self.emit('line', self.line);
+    }
+    self.close();
+  }
+
   function onkeypress(s, key) {
     self._ttyWrite(s, key);
   }
@@ -121,11 +128,7 @@ function Interface(input, output, completer, terminal) {
 
     // input usually refers to stdin
     input.on('keypress', onkeypress);
-    input.on('end', function inputEnd() {
-      if (util.isString(self.line) && self.line.length > 0)
-        self.emit('line', self.line);
-      self.close();
-    });
+    input.on('end', ontermend);
 
     // Current line
     this.line = '';
@@ -142,6 +145,7 @@ function Interface(input, output, completer, terminal) {
     output.on('resize', onresize);
     self.once('close', function() {
       input.removeListener('keypress', onkeypress);
+      input.removeListener('end', ontermend);
       output.removeListener('resize', onresize);
     });
   }