Replace slow and broken for..in loops with faster for loops over the keys.

1 files changed, 12 insertions, 6 deletions

diff --git a/lib/querystring.js b/lib/querystring.js
index 5220b53ae..83e0a0f85 100644
--- a/lib/querystring.js
+++ b/lib/querystring.js
@@ -55,9 +55,11 @@ QueryString.stringify = function (obj, sep, eq, name) {
   var s = [];
   var begin = name ? name + '[' : '';
   var end = name ? ']' : '';
-  for (var i in obj) if (obj.hasOwnProperty(i)) {
-    var n = begin + i + end;
-    s.push(QueryString.stringify(obj[i], sep, eq, n));
+  var keys = Object.keys(obj);
+  for (var i = 0, l = keys.length; i < l; i++) {
+    var key = keys[i];
+    var n = begin + key + end;
+    s.push(QueryString.stringify(obj[key], sep, eq, n));
   }
 
   stack.pop();
@@ -138,10 +140,14 @@ function mergeParams (params, addition) {
 };
 
 // Merge two *objects* together. If this is called, we've already ruled
-// out the simple cases, and need to do the for-in business.
+// out the simple cases, and need to do a loop.
 function mergeObjects (params, addition) {
-  for (var i in addition) if (i && addition.hasOwnProperty(i)) {
-    params[i] = mergeParams(params[i], addition[i]);
+  var keys = Object.keys(addition);
+  for (var i = 0, l = keys.length; i < l; i++) {
+    var key = keys[i];
+    if (key) {
+      params[key] = mergeParams(params[key], addition[key]);
+    }
   }
   return params;
 };