diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-06-04 15:25:09 +0200 |
---|---|---|
committer | Trevor Norris <trev.norris@gmail.com> | 2014-06-04 14:37:27 -0700 |
commit | 8ae32a98642fdb1cf9187c67fe0050129f6a5216 (patch) | |
tree | 60c3c07305208c6f64b289be4ed680290a667acb /benchmark | |
parent | 820aaf5b3d2728d900ba0ff8903d343840766912 (diff) | |
download | nodejs-8ae32a98642fdb1cf9187c67fe0050129f6a5216.tar.gz nodejs-8ae32a98642fdb1cf9187c67fe0050129f6a5216.tar.bz2 nodejs-8ae32a98642fdb1cf9187c67fe0050129f6a5216.zip |
bench: fix buffers/buffer-base64-encode benchmark
The test is supposed to measure the performance of the base64 encoder
so move the Buffer#write() calls out of the benchmark section.
The overhead of the calls isn't terrible (about 1-3%) but having
unrelated activity in a micro-benchmark is never a good idea.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'benchmark')
-rw-r--r-- | benchmark/buffers/buffer-base64-encode.js | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/benchmark/buffers/buffer-base64-encode.js b/benchmark/buffers/buffer-base64-encode.js index f2b8e9a48..3dcc13b6b 100644 --- a/benchmark/buffers/buffer-base64-encode.js +++ b/benchmark/buffers/buffer-base64-encode.js @@ -28,9 +28,8 @@ function main(conf) { var b = Buffer(N); var s = ''; for (var i = 0; i < 256; ++i) s += String.fromCharCode(i); - - bench.start(); for (var i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii'); + bench.start(); for (var i = 0; i < 32; ++i) b.toString('base64'); bench.end(64); } |