diff options
| author | João Reis <reis@janeasystems.com> | 2015-09-23 13:33:09 +0100 |
|---|---|---|
| committer | Rod Vagg <rod@vagg.org> | 2015-11-25 10:05:15 +1100 |
| commit | 7e4b47f38af90674317e95be38dc26051f57571a (patch) | |
| tree | 22e579e307a2d78f73182987952a9bb10e90aa5c | |
| parent | 64459c0fe80b789fb07419ef41c9563df3919f27 (diff) | |
| download | nodejs-7e4b47f38af90674317e95be38dc26051f57571a.tar.gz nodejs-7e4b47f38af90674317e95be38dc26051f57571a.tar.bz2 nodejs-7e4b47f38af90674317e95be38dc26051f57571a.zip | |
build,win: fix node.exe resource version
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.
Fixes: https://github.com/nodejs/node/issues/2963
PR-URL: https://github.com/nodejs/node/pull/3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
| -rw-r--r-- | src/res/node.rc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/res/node.rc b/src/res/node.rc index 0bdb2a0dc..bc2c58a18 100644 --- a/src/res/node.rc +++ b/src/res/node.rc @@ -53,8 +53,8 @@ BEGIN VALUE "CompanyName", "Joyent, Inc" VALUE "ProductName", "Node.js" VALUE "FileDescription", "Evented I/O for V8 JavaScript" - VALUE "FileVersion", NODE_VERSION_STRING - VALUE "ProductVersion", NODE_VERSION_STRING + VALUE "FileVersion", NODE_EXE_VERSION + VALUE "ProductVersion", NODE_EXE_VERSION VALUE "OriginalFilename", "node.exe" VALUE "InternalName", "node" VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license." |