Deprecate sendHeader() and writeHeader(), ppl should use writeHead()

1 files changed, 24 insertions, 4 deletions

diff --git a/lib/http.js b/lib/http.js
index 633bb86e9..352a05ed3 100644
--- a/lib/http.js
+++ b/lib/http.js
@@ -183,8 +183,15 @@ IncomingMessage.prototype._parseQueryString = function () {
   throw new Error("_parseQueryString is deprecated. Use require(\"querystring\") to parse query strings.\n");
 };
 
+var setBodyEncodingWarning;
+
 IncomingMessage.prototype.setBodyEncoding = function (enc) {
-  // TODO deprecation message?
+  // deprecation message
+  if (!setBodyEncodingWarning) {
+    setBodyEncodingWarning = "setBodyEncoding has been renamed to setEncoding, please update your code.";
+    sys.error(setBodyEncodingWarning);
+  }
+
   this.setEncoding(enc);
 };
 
@@ -446,9 +453,22 @@ ServerResponse.prototype.writeHead = function (statusCode) {
   this.headWritten = true;
 };
 
-// TODO eventually remove sendHeader(), writeHeader()
-ServerResponse.prototype.sendHeader = ServerResponse.prototype.writeHead;
-ServerResponse.prototype.writeHeader = ServerResponse.prototype.writeHead;
+// TODO Eventually remove
+var sendHeaderWarning, writeHeaderWarning;
+ServerResponse.prototype.sendHeader = function () {
+  if (!sendHeaderWarning) {
+    sendHeaderWarning = "sendHeader() has been renamed to writeHead()";
+    sys.error(sendHeaderWarning);
+  }
+  this.writeHead.apply(this, arguments);
+};
+ServerResponse.prototype.writeHeader = function () {
+  if (!writeHeaderWarning) {
+    writeHeaderWarning = "writeHeader() has been renamed to writeHead()";
+    sys.error(writeHeaderWarning);
+  }
+  this.writeHead.apply(this, arguments);
+};
 
 function ClientRequest (socket, method, url, headers) {
   OutgoingMessage.call(this, socket);