From a3a8c029ba77e16730b366e084444c9a393cfe92 Mon Sep 17 00:00:00 2001 From: Samuel Ortiz Date: Tue, 5 Nov 2013 00:47:25 +0100 Subject: nfctool: Fix llcp-decode potential overflow Code review done by Sebastian Krahmer . --- tools/nfctool/llcp-decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/nfctool/llcp-decode.c b/tools/nfctool/llcp-decode.c index 8704873..7f95640 100644 --- a/tools/nfctool/llcp-decode.c +++ b/tools/nfctool/llcp-decode.c @@ -268,7 +268,7 @@ static void llcp_print_params(struct sniffer_packet *packet) case LLCP_PARAM_SN: sn = g_strndup((gchar *)param + 2, param_len); llcp_add_connection_sn(packet, sn); - sprintf(param_str, "%s", sn); + snprintf(param_str, 64, "%s", sn); g_free(sn); break; @@ -279,7 +279,7 @@ static void llcp_print_params(struct sniffer_packet *packet) case LLCP_PARAM_SDREQ: tid = param[2]; sn = g_strndup((gchar *)param + 3, param_len - 1); - sprintf(param_str, "TID:%d, SN:%s", tid, sn); + snprintf(param_str, 64, "TID:%d, SN:%s", tid, sn); g_free(sn); break; -- cgit v1.2.3