summaryrefslogtreecommitdiff
path: root/multipathd
diff options
context:
space:
mode:
authorBenjamin Marzinski <bmarzins@redhat.com>2009-04-02 23:44:19 -0500
committerChristophe Varoqui <christophe.varoqui@free.fr>2009-04-03 23:26:04 +0200
commit139136bb54ac9b99c7a5910e4ea1e6cb37fd8d00 (patch)
tree9cbe20bd4b956c5d495095223981954afe1e2b48 /multipathd
parent389a178ed5b63d79a4a7f1feace690f0a739f1ac (diff)
downloadmultipath-tools-139136bb54ac9b99c7a5910e4ea1e6cb37fd8d00.tar.gz
multipath-tools-139136bb54ac9b99c7a5910e4ea1e6cb37fd8d00.tar.bz2
multipath-tools-139136bb54ac9b99c7a5910e4ea1e6cb37fd8d00.zip
Miscellaneous multipath bugfixes
This is mostly a cleanup of some bugs that recently got introduced. In ACT_RESIZE we were trying to create a read-only device before we tried to create a read/write one (I also added the ability to fail back to read-only in ACT_RELOAD). There were some printouts that I assume were for debugging, and some duplicate code. And I switched it so that dm_simplecmd_flush did flushing, and dm_simplecmd_noflush didn't. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Diffstat (limited to 'multipathd')
-rw-r--r--multipathd/cli_handlers.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c
index a72c05a..2905828 100644
--- a/multipathd/cli_handlers.c
+++ b/multipathd/cli_handlers.c
@@ -459,7 +459,6 @@ cli_resize(void *v, char **reply, int *len, void *data)
pgp = VECTOR_SLOT(mpp->pg, 0);
pp = VECTOR_SLOT(pgp->paths, 0);
- condlog(0,"%s: reading sysfs.", mapname);
if (sysfs_get_size(pp->sysdev, &size)) {
condlog(0, "%s: couldn't get size for sysfs. cannot resize",
mapname);
@@ -473,15 +472,11 @@ cli_resize(void *v, char **reply, int *len, void *data)
condlog(3, "%s old size is %llu, new size is %llu", mapname, mpp->size,
size);
- condlog(0, "%s: resize_map.", mapname);
if (resize_map(mpp, size, vecs) != 0)
return 1;
- condlog(0,"%s: dm_lib_release.", mapname);
dm_lib_release();
- condlog(0,"%s: setup multipath.", mapname);
setup_multipath(vecs, mpp);
- condlog(0,"%s: sync map state.", mapname);
sync_map_state(mpp);
return 0;
@@ -513,7 +508,7 @@ cli_suspend(void * v, char ** reply, int * len, void * data)
{
struct vectors * vecs = (struct vectors *)data;
char * param = get_keyparam(v, MAP);
- int r = dm_simplecmd_flush(DM_DEVICE_SUSPEND, param);
+ int r = dm_simplecmd_noflush(DM_DEVICE_SUSPEND, param);
condlog(2, "%s: suspend (operator)", param);
@@ -534,7 +529,7 @@ cli_resume(void * v, char ** reply, int * len, void * data)
{
struct vectors * vecs = (struct vectors *)data;
char * param = get_keyparam(v, MAP);
- int r = dm_simplecmd_flush(DM_DEVICE_RESUME, param);
+ int r = dm_simplecmd_noflush(DM_DEVICE_RESUME, param);
condlog(2, "%s: resume (operator)", param);