summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-06-02aux/trace: dump resource for samplerview and surfacesandbox/jbko/21.2.0-develMike Blumenkrantz1-0/+2
this is the most important member Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10974>
2021-06-01docs/gallium: Document the index buffer format conventionAlyssa Rosenzweig1-0/+5
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01si: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-3/+3
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01lima: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-3/+3
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01freedreno: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-3/+3
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01etnaviv: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-2/+2
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01v3d: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-3/+3
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01vc4: Use Rn_UINT instead of In_UINT for index buffersAlyssa Rosenzweig1-2/+2
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10990>
2021-06-01zink: ci updatesMike Blumenkrantz1-1/+0
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11093>
2021-06-01zink: optimize buffer rebindsMike Blumenkrantz1-64/+93
by using the bind counts, the common cases of rebinds can be immediately handled without unnecessary iteration, and following this each rebind can be evaluated to ensure that every necessary descriptor was rebound in order to catch any remaining corner cases that may not be handled in the optimized rebind path Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11093>
2021-06-01zink: unify more resource bind count tracking codeMike Blumenkrantz1-43/+76
we want to avoid updating these values when possible in order to reduce overhead, which means that if a descriptor is being replaced, it should be updated only if the replacement is not the same resource Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11093>
2021-06-01zink: unify code for updating res->bind_count valuesMike Blumenkrantz1-20/+20
Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11093>
2021-06-01zink: add a second descriptor managerMike Blumenkrantz9-17/+653
this is the "lazy" descriptor manager, which aims to perform the least amount of work calculating updates while ignoring the overhead that an update may incur: effectively the inverse of the caching manager in this initial implementation, divergence exists between the descriptor layouts of the cached manager and the lazy manager in order to avoid incurring regressions in the existing descriptor architecture; this will be reconciled in a followup MR that refactors and unifies descriptor layouts during this interim period and until such reconciliation occurs, the default descriptor manager is now the lazy manager for testing purposes as there are no changes here which can affect the existing infrastructure the caching descriptor manager can be selected with the ZINK_CACHE_DESCRIPTORS env var and will be automatically used for vulkan drivers which don't support the features required for lazy mode (templates) Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11093>
2021-06-01panfrost/ci: Report flakes on IRCAlyssa Rosenzweig1-0/+11
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11022>
2021-06-01ci: Move the flakes channels to OFTCEmma Anholt2-2/+2
Following the rest of our channels, move CI reporting over. Seems to still work fine. This affects freedreno and iris. Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11020>
2021-06-01ci: Add known-flake handling for the IRC flake reportsEmma Anholt4-104/+184
Now, flakes that aren't in the *-flakes.txt get a "NEW" in their report so I can watch for them. The bash was unwieldy and made debugging hard, so I switched to python. Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11020>
2021-06-01anv: fix availability for copying timestamp query resultsMike Blumenkrantz1-1/+1
idx here is the index of the value being written, so if it isn't used/incremented when the query result is written, the availability result will clobber it and be written to the same buffer offset Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11116>
2021-06-01panfrost: Eliminate reserve_* functionsAlyssa Rosenzweig5-92/+31
We always want to reserve _something_, so reserve what we need at batch creation time and stop trying to re-reserve in a zillion places after. This has a neglible (<128 bytes per batch) increase in memory usage for compute-only workloads, but given the amount of simplication, that's a fair tradeoff. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Elucidate thread group split fieldAlyssa Rosenzweig3-5/+9
Last unknown field in the XML :-) Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Bubble up errorsAlyssa Rosenzweig3-10/+9
Instead of punting to PAN_MESA_DEBUG=msgs, which we can now remove. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Minor changes to draw_vboAlyssa Rosenzweig1-8/+2
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Write translate_index_size betterAlyssa Rosenzweig1-9/+9
Encodings line up with Gallium except for uint32. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Dirty track stack sizesAlyssa Rosenzweig2-6/+6
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Don't allocate empty varying bufferAlyssa Rosenzweig1-3/+5
If the FS doesn't actually read any varyings, there's no point. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Dirty track constant buffersAlyssa Rosenzweig2-4/+23
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Analyze sysval dirty flagsAlyssa Rosenzweig3-0/+63
We want dirty tracking for constant buffer uploads, but which dirty flags are needed depend on what the sysvals are. So for each sysval, record a corresponding dirty flag at compile time, so at draw-time the check is easy. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Add draw parameters dirty flagsAlyssa Rosenzweig1-0/+2
Needed to track some new sysvals. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Shrink pan_draw_mode return typeAlyssa Rosenzweig1-1/+1
Let gcc emit ldrb instead of ldr for the table. Found by perf, but total waste of time >_> Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01panfrost: Update commentAlyssa Rosenzweig1-6/+1
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
2021-06-01ci/v3dv: update expected resultsJuan A. Suarez Romero1-0/+2
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11103>
2021-06-01panfrost: Fix pan_pool_ref constructionAntonio Caggiano1-2/+2
Fix designator order for `pan_pool_ref` fields by matching declaration order and avoid an error by the C++ compiler. Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11064>
2021-06-01docs: add basic documentation for venusChia-I Wu2-0/+162
It probably lacks some details but is a start at least. Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10988>
2021-06-01gitlab-ci: enable building of Vulkan tests in PiglitTapani Pälli3-13/+3
This is part of tackling a Piglit issue: https://gitlab.freedesktop.org/mesa/piglit/-/issues/53 Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10971>
2021-06-01panfrost: Use first_tiler to check if tiling is neededIcecream951-1/+1
If there is a preload job needing tiling, but no other jobs, then first_tiler will be set but not tiler_dep. Fixes faults when two depth-only (stencil is reloaded) clears are done in a row. panfrost ffa30000.gpu: Unhandled Page fault in AS1 at VA 0x0000000044870000 Reason: TODO raw fault status: 0x49002C1 decoded fault status: SLAVE FAULT exception type 0xC1: TRANSLATION_FAULT_LEVEL1 access type 0x2: READ source id 0x490 panfrost ffa30000.gpu: gpu sched timeout, js=0, config=0x3301, status=0x8, head=0x608a300, tail=0x608a300, sched_job=f5b0862d Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11104>
2021-06-01panfrost: Call abort() when aborting on faultIcecream951-1/+1
The existing exit(EIO) wasn't getting trapped by debuggers. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11104>
2021-06-01pan/decode: Flush the dump stream after decodingIcecream951-0/+1
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11104>
2021-06-01gitlab-ci: add python script to submit lava jobsGustavo Padovan4-59/+196
Covert the job submission process to a python script for more robustness and control. allowing easier manipulation of job data. As a result, it adds retry logic to deal with Infrastructure Errors in LAVA. _call_proxy() is equipped with a robust retry logic, which I have been using already in the past few weeks in stress testing to run hundreds of jobs. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11079>
2021-06-01v3d/simulator: use BFC/RFC registers to wait for bin/render to completeAlejandro Piñeiro1-6/+10
We were using the CT0CA (Control List Executor Current Address) and CT0EA (Control List Executor End Address) registers, but that would only wait for the CLE to reach the end of the list, but there could still be things in the rest of the pipeline. Even if that seems to work with the current simulator, the correct way to do that is using the BFC (Binning Mode Flush Count) and RFC (Rendering Mode Frame Count) registers instead. In fact, this would be needed with a newer simulator snapshot, in order to get the followint CTS tests working: dEQP-VK.api.copy_and_blit.core.resolve_image.whole_array_image.4_bit dEQP-VK.api.copy_and_blit.core.resolve_image.whole_array_image_one_region.4_bit dEQP-VK.api.copy_and_blit.core.resolve_image.whole_copy_before_resolving.4_bit dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail dEQP-VK.api.image_clearing.core.clear_color_image.1d.optimal.multiple_layers.r32g32_uint dEQP-VK.api.image_clearing.core.clear_color_image.1d.optimal.remaining_array_layers_twostep.r16_sint Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01v3d/simulator: use the proper register when waiting on a CSD submitAlejandro Piñeiro1-3/+9
Until now we were waiting until having a dispatch current and/or queued. But that would only wait for all shaders to have started, it won't wait for them to have finished. With this commit we wait until the NUM_COMPLETED_JOBS (that in spite of that name, it is about dispatches) field got increased. This is in general safest, and it is needed after the latest simulator update to get CTS tests like the following ones working: dEQP-VK.compute.basic.copy_ssbo_multiple_invocations dEQP-VK.compute.basic.copy_ssbo_single_invocation dEQP-VK.compute.basic.ssbo_rw_single_invocation dEQP-VK.compute.basic.ssbo_unsized_arr_single_invocation dEQP-VK.compute.basic.ubo_to_ssbo_multiple_invocations dEQP-VK.compute.basic.ubo_to_ssbo_single_invocation v2 (from Juan feedback): * Clarify JOBS vs DISPATCHES Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01v3d/simulator: wait for cache flushesAlejandro Piñeiro1-2/+24
Current code just assumes that flushes are instant, as simulator doesn't really model the caches. So right now we have just an assert that the flush has been done. But that can change on the future, so let's change the assert for a wait. Note that for the l1t case we are writing on the field TMUWCF. So I understand that then we need to wait for TMUWCF_SET, even if the previous code was using L2TFLS_SET. This also happpens on the kernel side. We need to check if this was a typo on the kernel side. v2 (from Juan feedback) * Add comment about the TMUWCF vs L2TFLS difference between this commit and the kernel. Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01v3d/simulator: add a cache flush mode enumAlejandro Piñeiro1-2/+8
Makes the write to the l2t cache control more readable (without magic numbers). Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01v3d/simulator: capture hub interruptsAlejandro Piñeiro3-26/+141
So far we were not capturing any HUB interrupt, just core. This could be a problem if any is fired, as we could enter on an infinite loop. With this commit we start to capture them. So we split v3d_isr into core and hub interrupt handling. As reference we capture the same HUB interrupts that we capture on the v3d kernel support. It is worth to note that all those are mostly untested. Now with both opengl/vulkan driver being stable we were not able to raise those interrupts. v2 (Juan feedback): * Just one V3D_VERSION >= 41 block, more readable * Assert that the core is 0 at v3d_isr_core (we don't handle multi-core right now). Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01broadcom/compiler: use proper type field for atomic operationsAlejandro Piñeiro1-6/+43
We were using the num_components to infer it, but in the end it is VEC2 for CMPXCHG and 32BIT for anything else. This doesn't affect any test with the real hw, but fixes an assert with the last version of the simulator. Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11039>
2021-06-01ci/lava: Disable CPU frequency scalingTomeu Vizoso1-0/+5
Lock CPU frequency scaling to max to speed up test execution and lower the variation of frame times from performance replay jobs. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Corentin Noël <corentin.noel@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11101>
2021-06-01Revert "ci/freedreno: Skip Portal 2 trace on a630, due to flakiness"Tomeu Vizoso1-3/+2
This reverts commit e381bc0e6711de83d393ef3cc0b6b795772c1813. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Corentin Noël <corentin.noel@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11058>
2021-06-01ac/rgp: bump the SQTT file minor version to 5Samuel Pitoiset1-1/+1
To match latest RGP spec. Captures generated by RADV still work with latest RGP (v1.10). Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11063>
2021-06-01ac/rgp: mark SQTT_FILE_CHUNK_TYPE_ISA_DATABASE as deprecatedSamuel Pitoiset1-1/+1
This is now deprecated and reserved for future uses. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11063>
2021-06-01asahi: Allocate slices for mipmappingAlyssa Rosenzweig1-11/+33
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11086>
2021-06-01asahi: Set levels in texture descriptorAlyssa Rosenzweig1-0/+4
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11086>
2021-06-01asahi: Add mipmapping state to the XMLAlyssa Rosenzweig1-0/+5
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11086>