summaryrefslogtreecommitdiff
path: root/src/vulkan
diff options
context:
space:
mode:
authorEric Engestrom <eric.engestrom@intel.com>2018-05-18 17:12:53 +0100
committerEric Engestrom <eric.engestrom@intel.com>2018-05-29 17:44:13 +0100
commite4fe2fd3bb26d52e64d98207692a4469f04fe1d5 (patch)
tree9cdc94d0f10d6660d1a976918ac1521ff7d906b7 /src/vulkan
parent51a17e7feec4f9c693a070df1a957ca8a1f3ab1e (diff)
downloadmesa-e4fe2fd3bb26d52e64d98207692a4469f04fe1d5.tar.gz
mesa-e4fe2fd3bb26d52e64d98207692a4469f04fe1d5.tar.bz2
mesa-e4fe2fd3bb26d52e64d98207692a4469f04fe1d5.zip
vulkan: don't free uninitialised memory
The modifiers array hasn't been initialised by then, much less with data that would need freeing. Move the label after the loop to fix this. Fixes: c80c08e22603 ("vulkan/wsi/x11: Add support for DRI3 v1.2") Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Diffstat (limited to 'src/vulkan')
-rw-r--r--src/vulkan/wsi/wsi_common_x11.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index 62739b99125..1bfbc7c3001 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -1421,10 +1421,10 @@ fail_init_images:
for (uint32_t j = 0; j < image; j++)
x11_image_finish(chain, pAllocator, &chain->images[j]);
-fail_register:
for (int i = 0; i < ARRAY_SIZE(modifiers); i++)
vk_free(pAllocator, modifiers[i]);
+fail_register:
xcb_unregister_for_special_event(chain->conn, chain->special_event);
wsi_swapchain_finish(&chain->base);