diff options
| author | Samuel Pitoiset <samuel.pitoiset@gmail.com> | 2019-02-25 15:28:24 +0100 |
|---|---|---|
| committer | Dylan Baker <dylan@pnwbakers.com> | 2019-02-26 10:40:58 -0800 |
| commit | b2b148eb324b69eedb10d0172eadcb905e2d2bed (patch) | |
| tree | 6e16bfc8d53cf9ef892fe76876f20b10a71fd7d9 | |
| parent | 2cb6cdc2aa43b5712ef7f95325c24341e7b7f5f3 (diff) | |
| download | mesa-b2b148eb324b69eedb10d0172eadcb905e2d2bed.tar.gz mesa-b2b148eb324b69eedb10d0172eadcb905e2d2bed.tar.bz2 mesa-b2b148eb324b69eedb10d0172eadcb905e2d2bed.zip | |
radv: fix out-of-bounds access when copying descriptors BO list
We shouldn't increment the buffer list pointers twice.
This fixes some crashes with new CTS
dEQP-VK.binding_model.descriptor_copy.*.
Cc: 18.3 19.0 <mesa-stable@lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
(cherry picked from commit 9256e0a09dfa94fecfef8e250755732ac35689ec)
| -rw-r--r-- | src/amd/vulkan/radv_descriptor_set.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index e47ae6ad67a..e6649305961 100644 --- a/src/amd/vulkan/radv_descriptor_set.c +++ b/src/amd/vulkan/radv_descriptor_set.c @@ -970,8 +970,6 @@ void radv_update_descriptor_sets( src_ptr += src_binding_layout->size / 4; dst_ptr += dst_binding_layout->size / 4; dst_buffer_list[j] = src_buffer_list[j]; - ++src_buffer_list; - ++dst_buffer_list; } } } |