summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVinson Lee <vlee@freedesktop.org>2023-12-29 00:08:24 -0800
committerEric Engestrom <eric@engestrom.ch>2024-01-10 09:27:11 +0000
commit92dcb1527499a7937a0ec6ae4b91f9223df9d5f7 (patch)
tree092785652b807e446b474c410c5d67a021fd6eca
parentb570eb60432209e2a86c95d4a1ef50c9946f9adb (diff)
downloadmesa-92dcb1527499a7937a0ec6ae4b91f9223df9d5f7.tar.gz
mesa-92dcb1527499a7937a0ec6ae4b91f9223df9d5f7.tar.bz2
mesa-92dcb1527499a7937a0ec6ae4b91f9223df9d5f7.zip
ac/rgp: Fix single-bit-bitfield-constant-conversion warning
../src/amd/common/ac_rgp.c:119:48: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] 119 | header->flags.is_semaphore_queue_timing_etw = 1; | ^ ~ Fixes: ed0c8522437 ("radv: add initial SQTT files generation support") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26839> (cherry picked from commit 568f61787a5cd1a69c799d935c364138ff415a1e)
-rw-r--r--.pick_status.json2
-rw-r--r--src/amd/common/ac_rgp.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/.pick_status.json b/.pick_status.json
index 72cbe62e2a3..cb865ab8625 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -994,7 +994,7 @@
"description": "ac/rgp: Fix single-bit-bitfield-constant-conversion warning",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": "ed0c852243719c6bac420de50a2f1061250e5b51",
"notes": null
diff --git a/src/amd/common/ac_rgp.c b/src/amd/common/ac_rgp.c
index 71c61f54975..c6a748410e3 100644
--- a/src/amd/common/ac_rgp.c
+++ b/src/amd/common/ac_rgp.c
@@ -79,9 +79,9 @@ struct sqtt_file_chunk_header {
struct sqtt_file_header_flags {
union {
struct {
- int32_t is_semaphore_queue_timing_etw : 1;
- int32_t no_queue_semaphore_timestamps : 1;
- int32_t reserved : 30;
+ uint32_t is_semaphore_queue_timing_etw : 1;
+ uint32_t no_queue_semaphore_timestamps : 1;
+ uint32_t reserved : 30;
};
uint32_t value;