Age | Commit message (Collapse) | Author | Files | Lines |
|
This reverts commit c159f4e6f19ffb32d89e4b3e094fd27a2f82b9ac.
As make check was exhibiting various added failures as a result.
|
|
When I configure/build libxslt outside of sources and then run libxslt
tests there are some false positives related to using absolute path
instead of relative.
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=685330
Missing check for NULL
|
|
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=684564
|
|
Missing error file from the distribution due to a typo
|
|
* Added missing $(srcdir)/ qualification to some "[ -s ... ]"
stderr-output reference file checks
* When printing log output for failed tests, quote the log variable, so
that diff output is formatted the way it should be (with newlines!)
and
is not all collapsed into one line
* Updated tests/REC/test-7.1.1-3.out with current output to get rid of a
spurious test failure
|
|
A prefix of 'xmlns' is actually allowed. It should simply be ignored
if a namespace is given. Without a namespace the lookup by prefix will
fail anyway.
What the spec doesn't allow is an attribute name of 'xmlns' which will
now be rejected.
|
|
For https://bugzilla.gnome.org/show_bug.cgi?id=587360
Correct handling of 'xml' and 'xmlns' namespaces in xsl:element and
xsl:attribute.
|
|
|
|
Add test cases for the EXSLT func bug
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=626855
Dates with timezones but no time components are not normalized correctly
Using xsltproc v1.1.26:
$ xsltproc --version
Using libxml 20706, libxslt 10126 and libexslt 815
xsltproc was compiled against libxml 20704, libxslt 10126 and libexslt
815
libxslt 10126 was compiled against libxml 20704
libexslt 815 was compiled against libxml 20704
Dates that have timezone offsets specified but no time components, for
example
"1970-01-01+01:00", are not normalized correctly; the timezone part is
truncated:
date:seconds("1970-01-01") = 0
date:seconds("1970-01-01+01:00") = 0 (not -3600 as expected)
Alters the conditions under which exsltDateNormalize() returns
without normalizing, and adds test cases demonstrating the new behaviour.
|
|
Second part of bug #680920.
|
|
For https://bugzilla.gnome.org/show_bug.cgi?id=569703
The libexslt implementation of str:replace fails to conform to its
specification on several counts:
a) the current version returns a string; it's supposed to
return a nodeset.
b) the current version treats the replacements as strings;
it's supposed to treat them as nodes.
c) the current version can modify replacement text; it's
supposed to only modify text from the original string.
d) the current version ignores the requirement to perform
substitutions in descending order of search string length.
Steps to reproduce:
a) the returning of a string rather than a nodeset can be seen
by simply inspecting the code.
b) the code explicity converts replacement nodes to strings;
this can be seen by inspection.
d) the failure to perform substitutions in descending order
of search string length can be seen in the lack of any
sorting in the source code.
c) the problem of modifying text not belonging to the original
string can be seen in the following stylesheet, which can
be simply applied to itself to produce output.
<xsl:stylesheet version="1.0"
extension-element-prefixes="str exsl"
xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
xmlns:exsl="http://exslt.org/common"
xmlns:str="http://exslt.org/strings"
>
<xsl:variable name="Text">
Price is $1.10
</xsl:variable>
<xsl:template match="/">
<xsl:apply-templates select="exsl:node-set($Text)/text()"/>
</xsl:template>
<xsl:template match="text()">
<xsl:variable name="Replace">
<FromXml>
<from>$</from>
<from>\</from>
</FromXml>
<ToTex>
<to>\$</to>
<to>$\backslash$</to>
</ToTex>
</xsl:variable>
<xsl:value-of
select="str:replace(.,exsl:node-set($Replace)/FromXml/from,exsl:node-set($Replace)/ToTex/to)"/>
</xsl:template>
</xsl:stylesheet>
Actual results:
The output is:
<?xml version="1.0"?>
Price is $\backslash$$1.10
Expected results:
The output should be:
<?xml version="1.0"?>
Price is \$1.10
Does this happen every time?
yes.
Other information:
str:replace specification is at:
http://www.exslt.org/str/functions/replace/str.replace.html
|
|
|
|
Hence matching behaviour of xmlSaveOption XML_SAVE_FORMAT off.
This affects only one of the regression tests
|
|
Bug #677901
|
|
The empty string should be returned, see bug #631803.
|
|
Makefile.am:
* Use $(VAR), not @VAR@, as the former is the correct form for AC_SUBST'ed
variables in Makefile.am files
* Touch these *.xml/*.syms files in the "dist-hook" target to prevent them
from being regenerated, because the "make dist" process in itself
updates the timestamps of the source files when it copies them into
$(distdir)
* Add EXTRA_LIBS (-lrt on my system) to xsltConf.sh, as this is a required
dependency when client applications link against -lxslt
(note that the definition of EXTRA_LIBS has been changed; see below)
* Removed MAKEFLAGS+=--silent bits, as this is not compatible with non-GNU
Make programs
autogen.sh:
* Add --warnings=all options to automake and autoconf invocations, to
better catch potential problems (most of which I've fixed in this patch)
configure.in:
* Replaced obsolete macros with their current equivalents; for reference,
see
http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html
(I removed AC_ISC_POSIX outright because the doc states it is no longer
useful)
* test(1) uses "=" as an operator, not "=="
* Fixed quoting on an AC_LINK_IFELSE() invocation to quell Autoconf errors
* Don't add redundant libraries to EXTRA_LIBS, because (1) this variable
already contains LibXSLT's own additional system-library deps, and is
useful in that form, and (2) the LibXML2 deps are already handled by
Libtool
* Don't delete files in srcdir, and don't create the symlink to
"Copyright" there either
(I don't understand why this is being symlinked in the first place...)
doc/Makefile.am:
* Can't use wildcards in EXTRA_DIST, because this breaks dependencies
(e.g. you can't "make EXSLT/\*.html"), and they only work properly when
building inside the source tree; these have been replaced with their
expansions. Other entries have been added here in lieu of the wildcards
in the dist-hook target, as well as opportunistic use of the $(*PAGES)
variables.
* Don't define an "all" target, because this steps on Automake's toes; use
"all-local" instead
* Define and use an "xsltproc" variable to reference an in-tree-built
version of xsltproc, instead of e.g. $(bindir)/xsltproc
NOTE: The makefile also uses $(XSLTPROC), which names an external
instance of the program found at configure time. Some instances of this
could probably be changed to $(xsltproc) to remove the dependency on an
existing installed program.
* Qualified various filenames as appropriate with $(srcdir)
* Use $(XMLLINT) consistently instead of $(bindir)/xmllint
* In the "libxslt-api.xml ..." rule, cd into $(srcdir) before invoking
apibuild.py as this script has to run in srcdir anyway
* In the "clean-local" rule, clear out some additional files to allow
"make distcheck" to pass
* Eliminated the redundant "maintainer-clean-local" rule
* Added a "distclean-local" rule to clear out the build directory in an
out-of-source build to allow "make distcheck" to pass
* Added a "check-extra-dist" target to make it easier to check that
EXTRA_DIST isn't missing anything
* Use $(MKDIR_P), not $(mkinstalldirs), as the latter name is obsolete
* Use $(VAR) instead of @VAR@
* The "dist-hook" target didn't work (if any generated files were in
builddir and not in srcdir), and is no longer needed thanks to the
comprehensive EXTRA_DIST variable
* Added an "uninstall-local" rule to allow "make distcheck" to pass
* Updated the .PHONY target list, removed non-existent targets
doc/symbols.xml:
* Needed to add this bit to make the generation scripts shut up
libexslt/Makefile.am:
* AM_CPPFLAGS should be used instead of INCLUDES, as the latter is an
obsolete name
* Moved $(LIBXML_CFLAGS) to AM_CFLAGS, to segregate CFLAGS from CPPFLAGS
(Note that $(CFLAGS) need not be added to AM_CFLAGS, because Automake
already references both in the build rules)
* Use $(VAR) instead of @VAR@
libxslt.pc.in:
* Add EXTRA_LIBS (-lrt on my system), as this is a required dependency
when client applications link against -lxslt
libxslt/Makefile.am:
* AM_CPPFLAGS should be used instead of INCLUDES, as the latter is an
obsolete name
* Moved $(LIBXML_CFLAGS) to AM_CFLAGS, to segregate CFLAGS from CPPFLAGS
* Use $(VAR) instead of @VAR@, $(MKDIR_P) instead of $(mkinstalldirs)
* Use $(MKDIR_P), not $(mkinstalldirs), as the latter name is obsolete
libxslt/xsltutils.c:
* Some systems don't know about CLOCK_MONOTONIC; older Solaris knows about
CLOCK_HIGHRES. Some systems, alas, have no usable alternative to
CLOCK_REALTIME.
python/Makefile.am:
* AM_CPPFLAGS should be used instead of INCLUDES, as the latter is an
obsolete name
* Moved $(LIBXML_CFLAGS) to AM_CFLAGS, to segregate CFLAGS from CPPFLAGS
* Because libxslt-py.c is (presumably) supposed to be generated every time
at build time, don't bundle it in the dist tarball
* Use $(VAR) instead of @VAR@
* libxsltclass.py is a generated file, so it doesn't get qualified with
$(srcdir)
* Use $(MKDIR_P) instead of (mkinstalldirs)
* Added an uninstall-local rule so that "make distcheck" passes
* Removed the $(srcdir) qualifications in the GENERATED file list, as
these files may exist in builddir
* In the gen_prog rule, qualify the script invocation with $(srcdir), and
set the SRCDIR environment variable so that the script can find the
files it needs when builddir != srcdir
* Don't define an "all" target, as this steps on Automake's toes
python/generator.py:
* Get the source directory from the SRCDIR environment variable, and use
it appropriately
python/tests/Makefile.am:
* Set CLEANFILES instead of defining a "clean" rule
* Use $(VAR) instead of @VAR@, $(MKDIR_P) instead of $(mkinstalldirs)
tests/*/Makefile.am, tests/exslt/*/Makefile.am:
* Need to clean up .memdump files for "make distcheck" to pass
* Don't define an "all" target, as this steps on Automake's toes
tests/REC/Makefile.am:
* Added two missing *.stand.out files to EXTRA_DIST
tests/XSLTMark/Makefile.am:
* Replaced the GNU-Make-specific %.out bit with a more broadly compatible
rule
(the "dummy" bit shuts up Automake)
* Use "$(xsltproc)" instead of "$(top_builddir)/xsltproc/xsltproc"
* Use a less $(MAKE)-heavy invocation in the "tests" target
* Replaced a conflicting "clean" target with CLEANFILES
* Added a dependency on $(xsltproc) to all the test targets
* Added a .PHONY target list
tests/docbook/Makefile.am:
* Ditched the "echo -n" bit, because it wasn't working as advertised
* Create output directories for out-of-source builds
* "$(basename $$i)" is a typo in a makefile
* Don't embed $(srcdir) in $out/$html/$fo/$msg/$xhtml, so that we can
refer to these files in builddir or srcdir
* Add a trailing "echo" to complete the "echo -n"
* Don't output files unconditionally to srcdir (it may be read-only, for
starters)
tests/plugins/Makefile.am:
* AM_CPPFLAGS should be used instead of INCLUDES, as the latter is an
obsolete name
(Note that the "$(LIBXML_CFLAGS) $(LIBXSLT_CFLAGS)" bit that was here
can be dropped entirely, because these already appear in
xmlsoft_org_xslt_testplugin_la_CFLAGS)
* Use noinst_LTLIBRARIES inside the WITH_MODULES conditional instead of
EXTRA_LTLIBRARIES, as this is cleaner (and disallows building the plugin
if module support is disabled)
* Need to clean up *.res files for "make distcheck" to pass
* Use the abs_builddir variable conveniently provided to us by Automake
instead of a GNU Make $(shell ...) construct
xslt-config.in:
* Add EXTRA_LIBS (-lrt on my system), as this is a required dependency
when client applications link against -lxslt
xsltproc/Makefile.am:
* AM_CPPFLAGS should be used instead of INCLUDES, as the latter is an
obsolete name
* Moved $(LIBXML_CFLAGS) into AM_CFLAGS
* Use $(VAR) instead of @VAR@
* Need to clean .memdump for "make distcheck" to pass
* Added rules to build lib[e]xslt.la if needed, which allows test
makefiles to build xsltproc on the fly even if nothing else has been
built already
* Create .memdump file in the "tests" target, as it's being grepped
afterward
|
|
Pointed out by Ralf Junker <ralfjunker@gmx.de>, and added his
reproducer to the regression tests
|
|
Also adds a regression test provided by Michael Ludwig <milu71@gmx.de>
|
|
|
|
Pattern matching with predicates
|
|
and adds a test case for the problem,
also adding a .gitignore cleanup
|
|
The problem is that "@node()", "attribute::node()", "child::node()" and
"node()" are all handled in different code paths and only the latter
works.
Then, I noticed that the handling of match="child::name" is wrong. It
matches the parents of <name> elements although it should be treated
exactly like match="name". So the whole XSLT_OP_CHILD stuff is
unneeded.
I also found that xsltScanName behaves a bit strange with regard to
':' characters. It doesn't parse an XML Name like the documentation
says. It's better to use xsltScanNCName instead.
Another minor issue is that the parser currently allows invalid
expressions like match="element*" because of lines 1745-1747 in
pattern.c in trunk.
* libxslt/pattern.c: fix all those problems
* tests/REC/Makefile.am tests/REC/test-5.2-19* tests/REC/test-5.2-20*
tests/REC/test-5.2-21*: add test cases to the regression suite
|
|
* libxslt/transform.c: process encoding like other imported output
properties
* tests/docs/Makefile.am tests/docs/bug-169.xml tests/general/Makefile.am
tests/general/bug-169.*: add a specific regression test
|
|
* libxslt/xslt.c: copy the embedded stylesheet instead of cutting it
out of the source tree and make sure to copy namespaces in scope too
* tests/REC/Makefile.am tests/REC/stand-2.7-[23]*: add the 2 tests
case to the regression suite
|
|
* libxslt/imports.c: xsl:strip-space didn't work if there is a NameTest
with a namespace and a wildcard
* tests/REC/Makefile.am tests/REC/test-3.4-*: add some test to the
regression suite
|
|
* Minor cleanup of "typo" and some compilation warnings:
tests/namespaces/tst7.xsl: fixed typo detected by new libxml2 code
libxslt/keys.c, libxslt/xsltlocale.c, libexslt/date.c: trivial
changes for gcc warnings.
svn path=/trunk/; revision=1490
|
|
* libxslt/attrvt.c: added code to handle literal within an
AVT #539741.
* tests/docs/Makefile.am tests/docs/bug-168.xsl
* tests/general/Makefile.am tests/general/bug-168.* add a
test for this bug to the regression suite.
svn path=/trunk/; revision=1481
|
|
* libxslt/attrvt.c: added code to handle literal within an
AVT #539741.
* tests/docs/Makefile.am tests/docs/bug-168.xsl
* tests/general/Makefile.am tests/general/bug-168.* add a
test for this bug to the regression suite.
svn path=/trunk/; revision=1480
|
|
* libxslt/xslt.c libxslt/extensions.c libxslt/extensions.h:
fix the processing of top level elements of stylesheets which
are not in the XSLT namespace and are not an extension either
should fix #529223
* tests/docs/Makefile.am tests/docs/bug-167.xml
tests/general/Makefile.am tests/general/bug-167.*: add the
test to the regression suite
Daniel
svn path=/trunk/; revision=1472
|
|
* libxslt/documents.c libxslt/keys.c libxslt/xsltInternals.h
libxslt/transform.c libxslt/pattern.c: fix the key initialization
problem introduced when tracking Josef Urban problem from 22 Dec
2007, this should also handle the problem of recursive keys
definitions should fix #531873.
* tests/docs/bug-166.xml tests/docs/Makefile.am
tests/general/Makefile.am tests/general/bug-166.xsl
tests/general/bug-166.out: add the regression tests when a key
computation depends on another one.
Daniel
svn path=/trunk/; revision=1471
|
|
*tests/exslt/common - deleted node-set.9 regression test,
because it relied upon an external web import.
svn path=/trunk/; revision=1456
|
|
* libexslt/date.c tests/exslt/date/datetime.1.out
tests/exslt/date/date.1.out tests/exslt/date/date.1.xml:
applied patch from Maurice van der Pot to fix EXSLT
week-in-year extenson which was not conforming to the definition.
This also changes the output of the tests a bit. Should fix #452876
Daniel
svn path=/trunk/; revision=1446
|
|
* tests/general/bug-165.[xsl,out,err], tests/docs/bug-165.xml,
tests/general/Makefile.am, tests/docs/Makefile.am:
added regression test for bug #469410
svn path=/trunk/; revision=1439
|
|
* tests/exslt/common/node-set.9.[xml,xsl,out],
tests/exslt/common/Makefile.am: added test case for bug #413451
svn path=/trunk/; revision=1432
|
|
* libxslt/xsltutils.c: apply patch fron Shaun McCance to hook
xsl:message construct to the new per-xsltTransformCtxt error
callback if set up.
* Makefile.am: do not package svn files in releases
Daniel
svn path=/trunk/; revision=1424
|
|
* configure.in: fixed problem with DV/WMB testing env.
* regenerated docs; doc/APIchunk1[012].html added to SVN
* libxslt/extensions.c: fixed problem with plugin loading;
removed testplugin.c from SVN (current version kept as
tests/plugin/testplugin.c)
svn path=/trunk/; revision=1415
|
|
* libexslt/strings.c: added new function replace from Joel
Reed.
* tests/exslt/Makefile.am, replace.1.xml, replace.1.xsl,
replace.1.out: added new test case for above.
* libxslt.spec.in: trivial change from Gnome to GNOME
* configure.in: trivial change for flags on my compilations
* libxslt/documents.c, libxslt/documents.h, libxslt/keys.c,
libxslt/keys.h, libxslt/variables.c, libxslt/templates.c,
libxslt/transform.c, libxslt/variables.c, libxslt/xslt.c,
libxslt/xsltutils.c: fixed some documentation/comments and
compilation warnings - no change to logic.
* re-generated the documentation.
svn path=/trunk/; revision=1413
|
|
|
|
|
|
* libexslt/functions.c: further enhancement to the original
fix for bug #381319 (which was not correct).
* tests/exslt/functions: minor enhancement to function.9.xsl;
function.10.[xsl,xml,out] added to regression tests to check
recursive calls.
|
|
* libexslt/functions.c: changed handling of function params
to fix bug #381319
* libxslt/transform.[ch]: exposed xsltLocalVariablePush and
xsltLocalVariablePop as global entries so that they could
be used from within libexslt/functions.c
* tests/exslt/functions/function.9.[xsl,xml,out] added to
regression tests
|
|
* libxslt/transform.c: fixed problem with entity handling
within xsltCopyAttrListNoOverwrite (#352907)
* tests/general/bug-164.xsl, tests/general/bug-164.out,
tests/docs/bug-164.oxml: added a regression test for this
|
|
* Updated tests affected by recent library changes -
tests/general/bug-1-.out, tests/general/bug-24-.out,
tests/keys/month.out : (<t></t> now becomes <t/>);
tests/general/bug-41-.xsl and tests/general/bug-43.xsl :
call-template and apply-template, where the template has
no parameter but one is supplied (var should not be affected)
tests/general/bug-145.err : changed error text
|
|
* tests/docs/bug-54.xml tests/general/bug-54.out
tests/general/bug-99.out tests/general/bug-136.out
tests/REC/test-7.1.3.xsl tests/REC/test-7.1.4.xsl
tests/REC/test-7.3.xsl tests/REC/test-7.4.xsl:
Fixed incorrect regression tests/results.
|
|
|
|
* tests/exslt/common/node-set.5.out
tests/exslt/sets/difference.1.out
tests/exslt/functions/function.6.out: Reverting the
changes; I'll rather change the processing stylesheet
documents in a way that they will produce the same results
for broken and stricter whitespace-stripping.
|
|
* tests/exslt/common/node-set.5.out
tests/exslt/sets/difference.1.out
tests/exslt/functions/function.6.out: Changed regression test
results (bug #340684). Those will now produce regression
errors; so we need to fix the processor.
|