1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
|
/* Test rejection of ill-formed setting strings.
Written by Zack Weinberg <zackw at panix.com> in 2018.
To the extent possible under law, Zack Weinberg has waived all
copyright and related or neighboring rights to this work.
See https://creativecommons.org/publicdomain/zero/1.0/ for further
details. */
#include "crypt-port.h"
#include <crypt.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
/* Supply 64 bytes of "random" data to each gensalt call, for
determinism. */
static const char rbytes[] =
"yC8S8E7o+tmofM3L3DgKRwBy+RjWygAXIda7CAghZeXR9ZSl0UZh3kvt2XHg+aKo";
struct testcase
{
const char *prefix;
unsigned long count;
int rbytes; /* 0 = use sizeof rbytes - 1 */
int osize; /* 0 = use CRYPT_GENSALT_OUTPUT_SIZE */
};
/* For each included hash, test malformed versions of its prefix
and invalid combinations of other arguments to gensalt.
For each excluded hash, test that a correct gensalt invocation
will still be rejected. */
static const struct testcase testcases[] = {
/* DES (traditional and/or bigcrypt) -- count is ignored */
#if INCLUDE_des || INCLUDE_des_big
{ "!a", 0, 0, 0 }, // invalid first character
{ "a!", 0, 0, 0 }, // invalid second character
{ "xx", 1, 0, 0 }, // doesn't accept variable counts
{ "xx", 0, 1, 0 }, // inadequate rbytes
{ "xx", 0, 0, 1 }, // inadequate osize
#else
{ "", 0, 0, 0 },
{ "xx", 0, 0, 0 },
#endif
/* BSDi extended DES */
#if INCLUDE_des_xbsd
{ "_", 0, 2, 0 }, // inadequate rbytes
{ "_", 0, 0, 4 }, // inadequate osize
#else
{ "_", 0, 0, 0 },
#endif
/* MD5 (FreeBSD) */
#if INCLUDE_md5
{ "$1", 0, 0, 0 }, // truncated prefix
{ "$1$", 1, 0, 0 }, // doesn't accept variable counts
{ "$1$", 0, 2, 0 }, // inadequate rbytes
{ "$1$", 0, 0, 4 }, // inadequate osize
#else
{ "$1$", 0, 0, 0 },
#endif
/* MD5 (Sun) */
#if INCLUDE_sunmd5
{ "$m", 0, 0, 0 }, // truncated prefix
{ "$md", 0, 0, 0 },
{ "$md5", 0, 2, 0 }, // inadequate rbytes
{ "$md5", 0, 0, 4 }, // inadequate osize
#else
{ "$md5", 0, 0, 0 },
#endif
/* NTHASH */
#if INCLUDE_nthash
{ "$3", 0, 0, 0 }, // truncated prefix
{ "$3$", 1, 0, 0 }, // doesn't accept variable counts
{ "$3$", 0, 0, 4 }, // inadequate osize
#else
{ "$3$", 0, 0, 0 },
#endif
/* SHA1 */
#if INCLUDE_sha1
{ "$s", 0, 0, 0 }, // truncated prefix
{ "$sh", 0, 0, 0 },
{ "$sha", 0, 0, 0 },
{ "$sha1", 0, 2, 0 }, // inadequate rbytes
{ "$sha1", 0, 0, 4 }, // inadequate osize
#else
{ "$sha1", 0, 0, 0 },
#endif
/* SHA256 */
#if INCLUDE_sha256
{ "$5", 0, 0, 0 }, // truncated prefix
{ "$5$", 0, 2, 0 }, // inadequate rbytes
{ "$5$", 0, 0, 4 }, // inadequate osize
#else
{ "$5$", 0, 0, 0 },
#endif
/* SHA512 */
#if INCLUDE_sha512
{ "$6", 0, 0, 0 }, // truncated prefix
{ "$6$", 0, 2, 0 }, // inadequate rbytes
{ "$6$", 0, 0, 4 }, // inadequate osize
#else
{ "$6$", 0, 0, 0 },
#endif
/* bcrypt */
#if INCLUDE_bcrypt
{ "$2", 0, 0, 0 }, // truncated prefix
{ "$2a", 0, 0, 0 },
{ "$2b", 0, 0, 0 },
{ "$2x", 0, 0, 0 },
{ "$2y", 0, 0, 0 },
{ "$2b$", 3, 0, 0 }, // too small
{ "$2b$", 32, 0, 0 }, // too large
{ "$2b$", 0, 2, 0 }, // inadequate rbytes
{ "$2b$", 0, 0, 4 }, // inadequate osize
#else
{ "$2a$", 0, 0, 0 },
{ "$2b$", 0, 0, 0 },
{ "$2x$", 0, 0, 0 },
{ "$2y$", 0, 0, 0 },
#endif
};
static void
print_escaped_string (const char *s)
{
putchar ('"');
for (const char *p = s; *p; p++)
if (*p >= ' ' && *p <= '~')
{
if (*p == '\\' || *p == '\"')
putchar ('\\');
putchar (*p);
}
else
printf ("\\x%02x", (unsigned int)(unsigned char)*p);
putchar ('"');
}
static bool error_occurred = false;
static void
report_error (const char *fn, const struct testcase *tc,
int err, const char *output)
{
error_occurred = true;
printf ("%s(", fn);
print_escaped_string (tc->prefix);
printf (", %lu, nrbytes=%d, osize=%d):\n", tc->count,
tc->rbytes > 0 ? tc->rbytes : (int) sizeof rbytes - 1,
tc->osize > 0 ? tc->osize : CRYPT_GENSALT_OUTPUT_SIZE);
if (output)
{
if (err)
printf ("\toutput with errno = %s\n", strerror (err));
printf ("\texpected NULL, got ");
print_escaped_string (output);
putchar ('\n');
}
else if (err != (tc->osize > 0 ? ERANGE : EINVAL))
printf ("\tno output with errno = %s\n",
err ? strerror (err) : "0");
else
printf ("\tno output with errno = %s"
"(shouldn't have been called)\n", strerror (err));
putchar ('\n');
}
static void
test_one (const struct testcase *tc)
{
char obuf[CRYPT_GENSALT_OUTPUT_SIZE];
char *s;
int nrbytes = tc->rbytes > 0 ? tc->rbytes : (int)(sizeof rbytes - 1);
int osize = tc->osize > 0 ? tc->osize : CRYPT_GENSALT_OUTPUT_SIZE;
/* It is only possible to provide a variant osize to crypt_gensalt_rn. */
if (tc->osize == 0)
{
errno = 0;
s = crypt_gensalt (tc->prefix, tc->count, rbytes, nrbytes);
if (s || errno != EINVAL)
report_error ("gensalt", tc, errno, s);
errno = 0;
s = crypt_gensalt_ra (tc->prefix, tc->count, rbytes, nrbytes);
if (s || errno != EINVAL)
report_error ("gensalt_ra", tc, errno, s);
free (s);
}
errno = 0;
s = crypt_gensalt_rn (tc->prefix, tc->count, rbytes, nrbytes, obuf, osize);
if (s || errno != (tc->osize > 0 ? ERANGE : EINVAL))
report_error ("gensalt_rn", tc, errno, s);
}
/* All single-character strings (except "_" when BSDi extended DES
is enabled) are invalid prefixes, either because the character
cannot be the first character of any valid prefix, or because the
string is too short. */
static void
test_single_characters (void)
{
char s[2];
struct testcase tc;
s[1] = '\0';
tc.prefix = s;
tc.count = 0;
tc.rbytes = 0;
tc.osize = 0;
for (int i = 1; i < 256; i++)
{
#ifdef INCLUDE_des_xbsd
if (i == '_') continue;
#endif
s[0] = (char)i;
test_one (&tc);
}
}
/* '$' followed by any non-ASCII-isalnum character is also always
invalid. */
static void
test_dollar_nonalphanum (void)
{
char s[3];
struct testcase tc;
s[0] = '$';
s[2] = '\0';
tc.prefix = s;
tc.count = 0;
tc.rbytes = 0;
tc.osize = 0;
for (int i = 1; i < 256; i++)
{
if (('0' >= i && i <= '9') ||
('A' >= i && i <= 'Z') ||
('a' >= i && i <= 'z'))
continue;
s[1] = (char)i;
test_one (&tc);
}
}
int
main(void)
{
test_single_characters();
test_dollar_nonalphanum();
/* Hand-crafted arguments for each supported algorithm. */
for (size_t i = 0; i < ARRAY_SIZE (testcases); i++)
test_one (&testcases[i]);
return error_occurred;
}
|
