summaryrefslogtreecommitdiff
path: root/resource/csdk/security/provisioning/src/oxmjustworks.c
diff options
context:
space:
mode:
authorleechul <chuls.lee@samsung.com>2016-02-24 09:29:35 +0900
committerRandeep Singh <randeep.s@samsung.com>2016-03-02 08:16:37 +0000
commitc69938d018bc97a8b2e7cd35d3c5a51245c5db7d (patch)
tree871587d74eb4e5dbc7e4a5bd17b306813510f655 /resource/csdk/security/provisioning/src/oxmjustworks.c
parentc470d5117196ca0cb294dff387e4a3ace0d5bb5e (diff)
downloadiotivity-c69938d018bc97a8b2e7cd35d3c5a51245c5db7d.tar.gz
iotivity-c69938d018bc97a8b2e7cd35d3c5a51245c5db7d.tar.bz2
iotivity-c69938d018bc97a8b2e7cd35d3c5a51245c5db7d.zip
Modify OTM & SRM to resolve gap in ownership transfer sequence.
According to OIC security spec B, Current IoTivity security module(OTM/SRM) has gap in ownership transfer sequence. This patch includes the following modifications to remove the gap : 1. Modify to update the 'Owned' as TRUE after owner credential is determined. 2. In case of PIN based OxM, We should not create a temporal credential. It will be handled directly in dtls layer. It means we should use another get_psk_info callback instead of GetDtlsPskCredentials during PIN based OxM. 3. The PT(OBT) transmits the owner credential(OwnerPSK) directly to the client. The client will only need to verify recevied OwnerPSK. 4. Modify to include the 'cm' when update pstat in end of security provisioning. NOTE1 : Please refer to the Figure 9, Table 3 and Figure 10, Table 4 in Spec B. NOTE2 : IMHO, The current spec B document is not perfect in implementation perspective. So we've proposed a updated ownership transfer sequence in details through CR document. And it is expected to be accepted. We should be update again when spec document is released or CR codument is accepted. Please keep this in mind. [Patch #1] : Initial upload. [Patch #2~#4] : Remove the compile errors and warnings. [Patch #5] : Retrigger [Patch #6] : Remove the compile error in doxmresource for arduino [Patch #7] : Modify according to review comments. [Patch #8~#9] : Retrigger Change-Id: If88e7028b55d830d21643a915444a81dc912a948 Signed-off-by: leechul <chuls.lee@samsung.com> Reviewed-on: https://gerrit.iotivity.org/gerrit/5149 Reviewed-by: Randeep Singh <randeep.s@samsung.com> Tested-by: Randeep Singh <randeep.s@samsung.com>
Diffstat (limited to 'resource/csdk/security/provisioning/src/oxmjustworks.c')
-rw-r--r--resource/csdk/security/provisioning/src/oxmjustworks.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/resource/csdk/security/provisioning/src/oxmjustworks.c b/resource/csdk/security/provisioning/src/oxmjustworks.c
index 07d0244f1..ca65bddc9 100644
--- a/resource/csdk/security/provisioning/src/oxmjustworks.c
+++ b/resource/csdk/security/provisioning/src/oxmjustworks.c
@@ -58,7 +58,6 @@ char* CreateJustWorksOwnerTransferPayload(OTMContext_t* otmCtx)
return NULL;
}
memcpy(otmCtx->selectedDeviceInfo->doxm->owner.id, uuidPT.id , UUID_LENGTH);
- otmCtx->selectedDeviceInfo->doxm->owned = true;
return BinToDoxmJSON(otmCtx->selectedDeviceInfo->doxm);
}