summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSourav Bhuwalka <s.bhuwalka@samsung.com>2020-01-10 12:56:17 +0530
committerSudipto <sudipto.bal@samsung.com>2020-01-17 11:38:04 +0530
commit176c9ded8f1aeb60bb2e6d9966d7b4253c1cd033 (patch)
tree89b9cf77857679c8ef81562dc52b6026fe08f18e
parent4fc8805e346d3b7ec57cc7ca7aa33d599585e865 (diff)
downloadiotivity-176c9ded8f1aeb60bb2e6d9966d7b4253c1cd033.tar.gz
iotivity-176c9ded8f1aeb60bb2e6d9966d7b4253c1cd033.tar.bz2
iotivity-176c9ded8f1aeb60bb2e6d9966d7b4253c1cd033.zip
Iotivity crash on 502 Bad Gateway error
Initialising dimensions with 0 which was not done earlier In case OCRepPayloadGetPropObjectArray function fails links become NULL but since dimensions is not initailised with 0 it will have some garbage value and will enter in loop and crash will occur https://github.sec.samsung.net/RS7-IOTIVITY/IoTivity/pull/649/commits/3a10bc1df11c5c2bbf7465e3aa06a76adb4734c6 (cherry-picked from 3a10bc1df11c5c2bbf7465e3aa06a76adb4734c6) Change-Id: I9f156c9f3459ad756d3fde2759aa518d48380d54 Signed-off-by: Sudipto <sudipto.bal@samsung.com>
-rw-r--r--resource/csdk/resource-directory/src/RDClient.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/resource/csdk/resource-directory/src/RDClient.cpp b/resource/csdk/resource-directory/src/RDClient.cpp
index cc1dfc0c1..c4ac211ae 100644
--- a/resource/csdk/resource-directory/src/RDClient.cpp
+++ b/resource/csdk/resource-directory/src/RDClient.cpp
@@ -82,7 +82,7 @@ OCStackApplicationResult publishResourceToRDCallback(void* ctx, OCDoHandle /*han
OCRepPayload *rdPayload = (OCRepPayload *) clientResponse->payload;
OCRepPayload **links = NULL;
- size_t dimensions[MAX_REP_ARRAY_DEPTH];
+ size_t dimensions[MAX_REP_ARRAY_DEPTH] = { 0 };
OCRepPayloadGetPropObjectArray(rdPayload, OC_RSRVD_LINKS, &links, dimensions);
for(size_t i = 0; i < dimensions[0]; i++)
{