summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authordimhotepus <dimhotepus@gmail.com>2016-04-30 11:24:12 (GMT)
committerdimhotepus <dimhotepus@gmail.com>2016-04-30 11:24:12 (GMT)
commit4544e968abe7ced002713650c02d909672a8aa4c (patch)
treed102ea1dd41d8fa2386a68ab15c2ead8c68de1dd /src
parentde6149ef8e67b064a433a8b88924fa9f606ad5d5 (diff)
downloadglog-4544e968abe7ced002713650c02d909672a8aa4c.zip
glog-4544e968abe7ced002713650c02d909672a8aa4c.tar.gz
glog-4544e968abe7ced002713650c02d909672a8aa4c.tar.bz2
Cache strlen outside of cycles (PVS-Studio)
Diffstat (limited to 'src')
-rw-r--r--src/logging_unittest.cc7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/logging_unittest.cc b/src/logging_unittest.cc
index b886222..b9b8357 100644
--- a/src/logging_unittest.cc
+++ b/src/logging_unittest.cc
@@ -768,17 +768,18 @@ static void TestOneTruncate(const char *path, int64 limit, int64 keep,
CHECK_ERR(fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0600));
const char *discardstr = "DISCARDME!", *keepstr = "KEEPME!";
+ const size_t discard_size = strlen(discardstr), keep_size = strlen(keepstr);
// Fill the file with the requested data; first discard data, then kept data
int64 written = 0;
while (written < dsize) {
- int bytes = min<int64>(dsize - written, strlen(discardstr));
+ int bytes = min<int64>(dsize - written, discard_size);
CHECK_ERR(write(fd, discardstr, bytes));
written += bytes;
}
written = 0;
while (written < ksize) {
- int bytes = min<int64>(ksize - written, strlen(keepstr));
+ int bytes = min<int64>(ksize - written, keep_size);
CHECK_ERR(write(fd, keepstr, bytes));
written += bytes;
}
@@ -800,7 +801,7 @@ static void TestOneTruncate(const char *path, int64 limit, int64 keep,
const char *p = buf;
int64 checked = 0;
while (checked < expect) {
- int bytes = min<int64>(expect - checked, strlen(keepstr));
+ int bytes = min<int64>(expect - checked, keep_size);
CHECK(!memcmp(p, keepstr, bytes));
checked += bytes;
}