From ee8cda063048305e730c92e6899cf0c523fbe483 Mon Sep 17 00:00:00 2001 From: Sung Yoon Whang Date: Sat, 9 Feb 2019 18:25:10 -0800 Subject: Move eventpipe buffer to TLS (#21817) * start ripping out eventpipe buffer to tls * can now emit events from gc threads * cleanup * more cleanup * more cleanup * tested on linux * Addressing PR comments * Move things around a bit to build in Linux * change eventpipe buffer deallocation code * more cleanup * this while loop doesnt do anything now * Fix build * fixing build * More cleanup * more pr comments * Fix unix build * more pr comments * trying to add a message to assertion that seems to be causing CIs to fail * more pr feedback * handle non-2-byte aligned string payloads inside payload buffers * some more cleanup * Fix off by one error in null index calculation * Make Get/SetThreadEventBufferList a static member of ThreadEventBufferList * make only the methods public in ThreadEventBufferList * Addressing noah's comments * fix comment and last off by 1 error --- src/vm/threads.h | 29 ----------------------------- 1 file changed, 29 deletions(-) (limited to 'src/vm/threads.h') diff --git a/src/vm/threads.h b/src/vm/threads.h index 6ec6323c28..2fa7569449 100644 --- a/src/vm/threads.h +++ b/src/vm/threads.h @@ -4902,11 +4902,6 @@ public: #ifdef FEATURE_PERFTRACING private: - // The object that contains the list write buffers used by this thread. - Volatile m_pEventPipeBufferList; - - // Whether or not the thread is currently writing an event. - Volatile m_eventWriteInProgress; // SampleProfiler thread state. This is set on suspension and cleared before restart. // True if the thread was in cooperative mode. False if it was in preemptive when the suspension started. @@ -4917,30 +4912,6 @@ private: GUID m_activityId; public: - EventPipeBufferList* GetEventPipeBufferList() - { - LIMITED_METHOD_CONTRACT; - return m_pEventPipeBufferList; - } - - void SetEventPipeBufferList(EventPipeBufferList *pList) - { - LIMITED_METHOD_CONTRACT; - m_pEventPipeBufferList = pList; - } - - bool GetEventWriteInProgress() const - { - LIMITED_METHOD_CONTRACT; - return m_eventWriteInProgress; - } - - void SetEventWriteInProgress(bool value) - { - LIMITED_METHOD_CONTRACT; - m_eventWriteInProgress = value; - } - bool GetGCModeOnSuspension() { LIMITED_METHOD_CONTRACT; -- cgit v1.2.3