From eeef1c1379b9f49261f66093b355ac8c12e47485 Mon Sep 17 00:00:00 2001 From: Austin Wise Date: Sun, 7 Oct 2018 18:58:10 -0700 Subject: Remove some dead remoting and context static things (#20277) * Remove IsRemotingIntercepted methods that always return false. * Remove GetOptionalMembersAllocationSize parameters that are always false. * Remove references to context static. Remove references in comments and methodnames. * Remove RemotingVtsInfo. --- src/vm/method.hpp | 47 +---------------------------------------------- 1 file changed, 1 insertion(+), 46 deletions(-) (limited to 'src/vm/method.hpp') diff --git a/src/vm/method.hpp b/src/vm/method.hpp index 57561ef899..002985f4b8 100644 --- a/src/vm/method.hpp +++ b/src/vm/method.hpp @@ -285,7 +285,7 @@ public: } CONTRACTL_END - return !MayHaveNativeCode() || IsRemotingInterceptedViaPrestub() || IsVersionableWithPrecode(); + return !MayHaveNativeCode() || IsVersionableWithPrecode(); } void InterlockedUpdateFlags2(BYTE bMask, BOOL fSet); @@ -710,51 +710,6 @@ public: #endif CHECK CheckActivated(); - - //================================================================ - // REMOTING - // - // IsRemoting...: These predicates indicate how are remoting - // intercepts are implemented. - // - // Remoting intercepts are required for all invocations of methods on - // MarshalByRef classes (including virtual calls on methods - // which end up invoking a method on the MarshalByRef class). - // - // Remoting intercepts are implemented by one of the following techniques: - // (1) Non-virtual methods: inserting a stub in DoPrestub (for non-virtual calls) - // See: IsRemotingInterceptedViaPrestub - // - // (2) Virtual methods: by transparent proxy vtables, where all the entries in the vtable - // are a special hook which traps into the remoting logic - // See: IsRemotingInterceptedViaVirtualDispatch (context indicates - // if it is a virtual call) - // - // (3) Non-virtual-calls on virtual methods: - // by forcing calls to be indirect and wrapping the - // call with a stub returned by GetNonVirtualEntryPointForVirtualMethod. - // (this is used when invoking virtual methods non-virtually using 'call') - // See: IsRemotingInterceptedViaVirtualDispatch (context indicates - // if it is a virtual call) - // - // Ultimately essentially all calls go through CTPMethodTable::OnCall in - // remoting.cpp. - // - // Check if this methoddesc needs to be intercepted - // by the context code, using a stub. - // Also see IsRemotingInterceptedViaVirtualDispatch() - BOOL IsRemotingInterceptedViaPrestub(); - - // Check if is intercepted by the context code, using the virtual table - // of TransparentProxy. - // If such a function is called non-virtually, it needs to be handled specially - BOOL IsRemotingInterceptedViaVirtualDispatch(); - - BOOL MayBeRemotingIntercepted(); - - //================================================================ - // Does it represent a one way method call with no out/return parameters? - //================================================================ // FCalls. BOOL IsFCall() -- cgit v1.2.3