From 4efef62f0ead16b4f8ca2c6ccf0a77ce112f73b9 Mon Sep 17 00:00:00 2001 From: Mike McLaughlin Date: Tue, 15 Mar 2016 16:04:06 -0700 Subject: Strip symbols on release builds into separate binaries Issue #3669 Created a common cmake strip_symbols function that all the modules and programs use to strip the symbols out of the main into a separate .dbg (Linux) or .dSYM (OSX) file. Added an install_clr cmake function to encapsulate the install logic. Changed all the library module cmake install lines from a TARGETS to a FILES one. The TARGETS based install directives caused cmake to relink the binary and copy the unstripped version to the install path. Left the all programs like corerun or ildasm as TARGETS installs because on OSX FILES type installs don't get marked as executable. Need to use "get_property(strip_source_file TARGET ${targetName} PROPERTY LOCATION)" for the older versions of cmake and "set(strip_source_file $)" on newer versions (v3 or greater). --- src/scripts/genXplatLttng.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/scripts') diff --git a/src/scripts/genXplatLttng.py b/src/scripts/genXplatLttng.py index 7befa6136e..d343b122ff 100644 --- a/src/scripts/genXplatLttng.py +++ b/src/scripts/genXplatLttng.py @@ -444,7 +444,7 @@ def generateLttngFiles(etwmanifest,eventprovider_directory): add_subdirectory(tracepointprovider) # Install the static eventprovider library - install (TARGETS eventprovider DESTINATION lib) + install(TARGETS eventprovider DESTINATION lib) """) topCmake.close() @@ -481,11 +481,11 @@ def generateLttngFiles(etwmanifest,eventprovider_directory): tracepointprovider_Cmake.write(""" ) target_link_libraries(coreclrtraceptprovider - -llttng-ust + -llttng-ust ) - #Install the static coreclrtraceptprovider library - install (TARGETS coreclrtraceptprovider DESTINATION .) + # Install the static coreclrtraceptprovider library + install_clr(coreclrtraceptprovider) """) tracepointprovider_Cmake.close() -- cgit v1.2.3