summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2018-02-26Use overriden double/float GetHashCode for default struct hashcodes (#16550)Jan Kotas2-44/+56
Fixes #16545
2018-02-25Delete dead codeJan Kotas1-2/+0
2018-02-25Delete redundant (RuntimeType) castsJan Kotas2-48/+48
Replace `== (RuntimeType)typeof(` with `== typeof`. The type comparison is treated as JIT intrinsic and the extra cast makes the code for it worse.
2018-02-25Delete redundant int pcaCount intializationsJan Kotas1-28/+14
2018-02-25Fix GetCustomAttribute API for DllImportAttribute pseudo custom attributeJan Kotas1-39/+33
GetCustomAttribute for DllImportAttribute was throwing IndexOutOfRangeException. It made XUnit skip the rest of test methods after encoutering DllImport method in the test type. It is regression introduced by https://github.com/dotnet/coreclr/pull/13870 Fixes https://github.com/dotnet/corefx/issues/27426
2018-02-25Delete printing of security transparency in SOS (#16560)Jan Kotas6-39/+0
Security transparency is not relevant in .NET Core.
2018-02-25Fixed NaN's GetHashCode and Equals invariant issue. (#16551)Jan Kotas2-14/+23
Fix #6237
2018-02-25Fix path issues (#16554)Jeremy Kuhne3-7/+23
Path tests weren't running so a few issues sneaked in.
2018-02-24Return empty array if length is zero (#16529)kasper32-0/+20
* Return empty array if length is zero * Return true * Add support for portable system * Use portable span helper instead of Array.Empty * Move to end * Remove else * Return empty array if length is 0 in MemoryMarshal
2018-02-24Fix calling convention gap in DynamicILGenerator.EmitCalli (#16546)Petar Petrov1-1/+36
2018-02-24Suppress "local variable is initialized but not used" warning (#16549)Stephen Toub1-0/+2
2018-02-23Address more stacktrace print issues (#16525)Sung Yoon Whang4-8/+42
* Fix newline issue/duplicate message on Contract failures * make it work on Unix as well * cleanup * Add a newline between error/user messages and stacktrace
2018-02-23Remove StringBuffer and use ValueStringBuilder (#16512)Jeremy Kuhne6-466/+160
* Remove StringBuffer and use ValueStringBuilder * Address initial feedback * Address further feedback * Address some more feedback * Put back the temporary builder for output. * Make the temp var ref
2018-02-23JIT: don't trust field offsets in R2R for nullcheck bypass (#16492)Andy Ayers1-2/+13
When the jit is forming an field address to pass off to points unknown it will nullcheck at the point of creation, unless it can prove that the field is at offset zero. Unfortunately in R2R mode field offsets may not final and so a zero value seen when prejitting may end up being nonzero when the code is loaded and fixed up and fool the jit into omitting a null check that is potentially needed. So in R2R mode, if a field offset is going to be fixed up, always emit null checks. Fixes #16454.
2018-02-23Fix preventing memory allocation in signal handler (#16485)Jan Vorlicek1-8/+5
There was a subtle bug. When the hardware exception handler returns back to the signal handler, the exception's CONTEXT record may contain modified registers and so the changes need to be propagated back to the signal context. But the recent change #16384 was restoring the signal context from the originally grabbed context instead of the one that's pointed to by the exception, which is different. I have also added a little optimization - the contextRecord that was added is not needed, since the signalContextRecord can be used as the initial context record for the exception. So we can save the contextRecord and also copying to the signalContextRecord from it.
2018-02-23Fix build break with older VS versions (#16522)Jan Kotas1-3/+3
2018-02-22Adding a TODO-XArch to `Lowering::ContainCheckHWIntrinsic` to track ↵Tanner Gooding2-1/+7
https://github.com/dotnet/coreclr/issues/16497
2018-02-22Adding the missing function header comments to hwintrinsiccodegenxarch.cppTanner Gooding1-0/+100
2018-02-22AsReadOnlySpan -> AsSpan rename to fix build breaksJan Kotas18-66/+71
2018-02-22Rename string-slicing extension methods (dotnet/corefx#27328)Atsushi Kanamori1-1/+1
* Rename string-slicing extension methods As part of https://github.com/dotnet/corefx/issues/26894 the api folks have approved renaming AsROSpan and AsROMemory on string instances to AsSpan and AsMemory (as the "readonly" is obvious given the read-only nature of the input.) This puts the renaming in effect. Basically a big search-replace commit. * Fix OpenSSL build break * I see this is going to be a treadmill Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
2018-02-22Merge pull request #16511 from CarolEidt/FixDD541653Carol Eidt1-0/+6
Handle a restored double Interval at block boundary
2018-02-22Handle a restored double Interval at block boundaryCarol Eidt1-0/+6
During the process of freeing registers that are no longer live at the start of a new block, we may restore a 'previousInterval'. If that is a double (and the freed interval was float), we need to skip the next float.
2018-02-22Add ReadOnlySpan string-like Equals/CompareTo/IndexOf/Contains API with ↵Ahson Khan7-38/+473
globalization support (#16467) * Add ReadOnlySpan string-like Equals/CompareTo/IndexOf/Contains API with globalization support * Address PR feedback. * Fix unix implementation
2018-02-22Remove most preemptive checks from GetFullPath (#16478)Jeremy Kuhne8-309/+49
* Removing the colon block that tosses out paths that are not device path. Fixes: #26359 * Striping 2nd and 3rd args of PathHelper.Normalize * Build on Maryam's changes - Remove all path validity checks outside of - Null - Embedded null - Empty or all spaces (effectively empty) - Remove PathStartSkip helper - Use span overloads for StringBuffer usage - Clean up some comments * Address feedback * Tweak to match other AsSpan methods
2018-02-22Merge pull request #16473 from CarolEidt/FixDD541648Carol Eidt2-1/+7
LEA on rhs of block copy can't be contained
2018-02-22Add CoreLib helpers for MemoryExtensions.AsSpan/AsMemory(T[], int) (#16505)Atsushi Kanamori2-0/+44
* Add CoreLib helpers for MemoryExtensions.AsSpan/AsMemory(T[], int) (Part of https://github.com/dotnet/corefx/issues/26894) We intentionally don't have (T[], int] constructor overloads for Span and Memory. So as not to incur unnecessary argument checks, we implement this directly in CoreLib and will invoke it from CoreFx for the fast-Span version. * Expose an internal array-int constructor instead.
2018-02-22Remove relocations for MethodTable::m_pParentMethodTable for Linux ARM (#15915)gbalykov7-30/+299
2018-02-22Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (#16496)Ahson Khan1-4/+6
2018-02-21Merge pull request #16475 from briansull/vso-569605Brian Sullivan1-20/+21
Fix for assert during CSE processing
2018-02-21Remove OwnedFlagBit from TryGetOwnedMemory indexBen Adams1-2/+3
2018-02-21Fix Span Debugger Display String to correctly show the string contents (#27338)Ahson Khan4-4/+4
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
2018-02-21Adding support for the SSE3 and SSSE3 hardware intrinsicsTanner Gooding8-97/+171
2018-02-21Fix EventPipe Test Failures Under GCStress (#16494)Brian Robbins1-0/+4
* Disable inducedgc test when GCStress is enabled. * Suppress host contract violation in EventPipe::WalkManagedStackForThread.
2018-02-21Fix TryGetOwnedMemory xml docsBen Adams1-4/+16
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
2018-02-21clang formatBrian Sullivan1-2/+2
2018-02-21Codereview feedbackBrian Sullivan1-13/+17
2018-02-21Show the expected stack trace from a rethrown exception. (#16464)Alexandre Teoi4-63/+1
* Show the expected stack trace from a rethrown exception. Fix #15780 * Remove now unused methods - StackTraceArray::AppendSkipLast - StackTraceElement::PartiallyEqual - StackTraceElement::PartialAtomicUpdate
2018-02-21whitespace fixBrian Sullivan1-1/+1
2018-02-21Fix for assert during CSE processingBrian Sullivan1-10/+7
Assertion failed '!comp->gtTreeHasSideEffects(tree, GTF_PERSISTENT_SIDE_EFFECTS_IN_CSE)' Fixes VSO 569605
2018-02-21Disable tiered compilation for collectible assemblies (#16437)Koundinya Veluri1-0/+1
Disable tiered compilation for collectible assemblies - An assembly can be marked collectible with methods not marked as dynamic - The method desc and code can be deleted and a new method desc reallocated in the same location, code versioning doesn't handle this at the moment
2018-02-21LEA on rhs of block copy can't be containedCarol Eidt2-1/+7
We don't usually create an LEA on the rhs of a block copy - we check the type of the indir, and if it's struct we avoid the copy. However, in this case, the rhs was the address of a scalar field within a struct, so the indir was not TYP_STRUCT.
2018-02-21Dial back aggressive checks in Path (#16447)Jeremy Kuhne7-161/+92
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311)
2018-02-20Moved extensions.cs to shared folder in coreclr (#16459)Anirudh Agnihotry3-5/+40
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed
2018-02-20Revert TLS model change of the gCurrentThreadInfoJan Vorlicek1-1/+1
This change causes crashes due to incorrect TLS variable initialization on Alpine Linux. The initial-exec model that the variable was modified to use recently cannot be safely used in shared libraries.
2018-02-20Add TryGetOwnedMemory (#16455)Ben Adams1-0/+24
* Add TryGetOwnedMemory * Feedback * spelling
2018-02-20Merge pull request #16408 from fiigii/sse4loadCarol Eidt1-0/+1
Implement SSE4.1 LoadAlignedVector128NonTemporal
2018-02-20Prevent memory allocation in signal handler (#16384)mlabiuk3-18/+54
* Do not allocate exception for signal from non managed code If the signal occurs in not managed code we cannot use heap. We should call signal-safe functions only from signal handler. Create exception object on stack for checking source of signal. If signal is from managed code we can use memory allocation to create persistent exception on heap as copy of volatile exception on stack. If signal from unmanaged code we do nothing and call base signal handler. fix https://github.com/dotnet/coreclr/issues/16338
2018-02-20Replace ValueStringBuilder.set_Length with indexer (dotnet/corefx#27274)Jan Kotas2-17/+20
Indexer that let's you see and edit the content of the pending string is more efficient and flexible. Fixes #26643 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
2018-02-19Merge pull request #16444 from mikedn/vec2loadCarol Eidt1-1/+1
Handle TYP_SIMD8 correctly in genCodeForLclFld
2018-02-19Handle TYP_SIMD8 correctly in genCodeForLclFldMike Danes1-1/+1
When loading a TYP_SIMD8 local field movsd should be used, not movups. Unlike ins_Move_Extend, ins_Load does the right thing and it's consistent with indirs.