| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Switch source build property to DotNetBuildFromSource
|
|
exception (#17710) (#17844)
|
|
(#17842)
Add portable PDB caching to StackTrace.
This is the mscorlib side of the change.
|
|
Detect source-build via DotNetBuildFromSource instead of
DotNetBuildOffline which is set for the tarball build.
|
|
|
|
[release/2.1] Remove Alpine 3.6 builds
|
|
This prevents the IL linker from optimizing away some properties/methods
related to tasks that are used by a debugger but are not referenced
anywhere else in coreclr.
This specifically fixes async callstack frames for the xplat C# debugger.
|
|
* Fix Number.ParseNumber to not assume '\0' at the end of a span
This routine was written for parsing strings, which are implicitly null-terminated, and it doesn't factor in string length but instead uses tricks to exit loops when the next character is null. Now that the routine is also used for spans, this is very problematic, as spans need not be null terminated, and generally aren't when they represent slices, and expecting a null termination like this can result in walking off the end of valid memory.
I would like to see all of this code rewritten to use span. In the interim, though, as a short-term fix I've changed all dereferences of the current position to compare against the length of the span (or, rather, a pointer to the end), and pretend that a null terminator was found if we've hit the end.
* Address PR feedback
|
|
The alpine 3.6 builds have been replaced with the more generic
linux-musl builds so removing them.
|
|
Make intra-build containers private
|
|
Fixes #17716
|
|
(#17712) (#17714)
* Preserve pinned flag in {ReadOnly}Memory<T>.Slice
* Address PR feedback.
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
|
commit b4d701a72c20b695715371a99b48473053b63250
Author: Ahson Khan <ahkha@microsoft.com>
Date: Wed Apr 11 13:43:36 2018 -0700
Add CreateFromPinnedArray to System.Memory ref and add tests (#28992)
* Fixing bug in Memory.Pin and adding API to uapaot baseline
commit 76e01040fcfdb1c652ef1bf4e8e123c7db4e1be8
Author: Ahson Khan <ahkha@microsoft.com>
Date: Mon Apr 16 01:54:54 2018 -0700
Update xml comment for {ReadOnly}Memory.Pin method (#29137)
|
|
|
|
[release/2.1] Add linux-musl build leg
|
|
|
|
|
|
Skip container creation if not in flatcontainer mode
Container creation isn't required and would be incorrect if the ExpectedFeedUrl's account name didn't match AccountName
|
|
[Arm64] Disable SIMD in crossgen (added as part of #14633)
|
|
|
|
|
|
|
|
|
|
Byref pointers need to point within their "host" object -- thus
the alternate name "interior pointers". If the JIT creates and
reports a pointer as a "byref", but it points outside the host
object, and a GC occurs that moves the host object, the byref
pointer will not be updated. If a subsequent calculation puts
the byref "back" into the host object, it will actually be pointing
to garbage, since the host object has moved.
This occurred on ARM with array index calculations, in particular
because ARM doesn't have a single-instruction "base + scale*index + offset"
addressing mode. Thus, we were generating, for the jaggedarr_cs_do
test case, `ProcessJagged3DArray()` function:
```
// r0 = array object, r6 = computed index offset. We mark r4 as a byref.
add r4, r0, r6
// r4 - 32 is the offset of the object we care about. Then we load the array element.
// In this case, the loaded element is a gcref, so r4 becomes a gcref.
ldr r4, [r4-32]
```
We get this math because the user code uses `a[i - 10]`, which is
essentially `a + (i - 10) * 4 + 8` for element size 4. This is optimized
to `a + i * 4 - 32`. In the above code, `r6` is `i * 4`. In this case,
after the first instruction, `r4` can point beyond the array.
If a GC happens, `r4` isn't updated, and the second instruction loads garbage.
There are several fixes:
1. Change array morphing in `fgMorphArrayIndex()` to rearrange the array index
IR node creation to only create a byref pointer that is precise; don't create
"intermediate" byref pointers that don't represent the actual array element
address being computed. The tree matching code that annotates the generated tree
with field sequences needs to be updated to match the new form.
2. Change `fgMoveOpsLeft()` to prevent the left-weighted reassociation optimization
`[byref]+ (ref, [int]+ (int, int)) => [byref]+ ([byref]+ (ref, int), int)`. This
optimization creates "incorrect" byrefs that don't necessarily point within
the host object.
3. Add an additional condition to the `Fold "((x+icon1)+icon2) to (x+(icon1+icon2))"`
morph optimization to prevent merging of constant TYP_REF nodes, which now were
being recognized due to different tree shapes. This was probably always a problem,
but the particular tree shape wasn't seen before.
These fixes are all-platform. However, to reduce risk at this point, the are
enabled for ARM only, under the `FEATURE_PREVENT_BAD_BYREFS` `#ifdef`.
Fixes #17517.
There are many, many diffs.
For ARM32 ngen-based desktop asm diffs, it is a 0.30% improvement across all
framework assemblies. A lot of the diffs seem to be because we CSE the entire
array address offset expression, not just the index expression.
|
|
Apparently there is little or no need for a non-portable Windows build, so
rather than trying to figure out which version of Windows we are building
on, just ignore -PortableBuild=false. We can add a warning or refuse to
accept the switch later if necessary, but for now we need to continue
accepting it to avoid build breaks.
Fixes #14291
|
|
|
|
Fix random Segfaults on Ubuntu arm
|
|
|
|
This is a follow-up to #17501 that fixed #17398.
gc pointer reporting in fully-interruptible mode: the latter assumed that
register gc pointer liveness doesn't change across calls while #6103 introduced
codegen where it wasn't true.
doesn't change across calls.
This change inserts int3 after non-returning calls at the end of basic blocks
so that gc pointer liveness doesn't change across calls. This is additional
insurance in case any other place in the runtime is dependent on that contract.
|
|
|
|
Protect SuperPMI from crashes calling jitStartup
|
|
Fixes buggy memset implementation
Use heavily optimized platform implementation
Follows amd64 & arm precedent
|
|
JIT_Memset alignment code was definitly broken for some
unaligned cases
JIT_MemCpy likely had the same issue
Simplify implementation to reduce maintenance burden
|
|
The call to PInvokeStubWorker can do all kinds of stuff to the
VASigCookieReg in the GenericPInvokeCalli case, since x15 is just a
temporary register. Let's save it in a callee-saved register so that
when we come back after stub generation, we still have the correct value
for the VASigCookie.
|
|
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
|
|
|
When enumerating live gc registers, if we are not on the active stack frame,
we need to report callee-save gc registers that are live before the call.
The reason is that the liveness of gc registers may change across a call
to a method that does not return. In this case the instruction after the call
may be a jump target and a register that didn't have a live gc pointer before
the call may have a live gc pointer after the jump. To make sure we report the
registers that have live gc pointers before the call we subtract 1 from curOffs.
|
|
|
|
When we call jitStartup, we pass a JitHost interface that the JIT
calls to query for data. These queries look up in the recorded
MCH data, and could fail (and throw an exception) if data is
missing, which it can be for running non-matching altjit against
a collection. Protect these calls with exception handling.
|
|
Added test case JIT\HardwareIntrinsics\X86\Regression\GitHub_17435
|
|
memory store operation
Use fgMutateGcHeap to record memory write operations by HW Intrinsics
Set flags for the HW Intrinsic nodes that access Memory
Added support for HWIntrinsic nodes to OperMayThrow
Added support for GT_HWIntrinsic to GenTree::OperRequiresAsgFlag() and GenTree::OperIsImplicitIndir()
Refactored GenTreeHWIntrinsic::OperIsMemoryLoad() and GenTreeHWIntrinsic::OperIsMemoryStore()
Added GenTreeHWIntrinsic::OperIsMemoryLoadOrStore()
Deleted the static version of OperIsImplicitIndir(gtOper)
|
|
* Some cleanup for ArrayPool trimming
- fix static names
- make config switch more specific
- tweak tls free logic for logging
* Tweak the name of the config switch
|
|
* Remove MemoryManager.Length
* Feedback
* XML comment nits
|
|
LSRA: remove last uses only at use point
|
|
|
|
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
|
|
|
|
|
- fix https://github.com/dotnet/corert/issues/5093
- cmake toolchain refactoring
Signed-off-by: Petr Bred <bredpetr@gmail.com>
|
|
* Simple trim of ArrayPool buffers
Trim ArrayPool buffers on Gen2 GC if the buffer stack hasn't been emptied for awhile. If you haven't pulled all of the buffers in the past 10 seconds, let loose the top buffer on the stack and give the stack another 2 seconds of potential life. When the stack gets it's bottom bufferr returned the clock resets.
* Collect thread locals as well
* Add event
* Incorporate memory pressure into trimming.
Idea is that we normally give buckets a minute of age time unless the pressure starts to ramp up. As it ramps up we'll trim more off the stacks. If it gets really high we'll consider stale to be 10s instead of 1 min.
* Add implementation back for PinnableBufferCacheEventSource.
* Remove security attribute.
Fix GetMemoryInfo signature
* Always use Tls* for shared pools
Add environment variable switch
* Add guid to PinnableBufferCacheEventSource
* Address feedback
- move setting code to CLRConfig
- add constructor to PBCES
- trim large arrays more aggressively
- tweak names (ticks to ms, etc.)
- interlock creating the cleanup callback
- fix project file
Rent/return perf numbers are unchanged
* Remove static constructor
Inline Unsafe.SizeOf
* Fix spacing issue
* Trim all thread locals when memory pressure is high.
Move constants inline.
* Undo formatting changes
* Add back the internal call
* Put the right bits back *sigh*
* Missing the line feed
* Add event for trim polling
* Undo PinnableBufferCacheEventSource reimplementation
|
