summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-01-07Fixing ContainCheckHWIntrinsic to ensure that scalar integer operands are ↵Tanner Gooding3-26/+182
the appropriate size (#21641) * Fixing ContainCheckHWIntrinsic to ensure that scalar integer operands are the appropriate size * Adding a regression test for issue 21625 * Fixing IsContainableHWIntrinsicOp to use the containing node type (rather than the simd base type) for Scalar intrinsics * Fixing the containment check for `Sse41.Insert(V128<float>, V128<float>, byte)` * Cleaning up the isContainableHWIntrinsicOp logic in lowerxarch.cpp * Restrict containment to genActualType(baseType) * Formatting * Removing some comments and simplifying the supportsContainment checks for various HWIntrinsics that take a scalar operand * Applying formatting patch
2019-01-07Check GenerateGuidForType argument for null (#21851)Stephen Toub1-1/+13
* Check GenerateGuidForType argument for null * Also check for RuntimeType
2019-01-07Collect Windows test run logs into testReports.zip file (#21813)Bruce Forstall1-8/+26
* Collect Windows test run logs into testReports.zip file And upload these to Jenkins, so we can see how the tests ran. * Archive test Reports even if the test run fails * Need to use "call" when invoking runtest.cmd batch file
2019-01-07Fix CharSet on StringBuilder hidden null terminator test (#21853)Jeremy Koritzinsky1-2/+2
2019-01-07Actually fix issue #21484 reported by the customer. (#21850)Mike McLaughlin1-5/+13
GC heap globals like ephemeral_heap_segment and finalize_queue are null/invalid for a server GC. Add a check to skip the workstation GC memory enumeration if server. The server memory enumeration already skips if workstation GC.
2019-01-07JIT: encapsulate general checks for optimization (#21822)Andy Ayers16-107/+109
* JIT: encapsulate general checks for optimization Add methods that answer the general question of whether or not the jit is optimizing the code it produces. Use this to replace composite checks for minopts and debug codegen (the two modes where the jit is not optimizing). * inline keyword cleanup
2019-01-07Respect the instrumented code maps passed by the profiler in a rejit (#21786)David Mason1-3/+24
We currently do not respect the rejit provided instrumentation maps in DebuggerJitInfo::SetBoundaries, this change updates it to use the rejit map if one exists.
2019-01-07Improve CustomAttribute (#21832)Ben Adams2-325/+200
* Reduce local scopes in AddCustomAttributes * CustomAttribute.cs tidy up * Less struct copies
2019-01-07Remove invalid test b21296 (#21507)Jan Vorlicek2-202/+0
This test was doing in-place modification of a managed string using unsafe code which breaks string interning.
2019-01-07Publish symbol packages (#21769)Sven Boemer1-1/+5
2019-01-07Moves StackTrace to shared partition (#21757)Marek Safar4-172/+144
* Moves StackTrace to shared partition * Remove obsolete comment * StackFrame::GetFileName behaves like property, remove SecurityException * Adjust CoreRT ifdefs, fix names for consistency
2019-01-07Fix missing project error in official build (#21767)Sven Boemer3-4/+19
In response to https://github.com/dotnet/arcade/pull/1567. This uses an empty project to work around the new behavior that requires a project file even for restore operations.
2019-01-07Fix incorrect assignment of READYTORUN_HELPER_[Dbl|Flt][Rem/Round] (#21836)Tomáš Rylek2-8/+8
Turns out there's a long-standing typo in CoreCLR that reverses the helper enumeration values for DBL and FLT. This doesn't seem to be a problem in the CoreCLR repo as such because it solely uses the legacy identifiers CORINFO_HELP_DBLREM et al. We have however ported the incorrect helper enumeration values into R2RDump and ILCompiler. This change immediately fixes R2RDump as it resides in the same repo, I'll send out the ILCompiler change in a separate PR.
2019-01-06Remove CAS era security checks around resource loads (#21825)Filip Navara13-228/+53
2019-01-06Revert "Fix ilasm exec on paths with spaces (#21819)" (#21835)Jan Kotas1-2/+2
This reverts commit b188e9d354e37e512c5b95bec38f0f06efb4161e.
2019-01-06Delete redundant S.R.InteropServices.PInvokeMap and ↵Jan Kotas7-80/+23
S.R.InteropServices.PInvokeMarshal (#21831)
2019-01-05Remove redundant casts in TypeBuilder.CreateTypeNoLock (#21824)Ben Adams1-11/+11
2019-01-05Maintain left.Equals(right) order for equality for compat (#21829)Ben Adams9-27/+63
2019-01-05Update BuildTools, CoreClr, CoreFx, PgoData to preview1-03603-01, ↵dotnet-maestro-bot3-11/+11
preview-27305-02, preview.19055.1, master-20190105-0042, respectively (#21749)
2019-01-05(C#7) Use pattern matching `is` rather than `as` with null check (#21828)Ben Adams62-358/+173
* Use pattern matching `is` rather than `as` with null check
2019-01-05inline keyword cleanupAndy Ayers1-53/+50
2019-01-05Move Native Library APIs to NativeLibrary class (#21821)Swaroop Sridhar16-625/+689
Move APIs that manipulate native libraries from System.Runtime.InteropServices.Marshal class to the new System.Runtime.InteropServices.NativeLibrary class. In API review: #32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. However, recently the decision was changed such that the APIs are in a new NativeLibrary class.
2019-01-05Remove redundant unsafe contexts (#21826)Ben Adams23-88/+88
2019-01-04Fix ilasm exec on paths with spaces (#21819)Viktor Hofer1-2/+2
2019-01-04JIT: encapsulate general checks for optimizationAndy Ayers16-56/+61
Add methods that answer the general question of whether or not the jit is optimizing the code it produces. Use this to replace composite checks for minopts and debug codegen (the two modes where the jit is not optimizing).
2019-01-04Fix misspelling (#21640)Matt Galbraith1-1/+1
2019-01-04Remove stack marks from GetSatelliteAssembly. (#21812)Filip Navara3-27/+12
2019-01-04Delete unused fFullReset argument (#21814)Jan Kotas7-43/+10
2019-01-04Avoid passing stack crawl mark unnecessarily deep in the call stack. (#21783)Filip Navara4-32/+21
* Avoid passing stack crawl mark unnecessarily deep in the call stack. * Move stack crawl from TypeName::GetTypeManaged to RuntimeTypeHandle::GetTypeByName.
2019-01-04If the debugger is stopped on a garbage collection event, resuming the ↵Andrew Au1-7/+16
threads during detach should simply be setting the event (#21764)
2019-01-04Merge pull request #21806 from BruceForstall/CheckTestEnvCallBruce Forstall1-1/+8
Check result of call to TestEnv script
2019-01-04Support faster null checks (#21765)Ben Adams13-108/+171
2019-01-04JIT: don't optimize struct copies for call args in debug or minopts (#21792)Andy Ayers1-29/+48
The jit will opportunistically optimize away copies for some struct call arguments, if that argument is a "last use" for the struct (and some other conditions apply). In cases like #21544 this leads to confusing debug experiences as inputs to a call appear to be modified by the call. Also we really should not be optimizing the code this way in debug or in minopts codegen modes. So, block this optimization for debug and minopts. Closes #21544.
2019-01-04Fix Windows arm32/arm64 testing (#21809)Bruce Forstall2-44/+99
* Fix Windows arm32/arm64 testing After the conversion to runtest.py, we were not getting any JIT or GC stress mode testing: 1. The generated test env batch file didn't have a ".bat" extension, so Windows wouldn't execute it. 2. The Python generated temp file was locked, so couldn't be read. Added more logging.
2019-01-04Specify value of __RuntimeId for non-portable Linux test builds in ↵Egor Chesakov1-0/+1
build-test.sh (#21777)
2019-01-04Update dependencies from https://github.com/dotnet/arcade build 1060 (#21726)dotnet-maestro[bot]2-6/+6
This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18630.2 - Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18630.2
2019-01-04Add StringExtensions.Concat to fix Microsoft.IO.Redist assemblyStephen Toub1-0/+6
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
2019-01-04EventPipePayloadDecoder clean-up (#21716)Pent Ploompuu1-73/+32
* Remove ReadUnalignedGuid * Make EventPipePayloadDecoder unconditionally little-endian
2019-01-04Removes AppDomain dependency from TPLETWProvider (#21709)Marek Safar2-5/+5
which always returns 1, to make code sharing easier
2019-01-04Skip additional cast from common EC.Run calls (#21789)Ben Adams2-2/+13
* Skip additional cast from common EC.Run calls * Unsafe.As
2019-01-03Reflection performance tweaks & cleanup (#21737)Jan Kotas7-122/+113
- Delete internal "Unsafe" field getters/setters. They performance was very close (within 10%) of the regular getters/setters. - Made a few performance tweaks in reflection to make reflection faster overall. The regular field getters/setters are faster than what the unsafe ones used to be with this change.
2019-01-03Use ValueStringBuilder instead of StringBuilderCache in PathInternal.Windows.csStephen Toub1-2/+3
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
2019-01-03Add test for StringBuilder null terminator implementation detail (#21800)Jeremy Koritzinsky4-12/+17
* Remove some commented out code. * Add test verifying that we put a null terminator 2-past the end of the native buffer allocated for a StringBuilder.
2019-01-03Merge pull request #21803 from BruceForstall/FixTypoBruce Forstall1-1/+1
Fix batch script errors running JitOptimizationSensitive tests
2019-01-03Check result of call to TestEnv scriptBruce Forstall1-1/+8
If you give an illegal, not executable TestEnv script, then this will not fail silently.
2019-01-03Fix batch script errors running JitOptimizationSensitive testsBruce Forstall1-1/+1
Simple typo: REN instead of REM, leading to: "The syntax of the command is incorrect."
2019-01-03Use Kernel32 instead of api-ms-win-core-* in DllImports in SafeFileHandle.csEgor Chesakov1-5/+5
2019-01-03Eliminate some bounds checks in Path (#21721)Egor Bogatov1-1/+3
2019-01-03Adds portable version of EncodingTable (#21735)Marek Safar26-1048/+549
* Adds portable version of EncodingTable Most of the implementation is extracted from CoreRT * Use string comparer directly * Remove no longer used COMNlsInfo * Adds localization support * Removes FeatureCoreFxGlobalization configuration * Remove redudant encodings look up from GetEncoding * Keep Hashtable for nameToCodePage as it does not lock on read * Replace locked dictionary lookup with short switch * Include comment with msbuild task link used to generate the data file
2019-01-03Merge pull request #21619 from CarolEidt/FixDesktopSIMDCarol Eidt5-6/+42
Fix desktop SIMD failures