summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-08-02Add arm32 tp (#19098)Michelle McDaniel3-230/+298
* Add Arm32 support to throughput scripts
2018-08-01Merge pull request #19241 from BruceForstall/Revert19230Bruce Forstall4-7/+6
Revert "Build managed tests with dotnet (#19230)"
2018-08-01Revert "Build managed tests with dotnet (#19230)"Bruce Forstall4-7/+6
This reverts commit 763142a210d858289d30365dd1d4f2772e48f30d.
2018-08-01Use 16 bytes to spill SIMD12 (#19237)Carol Eidt4-4/+103
On 64-bit systems, SIMD12 locals are naturally rounded to 16 bytes, but the spill temp logic was not doing the same. Fix #19197
2018-08-01Merge pull request #19181 from BruceForstall/UpdateCommentBruce Forstall1-9/+4
Update arm64 comment for IsCallTargetInRange function
2018-08-01Allow rejit on attach (#19054)David Mason14-1691/+1856
* change profiler rejit to be enabled by default, and also change the debugger to only give up on setting a breakpoint if a method has been rejitted, rather than just whenever rejit is on * copy corprof changes to the pal version, and change rejit so it is allowable on attach * Change GetILFunctionBody/SetILFunctionBody to be allowed after attach * Also make RequestRevert allowable on attach * change lock order and switch from GC_NOTRIGGER to GC_TRIGGERS in Rejit codepath through the codeversionmanager * make GetReJITIDs callable after attach * change profiler rejit to be enabled by default, and also change the debugger to only give up on setting a breakpoint if a method has been rejitted, rather than just whenever rejit is on * copy corprof changes to the pal version, and change rejit so it is allowable on attach * Change GetILFunctionBody/SetILFunctionBody to be allowed after attach * Also make RequestRevert allowable on attach * change lock order and switch from GC_NOTRIGGER to GC_TRIGGERS in Rejit codepath through the codeversionmanager * make GetReJITIDs callable after attach * rename value to enable/disable rejit on attach, and cache values of profiler rejit and config value * Change places where the jit checks for rejit being enabled to actually check for what it wants, which is whether jump stamps are enabled * get rid of old value that was readded by merge somehow * disallow detach after setting rejit event mask, and prevent it from being set if rejit on attach is turned off * fix incorrect assert * Take the codemanager lock in SetIP
2018-08-01Provide a desktop-only implementation of RuntimeThread.CurrentOSThreadId for ↵Brian Robbins1-4/+1
Microsoft.Diagnostics.Tracing.EventSource.Redist. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
2018-08-01Build managed tests with dotnet (#19230)Chris Sienkiewicz4-6/+7
* Change managed projects to build with dotnet msbuild, rather than desktop msbuild * Build sdk tests as AnyCPU * Correct args passed through to dotnet for tests * Remove extra backslash from baseIntermediateOutputPath that was causing individual test exe builds to fail * Fix double import warning for sdk projects * Add default params from config.json to build-test dotnet invocations
2018-08-01Fix value number update in fgMorphCast. (#19226)Eugene Rozenfeld3-2/+81
removing GT_CAST nodes. It caused a problem for cases where GT_CAST operand is a constant (e.g., GT_CNS_INT). In these cases the value number shouldn't change since there is an assumption that constant nodes have known constant value numbers. The bug was found by ILGEN, I created a corresponding C# repro. Without the fix this assert fires: https://github.com/dotnet/coreclr/blob/1f28125ad1f9975fbe68dd6839908aa6e63fc43b#gitext://gotocommit/1f28125ad1f9975fbe68dd6839908aa6e63fc43b/src/jit/assertionprop.cpp#L2687 The fix is to update value numbers only when we changed the operand of GT_CAST and value number wasn't updated otherwise (e.g., in optNarrowTree). I verified no x64 diffs in jit-diff diff --pmi --tests --frameworks (with pri0 and pri1 tests).
2018-08-01Expose OSThreadId and TimeStamp on EventWrittenEventArgs (#19002)Brian Robbins18-44/+486
* Add EventWrittenEventArgs public properties OSThreadId and TimeStamp and plumb through OSThreadId. * Plumb ActivityId and RelatedActivityId to EventListener.
2018-08-01build-test - fix ilasm warnings caused by missing/incorrect extern assembly ↵Jacek Blaszczynski107-2478/+2504
declarations (#19188) * build-test - fix ildasm warnings caused by missing or incorrect extern assembly declarations white space was fixed in all files which were edited (tabs -> spaces, no white space at the end of line) * Remove unnecessary assembly declaration metadata
2018-08-01Use the identified python when building System.Private.CoreLib (#19043)Omair Majid2-1/+3
build.sh and build.cmd contain logic to identify a working version of python to use. System.Private.CoreLib ignores that and directly invokes 'python', which may not work, or even execute a different program.
2018-08-01Cross-bitness in GcInfoEncoder::Build() (#19206)Egor Chesakov2-55/+35
* Remove dead code in BitArray * Replace size_t with uint32_t in BitArray
2018-08-01Add a spec for tiered compilation (#19207)Noah Falk1-0/+95
Add a spec for tiered compilation
2018-07-31Fix build breakJan Kotas2-0/+2
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
2018-07-31Delete dead code (#19208)Jan Kotas8-1055/+47
- IsAppXDesignMode is always false - Win32Res class is never used
2018-07-31Delete FEATURE_IPCMAN (#19212)Jan Kotas32-5165/+2
2018-07-31JIT: fast path for minopts/debug codegen in lvaMarkRefs (#19103)Andy Ayers4-64/+117
For minopts and debug codegen, consider all locals to be implicitly referenced. This is set up during `lvaMarkLocalVars` and maintained after that by having `incRefCnts` set the implicit reference bit and not doing anything in `decRefCnts` for minopts / debug. Likewise suppress local var sorting, as we don't have accurate counts to go by.
2018-07-31Updating SetCpuInfo to be more accurateTanner Gooding2-99/+144
2018-07-31R2RDump - Fix and update R2RDumpTests (#19039)Amy18-889/+1212
* Fix GenericFunctions and MultipleRuntimeFunctions tests, x86 nwindInfo tests * Fix tests * Avoid using rva as index * Update expected xml * Add count as an attribute * Clean up and move rebaseline script to r2rdump test directory * Remove R2RDumpTest warnings * Use original test framework instead of netcoreapp2.0
2018-07-31Add netcoreapp dependencies (#19177)Chris Sienkiewicz3-2/+13
* Add MicrosoftNETCoreAppPackageVersion to dependencies.props - Add MicrosoftNETCoreAppPackageVersion property - Add required coresetup dependency build infos * Change test projects to use new MicrosoftNETCoreAppPackageVersion property
2018-07-31Expose the x86 HWIntrinsics via a set of class hierarchies matching the ↵Tanner Gooding31-104/+164
underlying ISA hierarchies
2018-07-30Moving the ilproj sdk to be built/published under the TargetsWindows conditionTanner Gooding1-4/+1
2018-07-30Fix HW intrinsics test projects naming and optimization levels according to ↵Jacek Blaszczynski70-128/+68
repo conventions
2018-07-30Temporarily flag a SIMD test as optimization-sensitive (#19163)Koundinya Veluri1-0/+2
The test runs in several PR-triggered jobs. It fails with minopts and once tiering is enabled it would fail in every PR. See https://github.com/dotnet/coreclr/issues/19124.
2018-07-30Change type of EnumLocaleData to struct (#19193)Jan Kotas1-1/+1
Saves allocation and makes the code smaller. It had to be class before we had ref locals.
2018-07-29Fix invalid IntPtr == null comparisons, set strict mode for Roslyn (#19191)Jacek Blaszczynski2-1/+5
Issue reported in https://github.com/dotnet/corefx/issues/31456 Solution is to compare always against IntPtr.Zero and use Roslyn stric mode for reporting warnings for IntPtr == null comparisons
2018-07-27Added version increment for TrimExcess and EnsureCapacity (#19096)Dávid Kaya2-0/+14
* Added version increment for TrimExcess and EnsureCapacity * Added old unit test to exclusion list * Excluded missing unit tests
2018-07-27build-test - fix TestWrapper CS warnings (#19180)Jacek Blaszczynski1-2/+2
2018-07-27spmi: exclude methods using a file with saved md5 hashes. (#18769)Sergey Andreenko3-5/+131
* read md5, linear search for each method. * rewrite with HANDLE * fix linux * do not waste time dumping md5 if no methods exluded
2018-07-27Merge pull request #19165 from BruceForstall/FixCodeGenBringUpTestsBuildsBruce Forstall651-919/+17883
Specify specific build flavors for CodeGenBringUpTests tests
2018-07-27Add comment explaining the return value of ToUpper/ToLower (#19176)Ahson Khan1-0/+4
2018-07-27Update arm64 comment for IsCallTargetInRange functionBruce Forstall1-9/+4
2018-07-27Lowering: Atomic ops can produce a value (#19173)Carol Eidt3-2/+79
* Lowering: Atomic ops can produce a value #18887 changed OperIsStore to include the atomic functions, but `Lowering::LowerArg()` and `Lowering::CheckCallArg()` assume that stores do not produce a value, so it doesn't correctly set the argument register (or build a `PUTARG_REG`) for the case where the result of an atomic op is passed to a call. Fix this and add additional asserts. Fix #19171
2018-07-27Updating emitInsCanOnlyWriteSSE2OrAVXReg to cover some of the newer ↵Tanner Gooding1-5/+39
instructions.
2018-07-27Merge pull request #19145 from CarolEidt/Fix19081Carol Eidt4-10/+20
Include long shifts in OperIsShiftOrRotate
2018-07-27Specify specific build flavors for CodeGenBringUpTests testsBruce Forstall651-919/+17883
Don't let them "float" based on the current build type. Update the arm/arm64 tests.lst files to use the new `_ro` versions. It is expected these files will disappear soon, so don't add all the new versions to them. Fixes #9722
2018-07-27JIT: add extra check to struct of struct of x promotion (#19156)Andy Ayers4-0/+300
Avoid promoting structs that contain struct fields that themselves wrap single simple fields, if those single simple fields are smaller than their enclosing struct. Otherwise we run the risk of losing track of the "extra" bytes in the innner struct. Addresses #19149.
2018-07-27Add CI PR-triggered Ubuntu x64 innerloop no-tiering job (#19123)Koundinya Veluri1-0/+15
2018-07-27Merge pull request #19154 from BruceForstall/FixArm64LocallocBruce Forstall8-30/+114
Fix overallocation of arm64 small constant localloc
2018-07-27Update CoreClr, CoreFx, PgoData to preview1-26727-01, preview1-26727-01, ↵dotnet-maestro-bot2-8/+8
master-20180727-0226, respectively (#19102)
2018-07-26Reference in box HW intrinsics (#19137)Jacek Blaszczynski5-14/+19
* Update BuildTools, CoreClr, CoreFx, PgoData to preview1-03025-01, preview1-26726-01, preview1-26725-04, master-20180726-0111, respectively * Reference System.Runtime.Intrinsics in box package * Disable X509Certificates tests for CoreFX update
2018-07-26Merge pull request #19144 from BruceForstall/Fix13796Bruce Forstall1-8/+8
Re-enable arm64 tests that no longer fail
2018-07-26Fixing the x86 hwintrinsics to not assert for invalid generic types.Tanner Gooding1-6/+10
2018-07-26Fix overallocation of arm64 small constant locallocBruce Forstall8-30/+114
We were dividing the number of bytes to allocate by 8 (right shift by 3) to determine the number of loops, then allocating and zeroing 16 bytes per loop. Simplify this by removing the number of `STACK_ALIGN_SHIFT` cases we have. Add a small test case that exhibits this behavior. Fixes #4571
2018-07-26Merge pull request #19153 from adityamandaleeka/fix_buildtest_helpAditya Mandaleeka1-1/+1
Fix batch syntax error in help text
2018-07-26Fix syntax error in help text.Aditya Mandaleeka1-1/+1
2018-07-26reenable corefx System.Runtime.Tests on arm32 (#19128)Sergey Andreenko1-1/+0
#17585 the issue was fixed long time ago, but this exclusion was forgotten.
2018-07-26Adding the Microsoft.NET.Sdk.IL pkgprojTanner Gooding6-0/+165
2018-07-26Include long shifts in OperIsShiftOrRotateCarol Eidt4-10/+20
The register allocator uses `OperIsShiftOrRotate` as the assertion for the method that gets the kills for the class of instructions that use RCX as the shift amount register. Expand it to include `RSH_LO` and `LSH_HI`. Fix #19081