diff options
Diffstat (limited to 'src/debug/daccess')
-rw-r--r-- | src/debug/daccess/dacdbiimpl.cpp | 15 | ||||
-rw-r--r-- | src/debug/daccess/dacimpl.h | 32 | ||||
-rw-r--r-- | src/debug/daccess/enummem.cpp | 2 | ||||
-rw-r--r-- | src/debug/daccess/nidump.cpp | 1 | ||||
-rw-r--r-- | src/debug/daccess/request.cpp | 37 |
5 files changed, 10 insertions, 77 deletions
diff --git a/src/debug/daccess/dacdbiimpl.cpp b/src/debug/daccess/dacdbiimpl.cpp index b19d4c47df..d8ed188fdf 100644 --- a/src/debug/daccess/dacdbiimpl.cpp +++ b/src/debug/daccess/dacdbiimpl.cpp @@ -3445,10 +3445,7 @@ void DacDbiInterfaceImpl::GetStackFramesFromException(VMPTR_Object vmObject, Dac AppDomain* pDomain = NULL; DomainFile* pDomainFile = NULL; - if (pBaseDomain->IsSharedDomain()) - pDomain = SystemDomain::System()->DefaultDomain(); - else - pDomain = pBaseDomain->AsAppDomain(); + pDomain = pBaseDomain->AsAppDomain(); _ASSERTE(pDomain != NULL); @@ -6805,14 +6802,8 @@ bool DacDbiInterfaceImpl::GetAppDomainForObject(CORDB_ADDRESS addr, OUT VMPTR_Ap PTR_Module module = mt->GetModule(); PTR_Assembly assembly = module->GetAssembly(); BaseDomain *baseDomain = assembly->GetDomain(); - - if (baseDomain->IsSharedDomain()) - { - pModule->SetDacTargetPtr(PTR_HOST_TO_TADDR(module)); - *pAppDomain = VMPTR_AppDomain::NullPtr(); - *pDomainFile = VMPTR_DomainFile::NullPtr(); - } - else if (baseDomain->IsAppDomain()) + + if (baseDomain->IsAppDomain()) { pAppDomain->SetDacTargetPtr(PTR_HOST_TO_TADDR(baseDomain->AsAppDomain())); pModule->SetDacTargetPtr(PTR_HOST_TO_TADDR(module)); diff --git a/src/debug/daccess/dacimpl.h b/src/debug/daccess/dacimpl.h index e05575c141..c783a43f0e 100644 --- a/src/debug/daccess/dacimpl.h +++ b/src/debug/daccess/dacimpl.h @@ -512,10 +512,6 @@ struct ProcessModIter AppDomainIterator m_domainIter; bool m_nextDomain; AppDomain::AssemblyIterator m_assemIter; - bool m_iterShared; -#ifdef FEATURE_LOADER_OPTIMIZATION - SharedDomain::SharedAssemblyIterator m_sharedIter; -#endif Assembly* m_curAssem; Assembly::ModuleIterator m_modIter; @@ -524,25 +520,23 @@ struct ProcessModIter { SUPPORTS_DAC; m_nextDomain = true; - m_iterShared = false; m_curAssem = NULL; } Assembly * NextAssem() { SUPPORTS_DAC; - while (!m_iterShared) + for (;;) { if (m_nextDomain) { if (!m_domainIter.Next()) { - m_iterShared = true; break; } m_nextDomain = false; - + m_assemIter = m_domainIter.GetDomain()->IterateAssembliesEx((AssemblyIterationFlags)( kIncludeLoaded | kIncludeExecution)); } @@ -553,30 +547,12 @@ struct ProcessModIter m_nextDomain = true; continue; } - + // Note: DAC doesn't need to keep the assembly alive - see code:CollectibleAssemblyHolder#CAH_DAC CollectibleAssemblyHolder<Assembly *> pAssembly = pDomainAssembly->GetLoadedAssembly(); - if (!pAssembly->IsDomainNeutral()) - { - // We've found a domain-specific assembly, so this is a unique element in the Assembly - // iteration. - return pAssembly; - } - - // Found a shared assembly, which may be duplicated - // across app domains. Ignore it now and let - // it get picked up in the shared iteration where - // it'll only occur once. - } -#ifdef FEATURE_LOADER_OPTIMIZATION - if (!m_sharedIter.Next()) - { - return NULL; + return pAssembly; } - return m_sharedIter.GetAssembly(); -#else return NULL; -#endif } Module* NextModule(void) diff --git a/src/debug/daccess/enummem.cpp b/src/debug/daccess/enummem.cpp index f6749c3c1d..7dce6e96f9 100644 --- a/src/debug/daccess/enummem.cpp +++ b/src/debug/daccess/enummem.cpp @@ -226,7 +226,6 @@ HRESULT ClrDataAccess::EnumMemCLRStatic(IN CLRDataEnumMemoryFlags flags) // then run constructor in place // ReportMem(m_globalBase + g_dacGlobals.SystemDomain__m_pSystemDomain, sizeof(SystemDomain)); - ReportMem(m_globalBase + g_dacGlobals.SharedDomain__m_pSharedDomain, sizeof(SharedDomain)); // We need IGCHeap pointer to make EEVersion work ReportMem(m_globalBase + g_dacGlobals.dac__g_pGCHeap, sizeof(IGCHeap *)); @@ -277,7 +276,6 @@ HRESULT ClrDataAccess::EnumMemCLRStatic(IN CLRDataEnumMemoryFlags flags) // then run constructor in place // CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED( SystemDomain::m_pSystemDomain.EnumMem(); ) - CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED( SharedDomain::m_pSharedDomain.EnumMem(); ) CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED( g_pDebugger.EnumMem(); ) CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED( g_pEEInterface.EnumMem(); ) if (g_pDebugInterface != nullptr) diff --git a/src/debug/daccess/nidump.cpp b/src/debug/daccess/nidump.cpp index 0cd2dfd31c..2165e3e66a 100644 --- a/src/debug/daccess/nidump.cpp +++ b/src/debug/daccess/nidump.cpp @@ -3770,7 +3770,6 @@ void NativeImageDumper::DumpModule( PTR_Module module ) { DisplayWriteFieldPointer( m_pBinder, NULL, Module, MODULE ); } - _ASSERTE(module->m_activeDependencies.GetCount() == 0); /* REVISIT_TODO Tue 10/25/2005 diff --git a/src/debug/daccess/request.cpp b/src/debug/daccess/request.cpp index fcd21fe08c..73c4517186 100644 --- a/src/debug/daccess/request.cpp +++ b/src/debug/daccess/request.cpp @@ -2281,7 +2281,7 @@ ClrDataAccess::GetAppDomainStoreData(struct DacpAppDomainStoreData *adsData) SOSDacEnter(); adsData->systemDomain = HOST_CDADDR(SystemDomain::System()); - adsData->sharedDomain = HOST_CDADDR(SharedDomain::GetDomain()); + adsData->sharedDomain = NULL; // Get an accurate count of appdomains. adsData->DomainCount = 0; @@ -2314,17 +2314,7 @@ ClrDataAccess::GetAppDomainData(CLRDATA_ADDRESS addr, struct DacpAppDomainData * appdomainData->pStubHeap = HOST_CDADDR(pLoaderAllocator->GetStubHeap()); appdomainData->appDomainStage = STAGE_OPEN; - if (pBaseDomain->IsSharedDomain()) - { - #ifdef FEATURE_LOADER_OPTIMIZATION - SharedDomain::SharedAssemblyIterator i; - while (i.Next()) - { - appdomainData->AssemblyCount++; - } - #endif // FEATURE_LOADER_OPTIMIZATION - } - else if (pBaseDomain->IsAppDomain()) + if (pBaseDomain->IsAppDomain()) { AppDomain * pAppDomain = pBaseDomain->AsAppDomain(); appdomainData->DomainLocalBlock = appdomainData->AppDomainPtr + @@ -2458,28 +2448,7 @@ ClrDataAccess::GetAssemblyList(CLRDATA_ADDRESS addr, int count, CLRDATA_ADDRESS BaseDomain* pBaseDomain = PTR_BaseDomain(TO_TADDR(addr)); int n=0; - if (pBaseDomain->IsSharedDomain()) - { -#ifdef FEATURE_LOADER_OPTIMIZATION - SharedDomain::SharedAssemblyIterator i; - if (values) - { - while (i.Next() && n < count) - values[n++] = HOST_CDADDR(i.GetAssembly()); - } - else - { - while (i.Next()) - n++; - } - - if (pNeeded) - *pNeeded = n; -#else - hr = E_UNEXPECTED; -#endif - } - else if (pBaseDomain->IsAppDomain()) + if (pBaseDomain->IsAppDomain()) { AppDomain::AssemblyIterator i = pBaseDomain->AsAppDomain()->IterateAssembliesEx( (AssemblyIterationFlags)(kIncludeLoading | kIncludeLoaded | kIncludeExecution)); |