diff options
Diffstat (limited to 'src/ToolBox/SOS/Strike')
-rw-r--r-- | src/ToolBox/SOS/Strike/disasm.h | 3 | ||||
-rw-r--r-- | src/ToolBox/SOS/Strike/gcroot.cpp | 4 | ||||
-rw-r--r-- | src/ToolBox/SOS/Strike/sos.cpp | 2 | ||||
-rw-r--r-- | src/ToolBox/SOS/Strike/sos_md.h | 2 | ||||
-rw-r--r-- | src/ToolBox/SOS/Strike/strike.cpp | 12 | ||||
-rw-r--r-- | src/ToolBox/SOS/Strike/util.cpp | 4 |
6 files changed, 7 insertions, 20 deletions
diff --git a/src/ToolBox/SOS/Strike/disasm.h b/src/ToolBox/SOS/Strike/disasm.h index 59fc168a6e..2a2d9f7779 100644 --- a/src/ToolBox/SOS/Strike/disasm.h +++ b/src/ToolBox/SOS/Strike/disasm.h @@ -54,9 +54,6 @@ LPCWSTR EHTypedClauseTypeName(const DACEHInfo* pEHInfo); struct SOSEHInfo { -#ifndef FEATURE_CORECLR - __field_ecount(EHCount) -#endif DACEHInfo *m_pInfos; UINT EHCount; CLRDATA_ADDRESS methodStart; diff --git a/src/ToolBox/SOS/Strike/gcroot.cpp b/src/ToolBox/SOS/Strike/gcroot.cpp index f68b935e21..86080989ec 100644 --- a/src/ToolBox/SOS/Strike/gcroot.cpp +++ b/src/ToolBox/SOS/Strike/gcroot.cpp @@ -40,18 +40,14 @@ #include "safemath.h" -#ifdef _ASSERTE #undef _ASSERTE -#endif -#ifndef _ASSERTE #ifdef _DEBUG #define _ASSERTE(expr) \ do { if (!(expr) ) { ExtErr("_ASSERTE fired:\n\t%s\n", #expr); if (IsDebuggerPresent()) DebugBreak(); } } while (0) #else #define _ASSERTE(x) #endif -#endif // ASSERTE inline size_t ALIGN_DOWN( size_t val, size_t alignment ) { diff --git a/src/ToolBox/SOS/Strike/sos.cpp b/src/ToolBox/SOS/Strike/sos.cpp index 351199c058..64ee4b9a0c 100644 --- a/src/ToolBox/SOS/Strike/sos.cpp +++ b/src/ToolBox/SOS/Strike/sos.cpp @@ -17,9 +17,7 @@ #include "gcdesc.h" -#ifdef _ASSERTE #undef _ASSERTE -#endif namespace sos { diff --git a/src/ToolBox/SOS/Strike/sos_md.h b/src/ToolBox/SOS/Strike/sos_md.h index f1a34cd706..b589109986 100644 --- a/src/ToolBox/SOS/Strike/sos_md.h +++ b/src/ToolBox/SOS/Strike/sos_md.h @@ -33,7 +33,7 @@ class CQuickBytes; * Always keep the definitions below in sync with the originals. * NOTES: * Since SOS runs in a native debugger session, since it does not use EnC, - * and in roder to minimize the amount of duplication we changed the + * and in order to minimize the amount of duplication we changed the * method definitions that deal with UTSemReadWrite* arguments to take * void* arguments instead. * Also, some of the interface methods take CQuickBytes as arguments. diff --git a/src/ToolBox/SOS/Strike/strike.cpp b/src/ToolBox/SOS/Strike/strike.cpp index 3bb3f50200..2b54b4f037 100644 --- a/src/ToolBox/SOS/Strike/strike.cpp +++ b/src/ToolBox/SOS/Strike/strike.cpp @@ -2090,11 +2090,9 @@ struct StackTraceElement UINT_PTR ip; UINT_PTR sp; DWORD_PTR pFunc; // MethodDesc -#if defined(FEATURE_EXCEPTIONDISPATCHINFO) // TRUE if this element represents the last frame of the foreign // exception stack trace. BOOL fIsLastFrameFromForeignStackTrace; -#endif // defined(FEATURE_EXCEPTIONDISPATCHINFO) }; @@ -8840,28 +8838,28 @@ void PrintInterestingGCInfo(DacpGCInterestingInfoData* dataPerHeap) { ExtOut("Interesting data points\n"); size_t* data = dataPerHeap->interestingDataPoints; - for (int i = 0; i < NUM_GC_DATA_POINTS; i++) + for (int i = 0; i < DAC_NUM_GC_DATA_POINTS; i++) { ExtOut("%20s: %d\n", str_interesting_data_points[i], data[i]); } ExtOut("\nCompacting reasons\n"); data = dataPerHeap->compactReasons; - for (int i = 0; i < MAX_COMPACT_REASONS_COUNT; i++) + for (int i = 0; i < DAC_MAX_COMPACT_REASONS_COUNT; i++) { ExtOut("[%s]%35s: %d\n", (gc_heap_compact_reason_mandatory_p[i] ? "M" : "W"), str_heap_compact_reasons[i], data[i]); } ExtOut("\nExpansion mechanisms\n"); data = dataPerHeap->expandMechanisms; - for (int i = 0; i < MAX_EXPAND_MECHANISMS_COUNT; i++) + for (int i = 0; i < DAC_MAX_EXPAND_MECHANISMS_COUNT; i++) { ExtOut("%30s: %d\n", str_heap_expand_mechanisms[i], data[i]); } ExtOut("\nOther mechanisms enabled\n"); data = dataPerHeap->bitMechanisms; - for (int i = 0; i < MAX_GC_MECHANISM_BITS_COUNT; i++) + for (int i = 0; i < DAC_MAX_GC_MECHANISM_BITS_COUNT; i++) { ExtOut("%20s: %d\n", str_bit_mechanisms[i], data[i]); } @@ -8883,7 +8881,7 @@ DECLARE_API(DumpGCData) DacpGCInterestingInfoData interestingInfo; interestingInfo.RequestGlobal(g_sos); - for (int i = 0; i < MAX_GLOBAL_GC_MECHANISMS_COUNT; i++) + for (int i = 0; i < DAC_MAX_GLOBAL_GC_MECHANISMS_COUNT; i++) { ExtOut("%-30s: %d\n", str_gc_global_mechanisms[i], interestingInfo.globalMechanisms[i]); } diff --git a/src/ToolBox/SOS/Strike/util.cpp b/src/ToolBox/SOS/Strike/util.cpp index b6336fb143..3cdebcf0f4 100644 --- a/src/ToolBox/SOS/Strike/util.cpp +++ b/src/ToolBox/SOS/Strike/util.cpp @@ -4793,10 +4793,8 @@ HRESULT InitCorDebugInterface() // Need to pick the appropriate SKU of CLR to detect #if defined(FEATURE_CORESYSTEM) GUID skuId = CLR_ID_ONECORE_CLR; -#elif defined(FEATURE_CORECLR) - GUID skuId = CLR_ID_CORECLR; #else - GUID skuId = CLR_ID_V4_DESKTOP; + GUID skuId = CLR_ID_CORECLR; #endif CLRDebuggingImpl* pDebuggingImpl = new CLRDebuggingImpl(skuId); hr = pDebuggingImpl->QueryInterface(IID_ICLRDebugging, (LPVOID *)&pClrDebugging); |