diff options
| author | Andy Ayers <andya@microsoft.com> | 2019-05-23 10:35:15 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-05-23 10:35:15 -0700 |
| commit | 9271757d2c917c5650c459a4c3fa648c2968a591 (patch) | |
| tree | 87024079fcbfbabc11da32df9bbe9c9c0979be53 /tests/src | |
| parent | 572be424ae932cdaba08585c922a9104684b408e (diff) | |
| download | coreclr-9271757d2c917c5650c459a4c3fa648c2968a591.tar.gz coreclr-9271757d2c917c5650c459a4c3fa648c2968a591.tar.bz2 coreclr-9271757d2c917c5650c459a4c3fa648c2968a591.zip | |
Add missing pin to two tests and re-enable for GC stress (#24738)
Test was evidently assuming that because an object that referred to an array
was pinned, so was the array. Failure was intermittent, GC is not guaranteed
to move objects or to render their former contents inaccessible.
Fixes #24173.
Fixes #24464.
Diffstat (limited to 'tests/src')
3 files changed, 6 insertions, 6 deletions
diff --git a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_dbgu_fld.ilproj b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_dbgu_fld.ilproj index b727f39ea3..e4cfb9f7bf 100644 --- a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_dbgu_fld.ilproj +++ b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_dbgu_fld.ilproj @@ -10,9 +10,6 @@ <OutputType>Exe</OutputType> <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> - - <!-- Test currently fails under GCStress. https://github.com/dotnet/coreclr/issues/24173 --> - <GCStressIncompatible>true</GCStressIncompatible> </PropertyGroup> <!-- Default configurations to help VS understand the configurations --> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> diff --git a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_relu_fld.ilproj b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_relu_fld.ilproj index f58d18ac0a..266aaf5246 100644 --- a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_relu_fld.ilproj +++ b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/_il_relu_fld.ilproj @@ -10,8 +10,6 @@ <OutputType>Exe</OutputType> <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> - <!-- https://github.com/dotnet/coreclr/issues/24464 --> - <GCStressIncompatible>true</GCStressIncompatible> </PropertyGroup> <!-- Default configurations to help VS understand the configurations --> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> diff --git a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/u_fld.il b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/u_fld.il index 4accb540a8..d93ee0f41b 100644 --- a/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/u_fld.il +++ b/tests/src/JIT/Methodical/ELEMENT_TYPE_IU/u_fld.il @@ -25,10 +25,15 @@ { .entrypoint .maxstack 8 - .locals (class Test.AA pinned, native unsigned int[0...], native unsigned int, int32) + .locals (class Test.AA pinned, native unsigned int[0...], native unsigned int, int32, native unsigned int[0...] pinned) newobj instance void Test.AA::.ctor() stloc.0 + // test bug fix: make sure to pin Test.AA::m_ai + ldloc.0 + ldfld native unsigned int[0...] Test.AA::m_ai + stloc 4 + ldc.i4 18 stloc.2 |