diff options
author | Egor Chesakov <Egor.Chesakov@microsoft.com> | 2018-10-09 11:37:02 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-09 11:37:02 -0700 |
commit | 8aebd79e8cc3820875457471a543a5fc7cbe0cc4 (patch) | |
tree | 9a74f4b8ab980b79b0f146dba60bb813c8463f38 /tests/src/JIT | |
parent | 39ab08433d9506a338f7e86e723e4d26b95430a1 (diff) | |
download | coreclr-8aebd79e8cc3820875457471a543a5fc7cbe0cc4.tar.gz coreclr-8aebd79e8cc3820875457471a543a5fc7cbe0cc4.tar.bz2 coreclr-8aebd79e8cc3820875457471a543a5fc7cbe0cc4.zip |
[arm64] Fix GitHub 20211 Issue (#20240)
Bug with lowering SIMDIntrinsicGetItem on ARM64 when INS_mov (move w/o sign-extension) was used to copy signed value from Vn.b[i] (or Vn.h[i]) to general register Wd (or Xd) instead of INS_smov (move with sign-extension).
Diffstat (limited to 'tests/src/JIT')
3 files changed, 385 insertions, 0 deletions
diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.cs b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.cs new file mode 100644 index 0000000000..66ead463dd --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.cs @@ -0,0 +1,252 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Numerics; +using System.Runtime.CompilerServices; + +// GitHub 20211: bug with lowering SIMDIntrinsicGetItem on ARM64 +// when INS_mov (move w/o sign-extension) was used to copy signed value +// from Vn.b[i] (or Vn.h[i]) to general register Wd (or Xd) instead of +// INS_smov (move with sign-extension). + +namespace GitHub_20211 +{ + class Program + { + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe sbyte SquareRootAt0(Vector<sbyte> arg) + { + return (sbyte)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe byte SquareRootAt0(Vector<byte> arg) + { + return (byte)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe short SquareRootAt0(Vector<short> arg) + { + return (short)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe ushort SquareRootAt0(Vector<ushort> arg) + { + return (ushort)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe int SquareRootAt0(Vector<int> arg) + { + return (int)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe uint SquareRootAt0(Vector<uint> arg) + { + return (uint)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe long SquareRootAt0(Vector<long> arg) + { + return (long)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe ulong SquareRootAt0(Vector<ulong> arg) + { + return (ulong)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe float SquareRootAt0(Vector<float> arg) + { + return (float)Math.Sqrt(arg[0]); + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe double SquareRootAt0(Vector<double> arg) + { + return (double)Math.Sqrt(arg[0]); + } + + enum Result { Pass, Fail } + + struct TestRunner + { + void TestSquareRootAt0(sbyte arg0) + { + Vector<sbyte> arg = new Vector<sbyte>(arg0); + sbyte actual = SquareRootAt0(arg); + sbyte expected = (sbyte)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: sbyte (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(byte arg0) + { + Vector<byte> arg = new Vector<byte>(arg0); + byte actual = SquareRootAt0(arg); + byte expected = (byte)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: byte (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(short arg0) + { + Vector<short> arg = new Vector<short>(arg0); + short actual = SquareRootAt0(arg); + short expected = (short)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: short (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(ushort arg0) + { + Vector<ushort> arg = new Vector<ushort>(arg0); + ushort actual = SquareRootAt0(arg); + ushort expected = (ushort)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: ushort (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(int arg0) + { + Vector<int> arg = new Vector<int>(arg0); + int actual = SquareRootAt0(arg); + int expected = (int)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: int (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(uint arg0) + { + Vector<uint> arg = new Vector<uint>(arg0); + uint actual = SquareRootAt0(arg); + uint expected = (uint)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: uint (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(long arg0) + { + Vector<long> arg = new Vector<long>(arg0); + long actual = SquareRootAt0(arg); + long expected = (long)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: long (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(ulong arg0) + { + Vector<ulong> arg = new Vector<ulong>(arg0); + ulong actual = SquareRootAt0(arg); + ulong expected = (ulong)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: ulong (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(float arg0) + { + Vector<float> arg = new Vector<float>(arg0); + float actual = SquareRootAt0(arg); + float expected = (float)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: float (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + void TestSquareRootAt0(double arg0) + { + Vector<double> arg = new Vector<double>(arg0); + double actual = SquareRootAt0(arg); + double expected = (double)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: double (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + + Result result; + + public Result Run() + { + result = Result.Pass; + + TestSquareRootAt0((sbyte)-1); + TestSquareRootAt0((short)-1); + TestSquareRootAt0((int)-1); + TestSquareRootAt0((long)-1); + + TestSquareRootAt0((sbyte)1); + TestSquareRootAt0((byte)1); + TestSquareRootAt0((short)1); + TestSquareRootAt0((ushort)1); + TestSquareRootAt0((int)1); + TestSquareRootAt0((uint)1); + TestSquareRootAt0((long)1); + TestSquareRootAt0((ulong)1); + + TestSquareRootAt0((float)4); + TestSquareRootAt0((double)4); + + return result; + } + } + + static int Main(string[] args) + { + if (new TestRunner().Run() == Result.Pass) + { + Console.WriteLine("Pass"); + return 100; + } + else + { + return 0; + } + } + } +} diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.csproj b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.csproj new file mode 100644 index 0000000000..301c10fbf9 --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.csproj @@ -0,0 +1,35 @@ +<?xml version="1.0" encoding="utf-8"?> +<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> + <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> + <PropertyGroup> + <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> + <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> + <AssemblyName>$(MSBuildProjectName)</AssemblyName> + <SchemaVersion>2.0</SchemaVersion> + <ProjectGuid>{95DFC527-4DC1-495E-97D7-E94EE1F7140D}</ProjectGuid> + <OutputType>Exe</OutputType> + <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> + <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> + <AllowUnsafeBlocks>true</AllowUnsafeBlocks> + </PropertyGroup> + <!-- Default configurations to help VS understand the configurations --> + <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "></PropertyGroup> + <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "></PropertyGroup> + <ItemGroup> + <CodeAnalysisDependentAssemblyPaths Condition=" '$(VS100COMNTOOLS)' != '' " Include="$(VS100COMNTOOLS)..\IDE\PrivateAssemblies"> + <Visible>False</Visible> + </CodeAnalysisDependentAssemblyPaths> + </ItemGroup> + <PropertyGroup> + <DebugType>None</DebugType> + <Optimize>True</Optimize> + </PropertyGroup> + <ItemGroup> + <Compile Include="$(MSBuildProjectName).cs" /> + </ItemGroup> + <ItemGroup> + <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> + </ItemGroup> + <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" /> + <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup> +</Project> diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.tt b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.tt new file mode 100644 index 0000000000..3d8e2eb37e --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_20211/GitHub_20211.tt @@ -0,0 +1,98 @@ +<#@ template debug="false" hostspecific="true" language="C#" #> +<#@ output extension=".cs" #> +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Numerics; +using System.Runtime.CompilerServices; + +// GitHub 20211: bug with lowering SIMDIntrinsicGetItem on ARM64 +// when INS_mov (move w/o sign-extension) was used to copy signed value +// from Vn.b[i] (or Vn.h[i]) to general register Wd (or Xd) instead of +// INS_smov (move with sign-extension). + +namespace GitHub_20211 +{ + class Program + { +<# + string[] typeNames = { "sbyte", "byte", "short", "ushort", "int", "uint", "long", "ulong", "float", "double" }; + foreach (string typeName in typeNames) + { +#> + [MethodImpl(MethodImplOptions.NoInlining)] + static unsafe <#= typeName #> SquareRootAt0(Vector<<#= typeName #>> arg) + { + return (<#= typeName #>)Math.Sqrt(arg[0]); + } + +<# + } +#> + enum Result { Pass, Fail } + + struct TestRunner + { +<# + foreach (string typeName in typeNames) + { +#> + void TestSquareRootAt0(<#= typeName #> arg0) + { + Vector<<#= typeName #>> arg = new Vector<<#= typeName #>>(arg0); + <#= typeName #> actual = SquareRootAt0(arg); + <#= typeName #> expected = (<#= typeName #>)Math.Sqrt(arg0); + + if (actual != expected) + { + Console.WriteLine($"Fail: <#= typeName #> (actual={actual}, expected={expected})"); + result = Result.Fail; + } + } + +<# + } +#> + Result result; + + public Result Run() + { + result = Result.Pass; + + TestSquareRootAt0((sbyte)-1); + TestSquareRootAt0((short)-1); + TestSquareRootAt0((int)-1); + TestSquareRootAt0((long)-1); + + TestSquareRootAt0((sbyte)1); + TestSquareRootAt0((byte)1); + TestSquareRootAt0((short)1); + TestSquareRootAt0((ushort)1); + TestSquareRootAt0((int)1); + TestSquareRootAt0((uint)1); + TestSquareRootAt0((long)1); + TestSquareRootAt0((ulong)1); + + TestSquareRootAt0((float)4); + TestSquareRootAt0((double)4); + + return result; + } + } + + static int Main(string[] args) + { + if (new TestRunner().Run() == Result.Pass) + { + Console.WriteLine("Pass"); + return 100; + } + else + { + return 0; + } + } + } +} |