diff options
author | Andy Ayers <andya@microsoft.com> | 2017-02-21 18:13:25 -0800 |
---|---|---|
committer | Andy Ayers <andya@microsoft.com> | 2017-02-21 18:13:25 -0800 |
commit | f60e421e3cc6c6c7160bc3b679e8a08530ae275a (patch) | |
tree | 670dc5512ce3cbaea424873e0155e1505910d122 /tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj | |
parent | ccd082706fb108fe813b98a12da46fe551983c71 (diff) | |
download | coreclr-f60e421e3cc6c6c7160bc3b679e8a08530ae275a.tar.gz coreclr-f60e421e3cc6c6c7160bc3b679e8a08530ae275a.tar.bz2 coreclr-f60e421e3cc6c6c7160bc3b679e8a08530ae275a.zip |
Fix jit test projects to specify debug type and optimization flags
This partially addresses the issues raised in #4124 and #4724 by explicitly
and unconditionally setting DebugType and Optimize flags for various test
project files.
The projects that were fixed are those that did not specify any debug
flag settings at all. The fix is to set DebugType to PdbOnly and to set
Optimization to true, unless the test has an _r or _rel suffix, in which
case Optimization is set false.
This impacts 1497 projects, skipping over 311 projects flagged as needing
fixes. The projects that remain are the CodeGenBringUp set (for which we plan
to clone projects to test the various flag combinations), projects that
specify flags but do so in ways where the effective flag settings may vary
from DBG to RET, projects that specify the flags redundantly, or projects
where the flags are not consistent with the "test case name suffix" rules.
The edits were done by a tool using linq-to-xml and so some incidental
reformatting has happened.
Diffstat (limited to 'tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj')
-rw-r--r-- | tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj b/tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj index fecd93a0e7..73c195d3e4 100644 --- a/tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj +++ b/tests/src/JIT/Methodical/flowgraph/bug619534/twoEndFinallys_il.ilproj @@ -1,4 +1,4 @@ -<?xml version="1.0" encoding="utf-8"?> +<?xml version="1.0" encoding="utf-8"?> <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> <PropertyGroup> @@ -16,18 +16,18 @@ <NuGetPackageImportStamp>7a9bfb7d</NuGetPackageImportStamp> </PropertyGroup> <!-- Default configurations to help VS understand the configurations --> - <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> - </PropertyGroup> - <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> + <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "></PropertyGroup> + <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "></PropertyGroup> + <PropertyGroup> + <DebugType>PdbOnly</DebugType> + <Optimize>True</Optimize> </PropertyGroup> <ItemGroup> <CodeAnalysisDependentAssemblyPaths Condition=" '$(VS100COMNTOOLS)' != '' " Include="$(VS100COMNTOOLS)..\IDE\PrivateAssemblies"> <Visible>False</Visible> </CodeAnalysisDependentAssemblyPaths> </ItemGroup> - <PropertyGroup> - - </PropertyGroup> + <PropertyGroup></PropertyGroup> <ItemGroup> <Compile Include="twoEndFinallys.il" /> </ItemGroup> @@ -35,6 +35,5 @@ <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> </ItemGroup> <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" /> - <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "> - </PropertyGroup> + <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup> </Project>
\ No newline at end of file |