diff options
| author | Russ Keldorph <Russ.Keldorph@microsoft.com> | 2016-05-06 16:27:37 -0700 |
|---|---|---|
| committer | Russ Keldorph <Russ.Keldorph@microsoft.com> | 2016-05-09 08:08:04 -0700 |
| commit | d496eb2dc41c895a855bc216fafa81f30f5e8ee2 (patch) | |
| tree | eec74d9271ed856ce338c3645d009c4ce5ce1d53 /tests/src/JIT/IL_Conformance | |
| parent | d3ff29a3e359b60c4c2fc0e21c1d6c99999157ea (diff) | |
| download | coreclr-d496eb2dc41c895a855bc216fafa81f30f5e8ee2.tar.gz coreclr-d496eb2dc41c895a855bc216fafa81f30f5e8ee2.tar.bz2 coreclr-d496eb2dc41c895a855bc216fafa81f30f5e8ee2.zip | |
Fix conv_ovf_i8_i test
Test has at least four problems:
- It assumes native int = int32, so disable it for 64-bit
- It is just wrong in a couple of its assumptions about when overflow
happens during unsigned conversions.
- On success, it returns 0xAAAA instead of the commonly accepted 100
- It has no copyright header
Also piggybacking a copyright fix for rem_r4.il that I missed earlier
Diffstat (limited to 'tests/src/JIT/IL_Conformance')
3 files changed, 10 insertions, 3 deletions
diff --git a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.il b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.il index 03bd915161..4102fc60db 100644 --- a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.il +++ b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.il @@ -1,3 +1,6 @@ +// Copyright (c) Microsoft. All rights reserved. +// Licensed under the MIT license. See LICENSE file in the project root for full license information. + .assembly extern legacy library mscorlib {} @@ -167,13 +170,13 @@ END2: ldc.i8 0xFFFFFFFF80000000 ldc.i4 0x80000000 call int32 conv_ovf_i4::conv_un(int64,int32) - ldc.i4 0x11111111 + ldc.i4 0xEEEEEEEE ceq brfalse FAIL ldc.i8 0xFFFFFFFFFFFFFFFF ldc.i4 0xFFFFFFFF call int32 conv_ovf_i4::conv_un(int64,int32) - ldc.i4 0x11111111 + ldc.i4 0xEEEEEEEE ceq brfalse FAIL ldc.i8 0x0000000000000000 @@ -196,7 +199,7 @@ END2: brfalse FAIL PASS: - ldc.i4 0xAAAA + ldc.i4 100 br END FAIL: diff --git a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.ilproj b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.ilproj index fa25664523..8e211e740f 100644 --- a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.ilproj +++ b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/conv_ovf_i8_i.ilproj @@ -14,6 +14,8 @@ <ReferencePath>$(ProgramFiles)\Common Files\microsoft shared\VSTT .0\UITestExtensionPackages</ReferencePath> <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> <NuGetPackageImportStamp>7a9bfb7d</NuGetPackageImportStamp> + <DisableProjectBuild Condition="'$(Platform)' == 'x64'">true</DisableProjectBuild> + <DisableProjectBuild Condition="'$(Platform)' == 'arm64'">true</DisableProjectBuild> </PropertyGroup> <!-- Default configurations to help VS understand the configurations --> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> diff --git a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/rem_r4.il b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/rem_r4.il index e17ee1ba4a..e9ce7ac115 100644 --- a/tests/src/JIT/IL_Conformance/Old/Conformance_Base/rem_r4.il +++ b/tests/src/JIT/IL_Conformance/Old/Conformance_Base/rem_r4.il @@ -1,3 +1,5 @@ +// Copyright (c) Microsoft. All rights reserved. +// Licensed under the MIT license. See LICENSE file in the project root for full license information. .assembly extern System.Console { |