diff options
| author | Eugene Rozenfeld <erozen@microsoft.com> | 2016-09-14 12:41:47 -0700 |
|---|---|---|
| committer | Eugene Rozenfeld <erozen@microsoft.com> | 2016-09-21 10:30:30 -0700 |
| commit | 79f0faf49be6b03061287bcc566b9f5726eae360 (patch) | |
| tree | 4bc5881c970fc1d69456be8f85241e1dd04eec48 /tests/issues.targets | |
| parent | 21e4eb9cd224c6fa257c810d270e3ff45b12a63e (diff) | |
| download | coreclr-79f0faf49be6b03061287bcc566b9f5726eae360.tar.gz coreclr-79f0faf49be6b03061287bcc566b9f5726eae360.tar.bz2 coreclr-79f0faf49be6b03061287bcc566b9f5726eae360.zip | |
Fix for StackOverflow in SsaBuilder::TopologicalSort.
SsaBuilder::TopologicalSort allocated an array of bools on the stack.
In one of internal cases the array had 126,758 elements, which caused a
StackOverflow. This change switches SsaBuilder::TopologicalSort from
stack-allocated array of bools to BitVec.
TopologicalSortHelper used to be recursive. It was changed to use an iterative
algorithm in a previous change. I'm inlining TopologicalSortHelper into
TopologicalSort now.
I verified no measurable negative throughput impact from this change
and no asm diffs in SuperPMI.
Diffstat (limited to 'tests/issues.targets')
| -rw-r--r-- | tests/issues.targets | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/issues.targets b/tests/issues.targets index ee45e589de..ff2b314789 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -234,6 +234,9 @@ <ExcludeList Include="$(XunitTestBinBase)\managed\Compilation\Compilation\Compilation.cmd"> <Issue>needs triage</Issue> </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\JitBlue\DevDiv_255294\DevDiv_255294\DevDiv_255294.cmd"> + <Issue>The test is too large for x86 and causes OutOfMemory exception.</Issue> + </ExcludeList> </ItemGroup> <!-- The following x86 failures only occur with RyuJIT/x86 --> |