diff options
| author | Swaroop Sridhar <Swaroop.Sridhar@microsoft.com> | 2019-01-12 22:25:25 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-01-12 22:25:25 -0800 |
| commit | 8b7d300c164971f573d8186e78204597a679c7d8 (patch) | |
| tree | 4bae0726ff3cb5b97c43ad127b8b41a117e2c06f /tests/issues.targets | |
| parent | 908891ce9df8d94f28ec6a53a012d39d00c8e65d (diff) | |
| download | coreclr-8b7d300c164971f573d8186e78204597a679c7d8.tar.gz coreclr-8b7d300c164971f573d8186e78204597a679c7d8.tar.bz2 coreclr-8b7d300c164971f573d8186e78204597a679c7d8.zip | |
Add NativeLibrary Resolve Event (#21929)
This change adds the Native library resolving event, to be raised as the last attempt to resolve a native DLL in an AssemblyLoadContext.
With this change, the DllImport resolution sequence is as follows (stopping at any step with successful resolution):
* If the invoking-assembly is not in the default load context, call AssemblyLoadContext.LoadUnmanagedDll()
* Run the default load logic, try loading from:
* AppDomain cache
* NATIVE_DLL_SEARCH_DIRECTORIES
* Invoking-assembly directory, System32, etc. based on DllImportSearchPaths
* Raise the ResolvingUnmanagedDll event
API Review: https://github.com/dotnet/corefx/issues/32850
The ResolveEventTests triggered a pre-existing bug in the exception handling code (#21964).
Disabling the test on ARM64 Windows until the issue is fixed.
Diffstat (limited to 'tests/issues.targets')
| -rw-r--r-- | tests/issues.targets | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/issues.targets b/tests/issues.targets index 11043ffd2a..fd1d96558f 100644 --- a/tests/issues.targets +++ b/tests/issues.targets @@ -388,6 +388,9 @@ <ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/DefaultInterfaceMethods/methodimpl/methodimpl/*"> <Issue>9565</Issue> </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/Interop/NativeLibraryResolveEvent/ResolveEventTests/*"> + <Issue>21964</Issue> + </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/16064/methodimpl/*"> <Issue>9565</Issue> </ExcludeList> @@ -819,6 +822,9 @@ <ExcludeList Include="$(XunitTestBinBase)/Interop/NativeLibrary/NativeLibraryTests/*"> <Issue>Issue building native components for the test. Since tests are currently built on Windows, the native components end up at Core_Root instead of Test directory, which is not suitable for the test.</Issue> </ExcludeList> + <ExcludeList Include="$(XunitTestBinBase)/Interop/MarshalAPI/ResolveEvent/ResolveEventTests/*"> + <Issue>Issue building native components for the test. Since tests are currently built on Windows, the native components end up at Core_Root instead of Test directory, which is not suitable for the test.</Issue> + </ExcludeList> <ExcludeList Include="$(XunitTestBinBase)/CoreMangLib/cti/system/byte/ByteToString3/*"> <Issue>needs triage</Issue> </ExcludeList> |