diff options
author | Steve MacLean <sdmaclea.qdt@qualcommdatacenter.com> | 2017-10-06 11:25:14 -0400 |
---|---|---|
committer | Steve MacLean <sdmaclea.qdt@qualcommdatacenter.com> | 2017-10-06 11:34:17 -0400 |
commit | f6c7baa1a34a2542c7d9c4946a486f2cef78c49b (patch) | |
tree | 0ff656acf228272d354e47cc8b7a701abf43ce99 /src | |
parent | fdf8606b62288725caf4ba04fed7e3aaf3f03e5a (diff) | |
download | coreclr-f6c7baa1a34a2542c7d9c4946a486f2cef78c49b.tar.gz coreclr-f6c7baa1a34a2542c7d9c4946a486f2cef78c49b.tar.bz2 coreclr-f6c7baa1a34a2542c7d9c4946a486f2cef78c49b.zip |
Fix comments per review
Diffstat (limited to 'src')
-rw-r--r-- | src/jit/codegenarm64.cpp | 9 | ||||
-rw-r--r-- | src/jit/importer.cpp | 4 |
2 files changed, 9 insertions, 4 deletions
diff --git a/src/jit/codegenarm64.cpp b/src/jit/codegenarm64.cpp index 6e35f6b910..ca0c39f6f3 100644 --- a/src/jit/codegenarm64.cpp +++ b/src/jit/codegenarm64.cpp @@ -2675,8 +2675,10 @@ void CodeGen::genLockedInstructions(GenTreeOp* treeNode) regNumber storeDataReg = (treeNode->OperGet() == GT_XCHG) ? dataReg : treeNode->ExtractTempReg(RBM_ALLINT); regNumber loadReg = (targetReg != REG_NA) ? targetReg : storeDataReg; - // The register allocator should have extended the lifetime of the address - // so that it is not used as the target. + // Check allocator assumptions + // + // The register allocator should have extended the lifetimes of all input and internal registers so that + // none interfere with the target. noway_assert(addrReg != targetReg); noway_assert(addrReg != loadReg); @@ -2783,6 +2785,9 @@ void CodeGen::genCodeForCmpXchg(GenTreeCmpXchg* treeNode) regNumber exResultReg = treeNode->ExtractTempReg(RBM_ALLINT); // Check allocator assumptions + // + // The register allocator should have extended the lifetimes of all input and internal registers so that + // none interfere with the target. noway_assert(addrReg != targetReg); noway_assert(dataReg != targetReg); noway_assert(comparandReg != targetReg); diff --git a/src/jit/importer.cpp b/src/jit/importer.cpp index e0c08e43da..3c837b3f33 100644 --- a/src/jit/importer.cpp +++ b/src/jit/importer.cpp @@ -3410,7 +3410,7 @@ GenTreePtr Compiler::impIntrinsic(GenTreePtr newobjThis, op1->gtFlags |= GTF_GLOB_REF | GTF_ASG; retNode = op1; break; -#endif // _TARGET_XARCH_ +#endif // defined(_TARGET_XARCH_) || defined(_TARGET_ARM64_) case CORINFO_INTRINSIC_MemoryBarrier: @@ -3442,7 +3442,7 @@ GenTreePtr Compiler::impIntrinsic(GenTreePtr newobjThis, retNode = node; break; } -#endif +#endif // defined(_TARGET_XARCH_) || defined(_TARGET_ARM64_) case CORINFO_INTRINSIC_StringLength: op1 = impPopStack().val; |