summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDong-Heon Jung <dheon.jung@samsung.com>2019-08-30 21:05:53 (GMT)
committerGleb Balykov <g.balykov@samsung.com>2020-03-25 12:29:41 (GMT)
commitefa62c091a5c9a2729f8948c1d3703156fb78e3b (patch)
treec1d104e16f236b1650100712debef5fac80ed798 /src
parent06a2676689168f5190c29e7638a47a783cb9258b (diff)
downloadcoreclr-efa62c091a5c9a2729f8948c1d3703156fb78e3b.zip
coreclr-efa62c091a5c9a2729f8948c1d3703156fb78e3b.tar.gz
coreclr-efa62c091a5c9a2729f8948c1d3703156fb78e3b.tar.bz2
Mark Relocation Section as NotNeeded (#25715)
- After relocation, relocation section in zap image is not necessary. - Mark the section as NotNeeded by giving advice(madvise with MADV_DONTNEED) - It reduces 120~150KB PSS in tizen sample apps.
Diffstat (limited to 'src')
-rw-r--r--src/pal/inc/pal.h16
-rw-r--r--src/pal/src/include/pal/map.hpp7
-rw-r--r--src/pal/src/loader/module.cpp33
-rw-r--r--src/pal/src/map/map.cpp51
-rw-r--r--src/vm/peimagelayout.cpp3
5 files changed, 110 insertions, 0 deletions
diff --git a/src/pal/inc/pal.h b/src/pal/inc/pal.h
index 11b434d..5a4e758 100644
--- a/src/pal/inc/pal.h
+++ b/src/pal/inc/pal.h
@@ -2755,6 +2755,22 @@ Return value:
BOOL
PAL_LOADUnloadPreloadedPEFiles();
+/*++
+ PAL_LOADMarkSectionAsNotNeeded
+
+ Mark a section as NotNeeded that was loaded by PAL_LOADLoadPEFile().
+
+Parameters:
+ IN ptr - the section address mapped by PAL_LOADLoadPEFile()
+
+Return value:
+ TRUE - success
+ FALSE - failure (incorrect ptr, etc.)
+--*/
+BOOL
+PALAPI
+PAL_LOADMarkSectionAsNotNeeded(void * ptr);
+
#ifdef UNICODE
#define LoadLibrary LoadLibraryW
#define LoadLibraryEx LoadLibraryExW
diff --git a/src/pal/src/include/pal/map.hpp b/src/pal/src/include/pal/map.hpp
index 16ee58e..a2d8e2b 100644
--- a/src/pal/src/include/pal/map.hpp
+++ b/src/pal/src/include/pal/map.hpp
@@ -138,6 +138,13 @@ extern "C"
returns TRUE if successful, FALSE otherwise
--*/
BOOL MAPUnmapPEFile(LPCVOID lpAddress);
+
+ /*++
+ Function :
+ MAPMarkSectionAsNotNeeded - mark a section as NotNeeded
+ returns TRUE if successful, FALSE otherwise
+ --*/
+ BOOL MAPMarkSectionAsNotNeeded(LPCVOID lpAddress);
}
namespace CorUnix
diff --git a/src/pal/src/loader/module.cpp b/src/pal/src/loader/module.cpp
index 78069b8..35c51ac 100644
--- a/src/pal/src/loader/module.cpp
+++ b/src/pal/src/loader/module.cpp
@@ -1000,6 +1000,39 @@ PAL_LOADUnloadPEFile(PVOID ptr)
}
/*++
+ PAL_LOADMarkSectionAsNotNeeded
+
+ Mark a section as NotNeeded that was loaded by PAL_LOADLoadPEFile().
+
+Parameters:
+ IN ptr - the section address mapped by PAL_LOADLoadPEFile()
+
+Return value:
+ TRUE - success
+ FALSE - failure (incorrect ptr, etc.)
+--*/
+BOOL
+PALAPI
+PAL_LOADMarkSectionAsNotNeeded(void * ptr)
+{
+ BOOL retval = FALSE;
+
+ ENTRY("PAL_LOADMarkSectionAsNotNeeded (ptr=%p)\n", ptr);
+
+ if (nullptr == ptr)
+ {
+ ERROR( "Invalid pointer value\n" );
+ }
+ else
+ {
+ retval = MAPMarkSectionAsNotNeeded(ptr);
+ }
+
+ LOGEXIT("PAL_LOADMarkSectionAsNotNeeded returns %d\n", retval);
+ return retval;
+}
+
+/*++
PAL_GetSymbolModuleBase
Get base address of the module containing a given symbol
diff --git a/src/pal/src/map/map.cpp b/src/pal/src/map/map.cpp
index 6caf5e1..aadd04d 100644
--- a/src/pal/src/map/map.cpp
+++ b/src/pal/src/map/map.cpp
@@ -3173,3 +3173,54 @@ BOOL MAPUnmapPEFile(LPCVOID lpAddress)
TRACE_(LOADER)("MAPUnmapPEFile returning %d\n", retval);
return retval;
}
+
+/*++
+Function :
+ MAPMarkSectionAsNotNeeded - Mark a section as NotNeeded
+ returns TRUE if successful, FALSE otherwise
+--*/
+BOOL MAPMarkSectionAsNotNeeded(LPCVOID lpAddress)
+{
+ TRACE_(LOADER)("MAPMarkSectionAsNotNeeded(lpAddress=%p)\n", lpAddress);
+
+ if ( NULL == lpAddress )
+ {
+ ERROR_(LOADER)( "lpAddress cannot be NULL\n" );
+ return FALSE;
+ }
+
+ BOOL retval = TRUE;
+ CPalThread * pThread = InternalGetCurrentThread();
+ InternalEnterCriticalSection(pThread, &mapping_critsec);
+ PLIST_ENTRY pLink, pLinkNext = NULL;
+
+ // Look through the entire MappedViewList for all mappings associated with the
+ // section with an address 'lpAddress' which we want to mark as NotNeeded.
+
+ for(pLink = MappedViewList.Flink;
+ pLink != &MappedViewList;
+ pLink = pLinkNext)
+ {
+ pLinkNext = pLink->Flink;
+ PMAPPED_VIEW_LIST pView = CONTAINING_RECORD(pLink, MAPPED_VIEW_LIST, Link);
+
+ if (pView->lpAddress == lpAddress) // this entry is associated with the section
+ {
+ if (-1 == madvise(pView->lpAddress, pView->NumberOfBytesToMap, MADV_DONTNEED))
+ {
+ ERROR_(LOADER)("Unable to mark the section as NotNeeded.\n");
+ retval = FALSE;
+ }
+ else
+ {
+ pView->dwDesiredAccess = 0;
+ }
+ break;
+ }
+ }
+
+ InternalLeaveCriticalSection(pThread, &mapping_critsec);
+
+ TRACE_(LOADER)("MAPMarkSectionAsNotNeeded returning %d\n", retval);
+ return retval;
+}
diff --git a/src/vm/peimagelayout.cpp b/src/vm/peimagelayout.cpp
index 1d08558..719c90e 100644
--- a/src/vm/peimagelayout.cpp
+++ b/src/vm/peimagelayout.cpp
@@ -296,6 +296,9 @@ void PEImageLayout::ApplyBaseRelocations(BOOL isRelocated)
ThrowLastError();
}
}
+#ifdef FEATURE_PAL
+ PAL_LOADMarkSectionAsNotNeeded((void*)dir);
+#endif // FEATURE_PAL
#endif // CROSSGEN_COMPILE
if (pFlushRegion != NULL)