summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAditya Mandaleeka <adityamandaleeka@users.noreply.github.com>2019-02-05 12:21:50 -0800
committerGitHub <noreply@github.com>2019-02-05 12:21:50 -0800
commit1e1f7d3a88cb91605a3c9716a5354a64ed707a4f (patch)
tree150a90540923b625fa802044a62f6b39b5ad59e4 /src
parent658e017cb3d1ca2938b41493fa54df6126f4463c (diff)
parentdb2faf25d287fff2654af044503a5e97b2cef83e (diff)
downloadcoreclr-1e1f7d3a88cb91605a3c9716a5354a64ed707a4f.tar.gz
coreclr-1e1f7d3a88cb91605a3c9716a5354a64ed707a4f.tar.bz2
coreclr-1e1f7d3a88cb91605a3c9716a5354a64ed707a4f.zip
Merge pull request #22415 from adityamandaleeka/pinvoke_eh
Disable PInvoke inlining within try regions on ARM64
Diffstat (limited to 'src')
-rw-r--r--src/jit/importer.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/jit/importer.cpp b/src/jit/importer.cpp
index 163779c72a..477b12448d 100644
--- a/src/jit/importer.cpp
+++ b/src/jit/importer.cpp
@@ -6696,10 +6696,12 @@ bool Compiler::impCanPInvokeInlineCallSite(BasicBlock* block)
return true;
}
-#ifdef _TARGET_AMD64_
- // On x64, we disable pinvoke inlining inside of try regions.
- // Here is the comment from JIT64 explaining why:
+#ifdef _TARGET_64BIT_
+ // On 64-bit platforms, we disable pinvoke inlining inside of try regions.
+ // Note that this could be needed on other architectures too, but we
+ // haven't done enough investigation to know for sure at this point.
//
+ // Here is the comment from JIT64 explaining why:
// [VSWhidbey: 611015] - because the jitted code links in the
// Frame (instead of the stub) we rely on the Frame not being
// 'active' until inside the stub. This normally happens by the
@@ -6721,7 +6723,7 @@ bool Compiler::impCanPInvokeInlineCallSite(BasicBlock* block)
{
return false;
}
-#endif // _TARGET_AMD64_
+#endif // _TARGET_64BIT_
return true;
}