diff options
| author | Koundinya Veluri <kouvel@users.noreply.github.com> | 2018-08-17 08:31:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-17 08:31:44 -0700 |
| commit | f6174b93d100d46f4641f040b6de5fa254c1ee71 (patch) | |
| tree | bfe4f7b09fc8ce854c37cdd68025e19be161a57f /src | |
| parent | a81d9103d23f714a0bd3efb900321b0b9f383311 (diff) | |
| download | coreclr-f6174b93d100d46f4641f040b6de5fa254c1ee71.tar.gz coreclr-f6174b93d100d46f4641f040b6de5fa254c1ee71.tar.bz2 coreclr-f6174b93d100d46f4641f040b6de5fa254c1ee71.zip | |
Enable Tiered Compilation by default (#19525)
Enable Tiered Compilation by default
1) Changes the default state of the tiered compilation feature check to be ON BY DEFAULT
2) Removed comments about the source about this being a work in progress. Although it will surely continue to evolve and improve, remaining issues would be better tracked in our issue tracking system with the same default presumption as other runtime features - assume it works unless noted otherwise.
3) Adjusts a number of tests and automated scripts that made assumptions that the default setting of this feature is off.
4) Stop accepting the deprecated env var COMPLUS_EXPERIMENTAL_TieredCompilation. I'm not aware it has any remaining usage but if so we're going to find out.
5) Adjust config names for JitBench
Diffstat (limited to 'src')
| -rw-r--r-- | src/inc/clrconfigvalues.h | 3 | ||||
| -rw-r--r-- | src/vm/eeconfig.cpp | 4 | ||||
| -rw-r--r-- | src/vm/tieredcompilation.cpp | 9 |
3 files changed, 2 insertions, 14 deletions
diff --git a/src/inc/clrconfigvalues.h b/src/inc/clrconfigvalues.h index e0cad9d962..0d843fbade 100644 --- a/src/inc/clrconfigvalues.h +++ b/src/inc/clrconfigvalues.h @@ -651,8 +651,7 @@ RETAIL_CONFIG_DWORD_INFO(INTERNAL_HillClimbing_GainExponent, /// Tiered Compilation /// #ifdef FEATURE_TIERED_COMPILATION -RETAIL_CONFIG_DWORD_INFO(EXTERNAL_TieredCompilation, W("TieredCompilation"), 0, "Enables tiered compilation") -RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_LEGACY_TieredCompilation, W("EXPERIMENTAL_TieredCompilation"), 0, "Deprecated - Use COMPLUS_TieredCompilation") +RETAIL_CONFIG_DWORD_INFO(EXTERNAL_TieredCompilation, W("TieredCompilation"), 1, "Enables tiered compilation") RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_TieredCompilation_Tier1CallCountThreshold, W("TieredCompilation_Tier1CallCountThreshold"), 30, "Number of times a method must be called after which it is promoted to tier 1.") RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_TieredCompilation_Tier1CallCountingDelayMs, W("TieredCompilation_Tier1CallCountingDelayMs"), 100, "A perpetual delay in milliseconds that is applied to tier 1 call counting and jitting, while there is tier 0 activity.") RETAIL_CONFIG_DWORD_INFO(UNSUPPORTED_TieredCompilation_Tier1DelaySingleProcMultiplier, W("TieredCompilation_Tier1DelaySingleProcMultiplier"), 10, "Multiplier for TieredCompilation_Tier1CallCountingDelayMs that is applied on a single-processor machine or when the process is affinitized to a single processor.") diff --git a/src/vm/eeconfig.cpp b/src/vm/eeconfig.cpp index 41f80d8ba3..37864f1f83 100644 --- a/src/vm/eeconfig.cpp +++ b/src/vm/eeconfig.cpp @@ -1237,9 +1237,7 @@ HRESULT EEConfig::sync() dwSleepOnExit = CLRConfig::GetConfigValue(CLRConfig::UNSUPPORTED_SleepOnExit); #if defined(FEATURE_TIERED_COMPILATION) - fTieredCompilation = Configuration::GetKnobBooleanValue(W("System.Runtime.TieredCompilation"), CLRConfig::EXTERNAL_TieredCompilation) || - //this older name is deprecated, but still accepted for a time. Preserving it is a very small overhead not to needlessly break things. - CLRConfig::GetConfigValue(CLRConfig::UNSUPPORTED_LEGACY_TieredCompilation) != 0; + fTieredCompilation = Configuration::GetKnobBooleanValue(W("System.Runtime.TieredCompilation"), CLRConfig::EXTERNAL_TieredCompilation) != 0; fTieredCompilation_CallCounting = CLRConfig::GetConfigValue(CLRConfig::UNSUPPORTED_TieredCompilation_Test_CallCounting) != 0; fTieredCompilation_OptimizeTier0 = CLRConfig::GetConfigValue(CLRConfig::UNSUPPORTED_TieredCompilation_Test_OptimizeTier0) != 0; diff --git a/src/vm/tieredcompilation.cpp b/src/vm/tieredcompilation.cpp index 7945973aa9..9c9e76de18 100644 --- a/src/vm/tieredcompilation.cpp +++ b/src/vm/tieredcompilation.cpp @@ -20,15 +20,6 @@ // handles logistics of getting new code created and installed. // // -// # Current feature state -// -// This feature is a work in progress. It should be functionally correct for a -// good range of scenarios, but performance varies by scenario. To enable it -// you need to set COMPLUS_TieredCompilation = 1. This feature has been -// tested with all of our runtime and CoreFX functional tests, as well as -// diagnostics tests and various partner testing in Visual Studio. -// -// // # Important entrypoints in this code: // // |