diff options
| author | Mike Danes <onemihaid@hotmail.com> | 2017-09-17 16:57:44 +0300 |
|---|---|---|
| committer | Mike Danes <onemihaid@hotmail.com> | 2017-09-18 16:59:37 +0300 |
| commit | 5dda1f9fdf263744fef57f008fa8a083a2bfcfcb (patch) | |
| tree | ae6cefa2a39b838adedc0256e9781aa83a8f4725 /src | |
| parent | 08053aef66b1bf1d61de4ee744181ec265718327 (diff) | |
| download | coreclr-5dda1f9fdf263744fef57f008fa8a083a2bfcfcb.tar.gz coreclr-5dda1f9fdf263744fef57f008fa8a083a2bfcfcb.tar.bz2 coreclr-5dda1f9fdf263744fef57f008fa8a083a2bfcfcb.zip | |
Remove useless TODO from genCompareInt
gtSetEvalOrder already does this. And even if it doesn't it's not the job of genCompareInt to swap operands, that should happen in LowerCompare.
Attempting to do this in LowerCompare resulted in 0 diffs.
Diffstat (limited to 'src')
| -rw-r--r-- | src/jit/codegenxarch.cpp | 4 | ||||
| -rw-r--r-- | src/jit/lowerxarch.cpp | 3 |
2 files changed, 1 insertions, 6 deletions
diff --git a/src/jit/codegenxarch.cpp b/src/jit/codegenxarch.cpp index 45bcdc2ef8..f8bad9e944 100644 --- a/src/jit/codegenxarch.cpp +++ b/src/jit/codegenxarch.cpp @@ -6303,9 +6303,7 @@ void CodeGen::genCompareInt(GenTreePtr treeNode) genConsumeOperands(tree); - // TODO-CQ: We should be able to support swapping op1 and op2 to generate cmp reg, imm. - // https://github.com/dotnet/coreclr/issues/7270 - assert(!op1->isContainedIntOrIImmed()); // We no longer support + assert(!op1->isContainedIntOrIImmed()); assert(!varTypeIsFloating(op2Type)); instruction ins; diff --git a/src/jit/lowerxarch.cpp b/src/jit/lowerxarch.cpp index 67a6d05004..bb45279887 100644 --- a/src/jit/lowerxarch.cpp +++ b/src/jit/lowerxarch.cpp @@ -1859,9 +1859,6 @@ void Lowering::ContainCheckCompare(GenTreeOp* cmp) } else if (op1->IsCnsIntOrI()) { - // TODO-CQ: We should be able to support swapping op1 and op2 to generate cmp reg, imm, - // but there is currently an assert in CodeGen::genCompareInt(). - // https://github.com/dotnet/coreclr/issues/7270 SetRegOptional(op2); } else |