diff options
author | Gaurav Khanna <gkhanna@microsoft.com> | 2017-05-02 13:14:01 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-05-02 13:14:01 -0700 |
commit | 6fe0bf5cd4921c9c3f0c183c04653d711fd442b0 (patch) | |
tree | 1ae6c6350b8c3efd019b73424a552d539112b2cf /src | |
parent | 46d03758b52d43d35b54038472c5942762aa8c18 (diff) | |
download | coreclr-6fe0bf5cd4921c9c3f0c183c04653d711fd442b0.tar.gz coreclr-6fe0bf5cd4921c9c3f0c183c04653d711fd442b0.tar.bz2 coreclr-6fe0bf5cd4921c9c3f0c183c04653d711fd442b0.zip |
Enable LoadFrom to pickup assemblies next to requesting assembly (#11333)
* Enable LoadFrom to pickup assemblies from next to requestor
* Make early out explicit
Diffstat (limited to 'src')
-rw-r--r-- | src/mscorlib/src/System/Reflection/Assembly.CoreCLR.cs | 63 |
1 files changed, 63 insertions, 0 deletions
diff --git a/src/mscorlib/src/System/Reflection/Assembly.CoreCLR.cs b/src/mscorlib/src/System/Reflection/Assembly.CoreCLR.cs index 708f79b64f..79f06f30e3 100644 --- a/src/mscorlib/src/System/Reflection/Assembly.CoreCLR.cs +++ b/src/mscorlib/src/System/Reflection/Assembly.CoreCLR.cs @@ -15,11 +15,74 @@ namespace System.Reflection { public abstract partial class Assembly : ICustomAttributeProvider, ISerializable { + private static volatile bool s_LoadFromResolveHandlerSetup = false; + private static object s_syncRootLoadFrom = new object(); + private static List<string> s_LoadFromAssemblyList = new List<string>(); + private static object s_syncLoadFromAssemblyList = new object(); + + private static Assembly LoadFromResolveHandler(object sender, ResolveEventArgs args) + { + Assembly requestingAssembly = args.RequestingAssembly; + + // Requesting assembly for LoadFrom is always loaded in defaultContext - proceed only if that + // is the case. + if (AssemblyLoadContext.Default != AssemblyLoadContext.GetLoadContext(requestingAssembly)) + return null; + + // Get the path where requesting assembly lives and check if it is in the list + // of assemblies for which LoadFrom was invoked. + bool fRequestorLoadedViaLoadFrom = false; + string requestorPath = Path.GetFullPath(requestingAssembly.Location); + if (string.IsNullOrEmpty(requestorPath)) + return null; + + lock(s_syncLoadFromAssemblyList) + { + fRequestorLoadedViaLoadFrom = s_LoadFromAssemblyList.Contains(requestorPath); + } + + // If the requestor assembly was not loaded using LoadFrom, exit. + if (!fRequestorLoadedViaLoadFrom) + return null; + + // Requestor assembly was loaded using loadFrom, so look for its dependencies + // in the same folder as it. + // Form the name of the assembly using the path of the assembly that requested its load. + AssemblyName requestedAssemblyName = new AssemblyName(args.Name); + string requestedAssemblyPath = Path.Combine(Path.GetDirectoryName(requestorPath), requestedAssemblyName.Name+".dll"); + + return AssemblyLoadContext.Default.LoadFromAssemblyPath(requestedAssemblyPath); + } + public static Assembly LoadFrom(String assemblyFile) { if (assemblyFile == null) throw new ArgumentNullException(nameof(assemblyFile)); + string fullPath = Path.GetFullPath(assemblyFile); + + if (!s_LoadFromResolveHandlerSetup) + { + lock (s_syncRootLoadFrom) + { + if (!s_LoadFromResolveHandlerSetup) + { + AppDomain.CurrentDomain.AssemblyResolve += new ResolveEventHandler(LoadFromResolveHandler); + s_LoadFromResolveHandlerSetup = true; + } + } + } + + // Add the path to the LoadFrom path list which we will consult + // before handling the resolves in our handler. + lock(s_syncLoadFromAssemblyList) + { + if (!s_LoadFromAssemblyList.Contains(fullPath)) + { + s_LoadFromAssemblyList.Add(fullPath); + } + } + return AssemblyLoadContext.Default.LoadFromAssemblyPath(fullPath); } |