Fix DynamicMethodDesc memory leak (#21891)

The DynamicMethodTable::AddMethodsToList was incorrectly allocating the
MethodDescChunk from the domain's LoaderAllocator instead of the context
specific one. Thus the allocated memory was leaking after a collectible
AssemblyLoadContext was collected.

There was also a problem with the DynamicMethodDesc::Destroy being
called twice for collectible classes - once by
RuntimeMethodHandle::Destroy() and once when the DomainFile destructor
was called. Due to the primary issue, this problem was not visible,
since the domain's LoaderAllocator is never unmapped. But it started to
cause AV after the primary issue was fixed.

1 files changed, 1 insertions, 8 deletions

diff --git a/src/vm/method.cpp b/src/vm/method.cpp
index 9c19c688ac..09bc2cbf9f 100644
--- a/src/vm/method.cpp
+++ b/src/vm/method.cpp
@@ -226,14 +226,7 @@ BaseDomain *MethodDesc::GetDomain()
 //*******************************************************************************
 LoaderAllocator * MethodDesc::GetLoaderAllocatorForCode()
 {
-    if (IsLCGMethod())
-    {
-        return ::GetAppDomain()->GetLoaderAllocator();
-    }
-    else
-    {
-        return GetLoaderAllocator();
-    }
+    return GetLoaderAllocator();
 }