diff options
| author | Eugene Rozenfeld <erozen@microsoft.com> | 2018-12-16 12:07:42 -0800 |
|---|---|---|
| committer | Eugene Rozenfeld <erozen@microsoft.com> | 2018-12-21 22:38:52 -0800 |
| commit | eea057675de7914af12c6168db0f3bebea35be5b (patch) | |
| tree | 7b3134b62a2707e32fbf00d4c0138a39099d3a75 /src/vm/jitinterface.h | |
| parent | 0a1374f4f7c2141bf6d8ad74a68dd329afdbee78 (diff) | |
| download | coreclr-eea057675de7914af12c6168db0f3bebea35be5b.tar.gz coreclr-eea057675de7914af12c6168db0f3bebea35be5b.tar.bz2 coreclr-eea057675de7914af12c6168db0f3bebea35be5b.zip | |
Improve removal of dead calls to allocator helpers.
This change improves detection of allocators with side effects.
Allocators can cause side effects if the allocated object may have a finalizer.
This change adds a pHasSideEffects parameter to getNewHelper JitEE interface
method. It's used by the jit to check for allocator side effects instead of
guessing from helper ids.
Fixes #21530.
Diffstat (limited to 'src/vm/jitinterface.h')
| -rw-r--r-- | src/vm/jitinterface.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/vm/jitinterface.h b/src/vm/jitinterface.h index 4c23de9b51..1a949fec31 100644 --- a/src/vm/jitinterface.h +++ b/src/vm/jitinterface.h @@ -516,8 +516,8 @@ public: // considered when checking visibility rules. - CorInfoHelpFunc getNewHelper(CORINFO_RESOLVED_TOKEN * pResolvedToken, CORINFO_METHOD_HANDLE callerHandle); - static CorInfoHelpFunc getNewHelperStatic(MethodTable * pMT); + CorInfoHelpFunc getNewHelper(CORINFO_RESOLVED_TOKEN * pResolvedToken, CORINFO_METHOD_HANDLE callerHandle, bool * pHasSideEffects = NULL); + static CorInfoHelpFunc getNewHelperStatic(MethodTable * pMT, bool * pHasSideEffects = NULL); CorInfoHelpFunc getNewArrHelper(CORINFO_CLASS_HANDLE arrayCls); static CorInfoHelpFunc getNewArrHelperStatic(TypeHandle clsHnd); |