diff options
author | Austin Wise <AustinWise@gmail.com> | 2018-10-07 18:58:10 -0700 |
---|---|---|
committer | Jan Kotas <jkotas@microsoft.com> | 2018-10-07 18:58:10 -0700 |
commit | eeef1c1379b9f49261f66093b355ac8c12e47485 (patch) | |
tree | 353e440ccdf0c4c3f3571fc4c096d4f1c95ebe4e /src/vm/jitinterface.cpp | |
parent | 645faa5b24c32741944cad55f58fd66d6c8abfa4 (diff) | |
download | coreclr-eeef1c1379b9f49261f66093b355ac8c12e47485.tar.gz coreclr-eeef1c1379b9f49261f66093b355ac8c12e47485.tar.bz2 coreclr-eeef1c1379b9f49261f66093b355ac8c12e47485.zip |
Remove some dead remoting and context static things (#20277)
* Remove IsRemotingIntercepted methods that always return false.
* Remove GetOptionalMembersAllocationSize parameters that are always false.
* Remove references to context static.
Remove references in comments and methodnames.
* Remove RemotingVtsInfo.
Diffstat (limited to 'src/vm/jitinterface.cpp')
-rw-r--r-- | src/vm/jitinterface.cpp | 23 |
1 files changed, 3 insertions, 20 deletions
diff --git a/src/vm/jitinterface.cpp b/src/vm/jitinterface.cpp index 5067a36077..7532f5e9aa 100644 --- a/src/vm/jitinterface.cpp +++ b/src/vm/jitinterface.cpp @@ -5373,23 +5373,14 @@ void CEEInfo::getCallInfo( if (devirt) { - // We can't allow generic remotable methods to be considered resolved, it leads to a non-instantiating method desc being - // passed to the remoting stub. The easiest way to deal with these is to force them through the virtual code path. - // It is actually good to do this deoptimization for all remotable methods since remoting interception via vtable dispatch - // is faster then remoting interception via thunk - if (!pTargetMD->IsRemotingInterceptedViaVirtualDispatch() /* || !pTargetMD->HasMethodInstantiation() */) - { - resolvedCallVirt = true; - directCall = true; - } + resolvedCallVirt = true; + directCall = true; } } if (directCall) { - bool allowInstParam = (flags & CORINFO_CALLINFO_ALLOWINSTPARAM) - // See code:IsRemotingInterceptedViaPrestub on why we need need to disallow inst param for remoting. - && !( pTargetMD->MayBeRemotingIntercepted() && !pTargetMD->IsVtableMethod() ); + bool allowInstParam = (flags & CORINFO_CALLINFO_ALLOWINSTPARAM); // Create instantiating stub if necesary if (!allowInstParam && pTargetMD->RequiresInstArg()) @@ -7875,12 +7866,6 @@ CorInfoInline CEEInfo::canInline (CORINFO_METHOD_HANDLE hCaller, { dwRestrictions |= INLINE_NO_CALLEE_LDSTR; } - - // The remoting interception can be skipped only if the call is on same this pointer - if (pCallee->MayBeRemotingIntercepted()) - { - dwRestrictions |= INLINE_SAME_THIS; - } } #ifdef PROFILING_SUPPORTED @@ -9169,8 +9154,6 @@ void CEEInfo::getFunctionEntryPoint(CORINFO_METHOD_HANDLE ftnHnd, // should never get here for EnC methods or if interception via remoting stub is required _ASSERTE(!ftn->IsEnCMethod()); - _ASSERTE((accessFlags & CORINFO_ACCESS_THIS) || !ftn->IsRemotingInterceptedViaVirtualDispatch()); - ret = (void *)ftn->GetAddrOfSlot(); if (MethodTable::VTableIndir2_t::isRelative |