summaryrefslogtreecommitdiff
path: root/src/vm/gcenv.ee.cpp
diff options
context:
space:
mode:
authorSean Gillespie <segilles@microsoft.com>2017-11-27 15:41:09 -0800
committerGitHub <noreply@github.com>2017-11-27 15:41:09 -0800
commitc755e3b7f5d597c8d192675dbaaa337268d93f1c (patch)
treec54615b358f473644924c83b2560df56346ff621 /src/vm/gcenv.ee.cpp
parent4e625b8cecd63dd6f0acaf82e28731f28ab9901d (diff)
downloadcoreclr-c755e3b7f5d597c8d192675dbaaa337268d93f1c.tar.gz
coreclr-c755e3b7f5d597c8d192675dbaaa337268d93f1c.tar.bz2
coreclr-c755e3b7f5d597c8d192675dbaaa337268d93f1c.zip
[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)
* [Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks * Code review feedback: 1. Rename OverlappedData->AsyncPinned in interface methods 2. Remove additional FEATURE_REDHAWK defines around async pin relocation code * Eliminate two GCToEEInterface callbacks by passing the callbacks directly as arguments to a method on IGCHandleStore * Repair clang build * Split pin and async pin handle scans into two separate callbacks * Fix the clang and non-Windows builds
Diffstat (limited to 'src/vm/gcenv.ee.cpp')
-rw-r--r--src/vm/gcenv.ee.cpp81
1 files changed, 79 insertions, 2 deletions
diff --git a/src/vm/gcenv.ee.cpp b/src/vm/gcenv.ee.cpp
index e5da889a64..a880fdbca6 100644
--- a/src/vm/gcenv.ee.cpp
+++ b/src/vm/gcenv.ee.cpp
@@ -1201,7 +1201,7 @@ namespace
};
InlineSString<MaxThreadNameSize> wideName;
- const WCHAR* namePtr;
+ const WCHAR* namePtr = nullptr;
EX_TRY
{
if (name != nullptr)
@@ -1214,7 +1214,6 @@ namespace
{
// we're not obligated to provide a name - if it's not valid,
// just report nullptr as the name.
- namePtr = nullptr;
}
EX_END_CATCH(SwallowAllExceptions)
@@ -1307,3 +1306,81 @@ bool GCToEEInterface::CreateThread(void (*threadStart)(void*), void* arg, bool i
return CreateNonSuspendableThread(threadStart, arg, name);
}
}
+
+void GCToEEInterface::WalkAsyncPinnedForPromotion(Object* object, ScanContext* sc, promote_func* callback)
+{
+ LIMITED_METHOD_CONTRACT;
+
+ assert(object != nullptr);
+ assert(sc != nullptr);
+ assert(callback != nullptr);
+ if (object->GetGCSafeMethodTable() != g_pOverlappedDataClass)
+ {
+ // not an overlapped data object - nothing to do.
+ return;
+ }
+
+ // reporting the pinned user objects
+ OverlappedDataObject *pOverlapped = (OverlappedDataObject *)object;
+ if (pOverlapped->m_userObject != NULL)
+ {
+ //callback(OBJECTREF_TO_UNCHECKED_OBJECTREF(pOverlapped->m_userObject), (ScanContext *)lp1, GC_CALL_PINNED);
+ if (pOverlapped->m_isArray)
+ {
+ // OverlappedDataObject is very special. An async pin handle keeps it alive.
+ // During GC, we also make sure
+ // 1. m_userObject itself does not move if m_userObject is not array
+ // 2. Every object pointed by m_userObject does not move if m_userObject is array
+ // We do not want to pin m_userObject if it is array. But m_userObject may be updated
+ // during relocation phase before OverlappedDataObject is doing relocation.
+ // m_userObjectInternal is used to track the location of the m_userObject before it is updated.
+ pOverlapped->m_userObjectInternal = static_cast<void*>(OBJECTREFToObject(pOverlapped->m_userObject));
+ ArrayBase* pUserObject = (ArrayBase*)OBJECTREFToObject(pOverlapped->m_userObject);
+ Object **ppObj = (Object**)pUserObject->GetDataPtr(TRUE);
+ size_t num = pUserObject->GetNumComponents();
+ for (size_t i = 0; i < num; i++)
+ {
+ callback(ppObj + i, sc, GC_CALL_PINNED);
+ }
+ }
+ else
+ {
+ callback(&OBJECTREF_TO_UNCHECKED_OBJECTREF(pOverlapped->m_userObject), (ScanContext *)sc, GC_CALL_PINNED);
+ }
+ }
+
+ if (pOverlapped->GetAppDomainId() != DefaultADID && pOverlapped->GetAppDomainIndex().m_dwIndex == DefaultADID)
+ {
+ OverlappedDataObject::MarkCleanupNeededFromGC();
+ }
+}
+
+void GCToEEInterface::WalkAsyncPinned(Object* object, void* context, void (*callback)(Object*, Object*, void*))
+{
+ LIMITED_METHOD_CONTRACT;
+
+ assert(object != nullptr);
+ assert(callback != nullptr);
+
+ if (object->GetGCSafeMethodTable() != g_pOverlappedDataClass)
+ {
+ return;
+ }
+
+ OverlappedDataObject *pOverlapped = (OverlappedDataObject *)(object);
+ if (pOverlapped->m_userObject != NULL)
+ {
+ Object * pUserObject = OBJECTREFToObject(pOverlapped->m_userObject);
+ callback(object, pUserObject, context);
+ if (pOverlapped->m_isArray)
+ {
+ ArrayBase* pUserArrayObject = (ArrayBase*)pUserObject;
+ Object **pObj = (Object**)pUserArrayObject->GetDataPtr(TRUE);
+ size_t num = pUserArrayObject->GetNumComponents();
+ for (size_t i = 0; i < num; i ++)
+ {
+ callback(pUserObject, pObj[i], context);
+ }
+ }
+ }
+}