summaryrefslogtreecommitdiff
path: root/src/vm/diagnosticserver.h
diff options
context:
space:
mode:
authorJosé Rivero <jorive@microsoft.com>2019-04-02 07:06:42 -0700
committerGitHub <noreply@github.com>2019-04-02 07:06:42 -0700
commit40dda195590873d18236bfbc7742bb6fe7305730 (patch)
tree4c45036684f5c4c2cf6d38f19a95626ac5fc2082 /src/vm/diagnosticserver.h
parentd6dad7520ea0bac3894e908835d0321075df822d (diff)
downloadcoreclr-40dda195590873d18236bfbc7742bb6fe7305730.tar.gz
coreclr-40dda195590873d18236bfbc7742bb6fe7305730.tar.bz2
coreclr-40dda195590873d18236bfbc7742bb6fe7305730.zip
[EventPipe] Streaming events out-of-proc using IPC (#23448)
- There was a race condition on EventPipe::Disable where we deallocated the s_pSession and set it to NULL, but there was still a thread waiting to write and dereference the null pointer. Now, we check that the session is not null. - Added a new attach event to be handled to the Diagnostic server: Add streaming functionality (Syncronus) #23299 - On Linux, IPC was failing when delete was invoked because we were using new (std::nothrow) instead of new (nothrow) when allocating the newly connected clients/streams. I have replaced the call with new. This fixed #23580 - Move multiFileTraceLengthInSeconds out of the EventPipeSession. - Unlink previously existing socket. - EventPipeBlock: _ASSERTE was updated not to fail when data is not aligned if an error has already occurred. - Update _ASSERTE in fastserializer.cpp to take into account the the write operation could have failed.
Diffstat (limited to 'src/vm/diagnosticserver.h')
-rw-r--r--src/vm/diagnosticserver.h14
1 files changed, 3 insertions, 11 deletions
diff --git a/src/vm/diagnosticserver.h b/src/vm/diagnosticserver.h
index 51f32ae09f..76ad3eff23 100644
--- a/src/vm/diagnosticserver.h
+++ b/src/vm/diagnosticserver.h
@@ -20,17 +20,9 @@ enum class DiagnosticMessageType : uint32_t
// EventPipe
EnableEventPipe = 1024,
DisableEventPipe,
-
- // TODO: Define what else is available on the out-of-proc interface?
- // GetSessionInfo,
- // CreateProvider,
- // DefineEvent,
- // GetProvider,
- // DeleteProvider,
- // EventActivityIdControl,
- // WriteEvent,
- // WriteEventData,
- // GetNextEvent,
+ StreamEventPipe,
+ AttachEventPipe,
+ DetachEventPipe,
///////////////////////////////////////////////////////////////////////////
// Profiler = 2048