summaryrefslogtreecommitdiff
path: root/src/vm/arm64/asmhelpers.asm
diff options
context:
space:
mode:
authorBrian Sullivan <briansul@microsoft.com>2016-07-12 13:52:20 -0700
committerBrian Sullivan <briansul@microsoft.com>2016-07-26 16:16:51 -0700
commitfeb33b9085f202ac9e6331fdf4dc02751d89cf8d (patch)
tree6b4305ad73b35818bfaa6249b671aff082c32c59 /src/vm/arm64/asmhelpers.asm
parent35e1d3bea2446a3ad6d5470b685a612b022052ad (diff)
downloadcoreclr-feb33b9085f202ac9e6331fdf4dc02751d89cf8d.tar.gz
coreclr-feb33b9085f202ac9e6331fdf4dc02751d89cf8d.tar.bz2
coreclr-feb33b9085f202ac9e6331fdf4dc02751d89cf8d.zip
Enable multireg returns on Arm64
Added method IsMultiRegPassedType and updated IsMultiRegReturnType Switched these methods to using getArgTypeForStruct and getReturnTypeForStruct Removed IsRegisterPassable and used IsMultiRegReturned instead. Converted lvIsMultiregStruct to use getArgTypeForStruct Renamed varDsc->lvIsMultiregStruct() to compiler->lvaIsMultiregStruct(varDsc) Skip calling getPrimitiveTypeForStruct when we have a struct larger than 8 bytes Refactored ReturnTypeDesc::InitializeReturnType Fixed missing SPK_ByReference case in InitializeReturnType Fixes for RyiJIt x86 TYP_LONG return types and additional ARM64 work for full multireg support Added ARM64 guard the uses of MAX_RET_MULTIREG_BYTES with FEATURE_MULTIREG_RET Fixes for multireg returns in Arm64 Codegen Added dumping of lvIsMultiRegArg and lvIsMultiRegRet in the assembly output Added check and set of compFloatingPointUsed to InitializeStructReturnType Fixes to handle JIT helper calls that say they return a TYP_STRUCT with no class handle available Placed all of the second GC return reg under MULTIREG_HAS_SECOND_GC_RET ifdefs Added the Arm64 VM changes from Rahul's PR 5175 Update getArgTypeForStruct for x86/arm32 so that it returns TYP_STRUCT for all pass by value cases Fixes for the passing of 3,5,6 or 7 byte sized structs Fix issue on ARM64 where we would back fill into x7 after passing a 16-byte struct on the stack Implemented register shuffling for multi reg Call returns on Arm64 Fixed regression on Arm32 for struct args that are not multi regs Updated Tests.Lst with 23 additional passing tests Changes from codereview feedback
Diffstat (limited to 'src/vm/arm64/asmhelpers.asm')
-rw-r--r--src/vm/arm64/asmhelpers.asm26
1 files changed, 17 insertions, 9 deletions
diff --git a/src/vm/arm64/asmhelpers.asm b/src/vm/arm64/asmhelpers.asm
index 72794adef1..89e6710a96 100644
--- a/src/vm/arm64/asmhelpers.asm
+++ b/src/vm/arm64/asmhelpers.asm
@@ -779,10 +779,10 @@ UMThunkStub_WrongAppDomain
; remaining arguments are unused
bl UM2MDoADCallBack
- ; restore integral return value
- ldr x0, [fp, #16]
+ ; restore any integral return value(s)
+ ldp x0, x1, [fp, #16]
- ; restore FP or HFA return value
+ ; restore any FP or HFA return value(s)
RESTORE_FLOAT_ARGUMENT_REGISTERS sp, 0
b UMThunkStub_PostCall
@@ -857,9 +857,10 @@ UM2MThunk_WrapperHelper_RegArgumentsSetup
blr x16
- ; save integral return value
- str x0, [x19]
- ; save FP/HFA return values
+ ; save any integral return value(s)
+ stp x0, x1, [x19]
+
+ ; save any FP or HFA return value(s)
SAVE_FLOAT_ARGUMENT_REGISTERS x19, -1 * (SIZEOF__FloatArgumentRegisters + 16)
EPILOG_STACK_RESTORE
@@ -931,13 +932,20 @@ UM2MThunk_WrapperHelper_RegArgumentsSetup
PROLOG_SAVE_REG_PAIR x25, x26, #64
PROLOG_SAVE_REG_PAIR x27, x28, #80
- str x0, [sp, #96]
- ; HFA return value can be in d0-d3
+ ; save any integral return value(s)
+ stp x0, x1, [sp, #96]
+
+ ; save any FP/HFA return value(s)
stp d0, d1, [sp, #112]
stp d2, d3, [sp, #128]
+
mov x0, sp
bl OnHijackScalarWorker
- ldr x0, [sp, #96]
+
+ ; restore any integral return value(s)
+ ldp x0, x1, [sp, #96]
+
+ ; restore any FP/HFA return value(s)
ldp d0, d1, [sp, #112]
ldp d2, d3, [sp, #128]