Fix for bugs related to clasifying System.TypedReference.

It was a long standing assumption in the Jit that a field of a struct can
never be of ByRef type. It turns out this assumption is not entirely
holding.
The System.TypedReference is a very special type that is a struct, defined
to have two IntPtr fields. When the VM instantiates this type it changes
the type of the first field to ByRef.
This change closes a GC hole in the passing this struct by value on the
stack. It adds support to the classification algorithm for ByRef
references. It also uses the tree types for generating the code that
places struct field on the stack by value for passin to a callee.

The handling of GT_RETURN in the codegenxarch.cpp has been extracted as a
separate routine - genReturn. In case of struct return (multi-register
struct return or an implicit retBuf return, it delegates to the
genStructReturn method. This is a refactoring as well as making
sure that GT_RETFILT is handled properly - the return type of it is always
bool or void for the last statement of a finally block.

More feedback addressed.

1 files changed, 4 insertions, 2 deletions

diff --git a/src/vm/argdestination.h b/src/vm/argdestination.h
index 7837e51086..803d5f2454 100644
--- a/src/vm/argdestination.h
+++ b/src/vm/argdestination.h
@@ -144,7 +144,8 @@ public:
                 if (eightByteSize == 8)
                 {
                     _ASSERTE((eightByteClassification == SystemVClassificationTypeInteger) ||
-                             (eightByteClassification == SystemVClassificationTypeIntegerReference));
+                             (eightByteClassification == SystemVClassificationTypeIntegerReference) ||
+                             (eightByteClassification == SystemVClassificationTypeIntegerByRef));
 
                     _ASSERTE(IS_ALIGNED((SIZE_T)genRegDest, 8));
                     *(UINT64*)genRegDest = *(UINT64*)src;
@@ -193,7 +194,8 @@ public:
 
             if (eightByteClassification != SystemVClassificationTypeSSE)
             {
-                if (eightByteClassification == SystemVClassificationTypeIntegerReference)
+                if ((eightByteClassification == SystemVClassificationTypeIntegerReference) ||
+                    (eightByteClassification == SystemVClassificationTypeIntegerByRef))
                 {
                     _ASSERTE(eightByteSize == 8);
                     _ASSERTE(IS_ALIGNED((SIZE_T)genRegDest, 8));